Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5031CC76195 for ; Wed, 15 Mar 2023 05:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231172AbjCOFJ3 (ORCPT ); Wed, 15 Mar 2023 01:09:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229673AbjCOFJ2 (ORCPT ); Wed, 15 Mar 2023 01:09:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CFB2303D1; Tue, 14 Mar 2023 22:09:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DE33D61AE1; Wed, 15 Mar 2023 05:09:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFBAEC433EF; Wed, 15 Mar 2023 05:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678856966; bh=7p1RRx9+XkDkqvizYy0bDO5wuozBvMSp7CyYMO1H56M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SQVUyhCdLQ2YCdAQVPt1rxwEqkJiWgtZc3mySReH40HdOwD1Ee5OpgR9g8O9a2iin oiUDpnAptNWTQJBMWQ9XuFZbjFMdGAc/boJ7WdiHAamwE4tbLx0qrUQgNZfdaegqt6 DS7NCF/W3rdHMyxyrGD67oNfRZbqZotsWKJdgDoyQxdl2GmCP6ai+/Esl2sW96dw9T KJH29KtiIS+XpT5IgxRTZ5jlErQPRpLuKhkD9hXSAmZwwNQ4+3pgsK9z3XZX34Bkae Ewg52wUON0DaFuD4vIkYW37g6ZU40k1iWHxuz/txORyTtLZqAotqDCynXdFm7pt2uu iKGBHGcOI7w0g== Date: Tue, 14 Mar 2023 22:09:24 -0700 From: Jakub Kicinski To: Jason Xing Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, stephen@networkplumber.org, simon.horman@corigine.com, sinquersw@gmail.com, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Xing Subject: Re: [PATCH v3 net-next 2/2] net: introduce budget_squeeze to help us tune rx behavior Message-ID: <20230314220924.52dfb803@kernel.org> In-Reply-To: <20230314131427.85135-3-kerneljasonxing@gmail.com> References: <20230314131427.85135-1-kerneljasonxing@gmail.com> <20230314131427.85135-3-kerneljasonxing@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Mar 2023 21:14:27 +0800 Jason Xing wrote: > When we encounter some performance issue and then get lost on how > to tune the budget limit and time limit in net_rx_action() function, > we can separately counting both of them to avoid the confusion. More details please, we can't tell whether your solution makes sense if we don't know what your problem is.