From:   Kalle Valo <kvalo@kernel.org>
To:     Christian Lamparter <chunkeey@gmail.com>
Cc:     Arnd Bergmann <arnd@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
        Tony Lindgren <tony@atomide.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>,
        Felipe Balbi <balbi@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        =?utf-8?Q?Beno=C3=AEt?= Cousson <bcousson@baylibre.com>,
        Russell King <linux@armlinux.org.uk>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] p54spi: convert to devicetree
References: <20230314163201.955689-1-arnd@kernel.org>
        <e8dc9acb-6f85-e0a9-a145-d101ca6da201@gmail.com>
Date:   Wed, 15 Mar 2023 07:32:57 +0200
In-Reply-To: <e8dc9acb-6f85-e0a9-a145-d101ca6da201@gmail.com> (Christian
        Lamparter's message of "Tue, 14 Mar 2023 21:18:55 +0100")
Message-ID: <87jzziwpdi.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Christian Lamparter <chunkeey@gmail.com> writes:

> Hi,
>
> On 3/14/23 17:30, Arnd Bergmann wrote:
>> The Prism54 SPI driver hardcodes GPIO numbers and expects users to
>> pass them as module parameters, apparently a relic from its life as a
>> staging driver. This works because there is only one user, the Nokia
>> N8x0 tablet.
>>
>> Convert this to the gpio descriptor interface and move the gpio
>> line information into devicetree to improve this and simplify the
>> code at the same time.
>
> Yes, this is definitely the right idea/way. From what I remember, Kalle
> Valo was partially involved in p54spi/stlc45xx. The details are very fuzzy.
> So,  I could be totally wrong. From what I remember Kalle was working
> for Nokia (or as a contractor for Nokia?) at the time.

I wrote stlc45xx driver as part of my thesis when working for Nokia and
I think then someone wrote p54spi after that. Oh man, this was a long
time ago so hard to remember :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches