Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D88C6FD1D for ; Wed, 15 Mar 2023 05:41:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231539AbjCOFlN (ORCPT ); Wed, 15 Mar 2023 01:41:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229678AbjCOFlK (ORCPT ); Wed, 15 Mar 2023 01:41:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90C994347E; Tue, 14 Mar 2023 22:41:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1045C61AED; Wed, 15 Mar 2023 05:41:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 789DDC433EF; Wed, 15 Mar 2023 05:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678858866; bh=FXai2qLa/oxwiLINWHjW+akZur4pSld/3ZcuGMVc30Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SQuoLTKrYJs2COu6Qkxi1TsG3DVOypXfLjk4NYc9xP5LQTgot2jL8VGx0RsYCzHRQ ebQeuI5EgWlygrnWeOQB8I+P2YHGOQPFObBwd3FgMEgZlDmRzde7PThKvm8bgpbTo/ GOFLLGd1Y+Iknth/r6bhfJbsiA97l9Y4xnTkUHZaaUmPeHQK6wzcg09dmFMDDUtwqj ouUhe9wMN8pgYJ3pWB3AxSqMZ/42vYJ3V9FfTxJVWl1E40Q9N/NG17vohokSOftUzv D6S+aNeaDZk1Nz2T+tRVQaZSm8Ngl3TDZhlMADtHe+XUxQH1SAkAMj9CpqH3svmnNy wL4hubqX9Jf7g== Date: Tue, 14 Mar 2023 22:41:04 -0700 From: Jakub Kicinski To: Niklas Schnelle Cc: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Paolo Abeni , Michael Grzeschik , Wolfgang Grandegger , Marc Kleine-Budde , Jesse Brandeburg , Tony Nguyen , "Maciej W. Rozycki" , Ralf Baechle , Greg Kroah-Hartman , Bjorn Helgaas , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , netdev@vger.kernel.org, linux-can@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-hams@vger.kernel.org Subject: Re: [PATCH v3 20/38] net: handle HAS_IOPORT dependencies Message-ID: <20230314224104.71db5ab4@kernel.org> In-Reply-To: <20230314121216.413434-21-schnelle@linux.ibm.com> References: <20230314121216.413434-1-schnelle@linux.ibm.com> <20230314121216.413434-21-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Mar 2023 13:11:58 +0100 Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers requiring them. For the DEFXX driver there use of I/O > ports is optional and we only need to fence those paths.can It also > turns out that with HAS_IOPORT handled explicitly HAMRADIO does not need > the !S390 dependency and successfully builds the bpqether driver. Acked-by: Jakub Kicinski