Message-ID: <e3ae62c36cfe49abc5371009ba6c29cddc2f2ebe.camel@gmail.com>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: don't dispose of Global2 IRQ
 mappings from mdiobus code
From:   Klaus Kudielka <klaus.kudielka@gmail.com>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Vladimir Oltean <vladimir.oltean@nxp.com>
Date:   Wed, 15 Mar 2023 07:07:57 +0100
In-Reply-To: <20230314200100.7r2pmj3pb4aew7gp@skbuf>
References: <20230314182659.63686-1-klaus.kudielka@gmail.com>
         <20230314182659.63686-2-klaus.kudielka@gmail.com>
         <ed91b3db532bfe7131635990acddd82d0a276640.camel@gmail.com>
         <20230314200100.7r2pmj3pb4aew7gp@skbuf>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-1 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-03-14 at 22:01 +0200, Vladimir Oltean wrote:
>=20
> I'm a bit puzzled as to how you managed to get just this one patch to
> have a different subject-prefix from the others?

A long story, don't laugh at me.

I imported your patch with "git am", but I imported the "mbox" of the
complete message. That was the start of the disaster.

The whole E-mail was in the commit message (also the notes before the
patch), but that was easy to fix.

After git format-patch, checkpatch complained that your "From" E-mail
!=3D "Signed-off-by" E-mail. Obviously git has taken the "From" from the
first E-mail header.

I looked again at your patch, there it was right,=C2=A0and there was also
a different date (again same root cause).

So I took the shortcut: Just copy/pasted the whole patch header into
the generated patch file, without thinking further -> Boom.

(a) Don't use "git am" blindly
(b) Don't take shortcuts in the process