Message-ID: <19ca470e-8219-5ba9-3de6-f4560278f87b@linaro.org>
Date:   Wed, 15 Mar 2023 08:11:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] p54spi: convert to devicetree
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
        Christian Lamparter <chunkeey@googlemail.com>,
        Kalle Valo <kvalo@kernel.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux-OMAP <linux-omap@vger.kernel.org>,
        Tony Lindgren <tony@atomide.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>,
        Felipe Balbi <balbi@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        =?UTF-8?Q?Beno=c3=aet_Cousson?= <bcousson@baylibre.com>,
        Russell King <linux@armlinux.org.uk>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20230314163201.955689-1-arnd@kernel.org>
 <4ac809d2-3924-3839-479f-0b4be9f18a1f@linaro.org>
 <e19fd8bc-5944-409d-a4a1-3a3d53691634@app.fastmail.com>
 <57c42604-38b0-61ce-2fc4-2284fbb9d708@linaro.org>
 <afee6a67-2406-4f52-99a2-ee7eb26e587b@app.fastmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <afee6a67-2406-4f52-99a2-ee7eb26e587b@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15/03/2023 07:50, Arnd Bergmann wrote:
> On Wed, Mar 15, 2023, at 07:32, Krzysztof Kozlowski wrote:
>> On 14/03/2023 22:40, Arnd Bergmann wrote:
>>
>>>>> +
>>>>> +  power-gpios:
>>>>
>>>> If this is GPIO driving some power pin, then it should be
>>>> "powerdown-gpios" (like in /bindings/gpio/gpio-consumer-common.yaml)
>>>
>>> As far as I can tell, it's the opposite: the gpio turns the power on
>>> in 'high' state. I could make it GPIO_ACTIVE_LOW and call it powerdown,
>>> if you think that's better, but I don't think that is how it was
>>> meant.
>>
>> Whether this is active low or high, I think does not matter. If this is
>> pin responsible to control the power, then we use the name
>> "powerdown-gpios". Effectively powerup GPIO is the same as powerdown,
>> just reversed.
> 
> Ok, so should I make this GPIO_ACTIVE_LOW and adapt the patch to
> call it powerdown in both the code and dt for consistency?

If you have schematics (or datasheet) then this should reflect truth. If
not, then judging by the old code it is something like powerdown, so yes
- ACTIVE_LOW and reverse values in the code.

Best regards,
Krzysztof