From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org, robh@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH] tty: serdev: serdev-ttyport: set correct tty->dev for serdev framework
Date:   Wed, 15 Mar 2023 15:21:43 +0800
Message-Id: <20230315072143.7815-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T4oRCuCFlnc5oDCVuInkEdm177PXFC+5wcz0CSZ+YFzGajSo9GTE9lng6F2f?=
 =?us-ascii?Q?2EnzKUlHOyJwg9Pv9xRMBdSOZ5SNDPOn0kWqy9FICP6JDDUEiLJ70H4MS5Gg?=
 =?us-ascii?Q?EisHqMS7cN6/1dPLZzMJVdMhX19r6HoYY9tiX8/7zesFjAlgpdW6xtSwY+sE?=
 =?us-ascii?Q?cxjuVrVtv669W5juyDoYxzWYcCQkSIaIgDXuaCSlS8pcbEHrGpyFhQf8ZRiu?=
 =?us-ascii?Q?B4zHfY/wPUNd6RYCrCYgMLhT+AXh7AyTMl6P4mXdvEN6ZmiZA92Ef9/A9yA7?=
 =?us-ascii?Q?XgN8GBAt1eiJGVhNPqajUqUgZG+rko0DrIdKkQp+BG4zHMa9splSpzWjwSEH?=
 =?us-ascii?Q?dSw179jQB0w915wSucjfZ+VK2QoZH/YgiCmHiK0DQIddGKHPNsMpeXeL1wC4?=
 =?us-ascii?Q?HF1bPZocKaTGvje/j86O+a9lvWnauuhMEsybLf7uPO8UeiZEvWbh1ZWipJe+?=
 =?us-ascii?Q?DhUBEWrPZNaQriggi2EolzloDVJta+R+ymuUv+bHSEBbWbcpcEnE33OJBsVc?=
 =?us-ascii?Q?PNaE6wfeA5VHvveNPBC6zGfoivleiNj55zWB4eJP7Zy8BxcBAZp9tyTyfiVc?=
 =?us-ascii?Q?+s1NxGSAcexQK2TY6xeQmnzhccib9P4/ShlDk9k7IDyUDBUyQJYYTLeuzmaY?=
 =?us-ascii?Q?JyLJzisxcOuKSJZOCpT3f2hQB0qTrbATgRlEREzPYGsGde0rVztbhpz2/YLY?=
 =?us-ascii?Q?4y9rr0H9Ycu4vOxlVBdCfPetGxxbPILW/++5KU02EqenaYD5YjAdIe8BjYZH?=
 =?us-ascii?Q?67+EsBYhBmzjwewB4zi8Vb5iIVsK5e7S6UHN0xPVV0HOWjRKWCWM19Y6UFwM?=
 =?us-ascii?Q?7UFMnvXo/0+XlYbTiyKQfkHOPuvRIhlS44j7jfz19M7Nt73BIYqHuk+7kvmd?=
 =?us-ascii?Q?xoyANuHMQhFrNNt1Nwe6sUTsy1IP0kH+7SvmrWaVIUOGH0geYvPlTxn+Z6BX?=
 =?us-ascii?Q?lFOVwSBDCWXa+NTtkCDoYedjCPGicIrYYIHgVIEWAjL1ujT4OP1vGkZZfAu+?=
 =?us-ascii?Q?AkmRJgsUOmg3WfXCHKXntQ4klezQnCpRAy4CY6QKDnbQusNnkVB1YqvZDXSk?=
 =?us-ascii?Q?mhLYLbARZ63RkpAh0Ja7pA/MwGhX8Z1HtxYpPSitfPEjpnPBTtoKSXlnAsnU?=
 =?us-ascii?Q?L0Y7/P+obdU4UZHwTQikkR7aPtQnUeBtogD0MjMj5kenTu5SIl0d0sdzHKdu?=
 =?us-ascii?Q?qvpOLehCDPhl2sXmWsDN2vBqNc0pztUXIQLCLHcAuJT5ly1cFjFZ9j4NEhE2?=
 =?us-ascii?Q?7S89h6uk5QT5UG632Vb1TKtx733EIdZVFYzyDfYmYUqYvo1SCICET4a0/+Kl?=
 =?us-ascii?Q?Jb2Q0iQ2Hp4ZvjWawQUs12Y0z+ws1UUMeRYdnvhayu6CfMW8JpbzYAe4eMpK?=
 =?us-ascii?Q?x4oHDuZiFCoBARUImKfxEjgvC4eaOAoLrRVaS5qOd4izyVUDfsKcDI1A1POi?=
 =?us-ascii?Q?k9skXulxKCn3titaMxhKXN1qkdeesqDyYkJGwEOufP0MYaWOff3oM3Woefw/?=
 =?us-ascii?Q?YDanuFZTOUtTPem3RvSv5++iQQJIJxtkvffkC3EEEEiXktvF/jgBFjvNXHUm?=
 =?us-ascii?Q?GwiPBmBbb8bBpo0FI9zfyme3406IZ7f5htZDGZgk?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe970875-cd82-413a-1eb4-08db2526707d
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 07:25:23.0383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZDmvIy+ocCeVLAHOin0dLEcCeFqUD2mERWabPzV6ez64RU9m3vwncOJLFj/bujQat0DQTMW0rw/CYi1fim3Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8640
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ttyport_open() calls tty_init_dev() to initialize a tty device, but
tty_get_device() cannot get the correct tty->dev for serdev tty in
alloc_tty_struct(), because serdev framework does not set tty_class, so
class_find_device_by_devt(tty_class, devt) may always return NULL.

For serdev framework, we need to assign the correct ctrl->dev to
tty->dev.

Fixes: bed35c6dfa6a ("serdev: add a tty port controller driver")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serdev/serdev-ttyport.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index d367803e2044..bba37ab90215 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -112,6 +112,7 @@ static int ttyport_open(struct serdev_controller *ctrl)
 	tty = tty_init_dev(serport->tty_drv, serport->tty_idx);
 	if (IS_ERR(tty))
 		return PTR_ERR(tty);
+	tty->dev = &ctrl->dev;
 	serport->tty = tty;
 
 	if (!tty->ops->open || !tty->ops->close) {
-- 
2.17.1