Message-ID: <52bd8c2d-31f6-1f69-1d83-cf21ee66aec8@quicinc.com>
Date:   Wed, 15 Mar 2023 15:31:10 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] scsi: ufs: core: print trs for pending requests in MCQ
 mode
Content-Language: en-US
To:     Bart Van Assche <bvanassche@acm.org>, <quic_asutoshd@quicinc.com>,
        <quic_cang@quicinc.com>, <quic_nguyenb@quicinc.com>,
        <mani@kernel.org>, <stanley.chu@mediatek.com>,
        <adrian.hunter@intel.com>, <beanhuo@micron.com>,
        <avri.altman@wdc.com>, <junwoo80.lee@samsung.com>,
        <martin.petersen@oracle.com>
CC:     <linux-scsi@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        open list <linux-kernel@vger.kernel.org>
References: <1678792597-3232-1-git-send-email-quic_ziqichen@quicinc.com>
 <bde102c7-ab4f-a301-072f-8d6b7acde8a8@acm.org>
From:   Ziqi Chen <quic_ziqichen@quicinc.com>
In-Reply-To: <bde102c7-ab4f-a301-072f-8d6b7acde8a8@acm.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

sure

Best Regards,
Ziqi

On 3/15/2023 2:09 AM, Bart Van Assche wrote:
> On 3/14/23 04:16, Ziqi Chen wrote:
>> +static bool ufshcd_print_tr_iter(struct request *req, void *priv)
>> +{
>> +    struct scsi_device *sdev = req->q->queuedata;
>> +    struct Scsi_Host *shost = sdev->host;
>> +    struct ufs_hba *hba = shost_priv(shost);
>> +
>> +    if (!IS_ERR_OR_NULL(hba))
>> +        ufshcd_print_tr(hba, req->tag, *(bool *)priv);
> 
> I think that the "if (!IS_ERR_OR_NULL(hba))" code can be removed safely. 
> Otherwise this patch looks good to me.
> 
> Thanks,
> 
> Bart.