Date:   Wed, 15 Mar 2023 13:11:16 +0530
From:   Manivannan Sadhasivam <mani@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     ulf.hansson@linaro.org, afaerber@suse.de,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mmc: owl-mmc: Use
 devm_platform_get_and_ioremap_resource()
Message-ID: <20230315074116.GB25575@thinkpad>
References: <20230315054113.48898-1-yang.lee@linux.alibaba.com>
 <20230315073912.GA25575@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230315073912.GA25575@thinkpad>
Precedence: bulk

On Wed, Mar 15, 2023 at 01:09:26PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Mar 15, 2023 at 01:41:13PM +0800, Yang Li wrote:
> > According to commit 890cc39a8799 ("drivers: provide
> > devm_platform_get_and_ioremap_resource()"), convert
> > platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.
> > 
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> >  drivers/mmc/host/owl-mmc.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> > index 3dc143b03939..6f9d31a886ba 100644
> > --- a/drivers/mmc/host/owl-mmc.c
> > +++ b/drivers/mmc/host/owl-mmc.c
> > @@ -578,8 +578,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
> >  	owl_host->mmc = mmc;
> >  	spin_lock_init(&owl_host->lock);
> >  
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> 
> You forgot to remove the local variable which is now unused.
> 

Oops, no my bad. It is being used...

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> Thanks,
> Mani
> 
> > -	owl_host->base = devm_ioremap_resource(&pdev->dev, res);
> > +	owl_host->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> >  	if (IS_ERR(owl_host->base)) {
> >  		ret = PTR_ERR(owl_host->base);
> >  		goto err_free_host;
> > -- 
> > 2.20.1.7.g153144c
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்

-- 
மணிவண்ணன் சதாசிவம்