Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ADBDC76195 for ; Wed, 15 Mar 2023 08:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbjCOIRH convert rfc822-to-8bit (ORCPT ); Wed, 15 Mar 2023 04:17:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbjCOIRF (ORCPT ); Wed, 15 Mar 2023 04:17:05 -0400 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F4246286B; Wed, 15 Mar 2023 01:17:04 -0700 (PDT) Received: by mail-qv1-f42.google.com with SMTP id cu4so11638946qvb.3; Wed, 15 Mar 2023 01:17:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678868223; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0V0QfuKISCsuOFNxrXLROjtKcqlhxKao9KY/kU4MtCE=; b=Sz2J6d6/wEGEzzaDTff+nAWLIYyFRKYfvzBMi5TyGWkNvErIHDNFhNkBTEJOS7S3+o AGAr0xzSnSub8k32+tj5pxKDcM62QTMmishiE1IgYCVSsf3Poe9hmPZfL5pfgGk6dONu PKgfG24SKkt2Li5jMaZ2Y/+vtfPnQ2q7Jhd+vDm9sTfXdd2qG1YledC2m46s4beIYooz xfTXL3Y6AVJk3xiIegDY4Spr49vs1ZWDEMwuY6ZFOJCHePYQi0c7n9h+w9pejrxrpBw1 aK4S7IN62dfieU5YJkAqoSjJCNywXbjx7jnWk79vrIeQljXAPXfp88pGFJB67LZytROx Vtvw== X-Gm-Message-State: AO0yUKUwJUWYgTPUeqNREEnhvzTpbY+eawuxF8zXTElf2lEQYWvmoCDE MczGPiaqzQDIkGy15MSoE/sfOXg1cPUoIL1B X-Google-Smtp-Source: AK7set9b4gjFSfD8vRQVIE3sF46b8E3Y1Dt5JH57Nq7usykqdSTmxhgmZA+ZsculXiDVGm+nk81CCg== X-Received: by 2002:a05:622a:1991:b0:3d5:500a:4808 with SMTP id u17-20020a05622a199100b003d5500a4808mr1335796qtc.37.1678868223056; Wed, 15 Mar 2023 01:17:03 -0700 (PDT) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id f2-20020ac86ec2000000b003a81eef14efsm3296268qtv.45.2023.03.15.01.17.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 01:17:02 -0700 (PDT) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-5416b0ab0ecso223862507b3.6; Wed, 15 Mar 2023 01:17:02 -0700 (PDT) X-Received: by 2002:a81:ae5e:0:b0:541:a17f:c779 with SMTP id g30-20020a81ae5e000000b00541a17fc779mr6894792ywk.4.1678868221967; Wed, 15 Mar 2023 01:17:01 -0700 (PDT) MIME-Version: 1.0 References: <20230314121216.413434-1-schnelle@linux.ibm.com> <20230314121216.413434-36-schnelle@linux.ibm.com> In-Reply-To: <20230314121216.413434-36-schnelle@linux.ibm.com> From: Geert Uytterhoeven Date: Wed, 15 Mar 2023 09:16:50 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 35/38] video: handle HAS_IOPORT dependencies To: Niklas Schnelle Cc: Arnd Bergmann , Greg Kroah-Hartman , Helge Deller , Bjorn Helgaas , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Niklas, On Tue, Mar 14, 2023 at 1:13 PM Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them and guard inline code in headers. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle Thanks for your patch! > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -1284,7 +1285,7 @@ config FB_ATY128_BACKLIGHT > > config FB_ATY > tristate "ATI Mach64 display support" if PCI || ATARI > - depends on FB && !SPARC32 > + depends on FB && HAS_IOPORT && !SPARC32 On Atari, this works without ATARI_ROM_ISA, hence it must not depend on HAS_IOPORT. The only call to inb() is inside a section protected by #ifdef CONFIG_PCI. So: depends on FB && !SPARC32 depends on ATARI || HAS_IOPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds