From:   Javier Carrasco <javier.carrasco@wolfvision.net>
To:     linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Javier Carrasco <javier.carrasco@wolfvision.net>
Subject: [PATCH 2/2] rtc: pcf8523: remove unnecessary OR operation
Date:   Wed, 15 Mar 2023 09:20:21 +0100
Message-Id: <20230315082021.2104452-3-javier.carrasco@wolfvision.net>
In-Reply-To: <20230315082021.2104452-1-javier.carrasco@wolfvision.net>
References: <20230315082021.2104452-1-javier.carrasco@wolfvision.net>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pzTqILLBwMqdtpUXBvWSJYOZ/pMH5FG7PMWixWO0LQp67oF1mGYTmsbkYuFs?=
 =?us-ascii?Q?PKJ6+chbBj/f9siN7b3BdDYgdWCu9l4PSVXm6eNECmOWonLVRkrly1PJVnCJ?=
 =?us-ascii?Q?0LGs0q8YJzKqgJI2gUN8D6vW3BdeNSNVBEI5OPfzD6AVt502o6L8DL80DZg1?=
 =?us-ascii?Q?dqyGvXpmYaYxxRHI9meuYp9hdPJkV/hJXyQsTsggsnqa2QO9OKmnRF+ptMtv?=
 =?us-ascii?Q?wmHOZTH1X2oBo5E72AvWysMF8dkgfHGlVfAJ55scyqII1/odJCsQbhljbOx6?=
 =?us-ascii?Q?Ft0mnbo2dCSH1xXwYEoiz1hd3dgs+yG2v2y9WRuqedOBUE2ewTIvEa4F5GOo?=
 =?us-ascii?Q?RAMbfVkBoAkkxePIx0QtCS9Cc7TkWBJk82WiOo5Kk9kdQK36m9otTIqPOQSE?=
 =?us-ascii?Q?kWkI/ZDzUK5OEsJyAgKZCvdwm2C7HP0iE4i4DSzlmecGzTmjlezwqQNgUiyS?=
 =?us-ascii?Q?kuKgzKWQJfSZ8H6RfoujchJgCkGZgOHUWsMkVdBSmcC+M0C2v4W1150hiFkl?=
 =?us-ascii?Q?JyJbPY1eyxX4rPltORTjVkcPfQWBV3gY6KTfLSJDKyDSR5PkgrvYb0Hgbrlx?=
 =?us-ascii?Q?9sfj2as6R/Nt3DEepGqgpeMBXjw2Y/Y7TEX86skJ2ddwgv+YkUntEjiC6fFU?=
 =?us-ascii?Q?o25ebP5QM2jHmQBBjZlCtG8GneO/exeuRZFuftNG1QEsnys4S5KUyUlr8BsQ?=
 =?us-ascii?Q?+Fh2yTW2tHwAPQ45juAHM02Yq4JjQcl/BResLmZ3Zik7IA/bCINL0frw5PSk?=
 =?us-ascii?Q?a3YTxlVE2FVwDf9uOXogKr2Rn/YOHt5Z1AwVR1m9BMQDlbp4tbZmpq421Tam?=
 =?us-ascii?Q?sH8RzV+hO2Z/aqP1DsMujpC3OoPaGt8artcotIRdtqvNAyh9jiQe3u7TDz9W?=
 =?us-ascii?Q?u0dmJK1Dw1Moy9DvgVH+IatcNusHfs/Ohh4N313Z1qNmz0J5yquDq/I+RB/C?=
 =?us-ascii?Q?IXpxidv/QdsZCcSh+viR3XNen285i7esKyd9rZXwRcRc9g70BULXYYGbuKIF?=
 =?us-ascii?Q?82U/K+J8JQWbedeDztoJbk1X/dR9NdJiHzCelfLyk/IqP6K2duV73e/pna74?=
 =?us-ascii?Q?OgJuWLpISn1puAyThfRmhKSUQ+1cRXjzXhZUw7cP4cQb11hz2zn6mgiUHjXD?=
 =?us-ascii?Q?trB9NR5KNDCPBbMKlzN6GMXndknHbrUbwtwqR7ax5M9E6MyAloZzB3Jw0Ex4?=
 =?us-ascii?Q?AocMQL3U/fcKzW0XROEyN0dRWipTgMz/3U1KaqNbKliPEaHxIObJc8EAyo/t?=
 =?us-ascii?Q?h9mhv3+57F8wZCBGrjdlFnbwPHyuNUJoLRgKpaPtTG5eB9ok8RprY7n+Xd4j?=
 =?us-ascii?Q?riHVGhhRmc+mMy969ryTVvH/lwBLoHV4jxPR0fxXUgpu2QsDaXS1xu0uT+Uw?=
 =?us-ascii?Q?mAbddP5KKgd72YjYLt9ly/399HzIQGSI44U7BeTLOhU2SjxFruQp2kMuNuRA?=
 =?us-ascii?Q?YjP3vgUULkC8CF/Ar2ErVKNxUNRMzE/fTZ+C6NKprSit6FIp1Fs+TlsvSwVg?=
 =?us-ascii?Q?1s0X6KtLyABST69ghmXCSi1Tj/OHqdsdVnsL9jyYbAvzRLbl1qDZ8N27ArRm?=
 =?us-ascii?Q?tf21uBKFnOUFTej1DT9xSgjjiRF/9hmjLZMmD57dI4W5MuDmyv2RX8WpjRZS?=
 =?us-ascii?Q?MQzB9DZ0hdus8KDKCG7wfhA=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 9eebb214-4d50-4673-0d38-08db252e3bba
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 08:21:10.7422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xw97F8B8O5jIYMl05hOYD6lfxPLgXGoJzG3F8BXEgreV5UTabSeBY0B5urDBFGTsFM5ZoAmcU5g1vBWXQ/qZ5vOrOBYs9IV2GbkiRCDfauk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8779
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The value variable is initialized to 0 and it is not used to set any
other bits rather than the one that defines the capacitor value. Setting
this capacitor value is the only purpose of the function where the
variable is defined and therefore the OR operation does not apply as a
way to foresee functionality extensions either.

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
 drivers/rtc/rtc-pcf8523.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c
index ccb5aa690433..e7115ebef707 100644
--- a/drivers/rtc/rtc-pcf8523.c
+++ b/drivers/rtc/rtc-pcf8523.c
@@ -65,7 +65,7 @@ static int pcf8523_load_capacitance(struct pcf8523 *pcf8523, struct device_node
 			 load);
 		fallthrough;
 	case 12500:
-		value |= PCF8523_CONTROL1_CAP_SEL;
+		value = PCF8523_CONTROL1_CAP_SEL;
 		break;
 	case 7000:
 		break;
-- 
2.37.2