Message-ID: <4f536461-ee2c-73a0-9d28-668a99f8a027@gmail.com>
Date:   Wed, 15 Mar 2023 17:33:40 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [RESEND PATCH] perf tools: Add levenshtein ENOMEM check
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Cc:     Josh Poimboeuf <jpoimboe@redhat.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230315061132.25165-1-p4ranlee@gmail.com>
From:   Paran Lee <p4ranlee@gmail.com>
In-Reply-To: <20230315061132.25165-1-p4ranlee@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


23. 3. 15. 15:11에 Paran Lee 이(가) 쓴 글:
> The levenshtein algorithm requires exception handling
> when making dynamic allocations strings.

Sorry about that. I modified the code to make it behave incorrectly.

>  	int len1 = strlen(string1), len2 = strlen(string2);
> -	int *row0 = malloc(sizeof(int) * (len2 + 1));
> -	int *row1 = malloc(sizeof(int) * (len2 + 1));
> -	int *row2 = malloc(sizeof(int) * (len2 + 1));
> +	int *rows, *row0, *row1, *row2;
>  	int i, j;
>  
> +	rows = malloc(3 * sizeof(int) * (len2 + 1));
> +	if(!rows)
> +		return -ENOMEM;
> +
> +	row0 = &rows[0];
> +	row1 = &rows[1];
> +	row2 = &rows[2];
> +
>  	for (j = 0; j <= len2; j++)
>  		row1[j] = j * a;
>  	for (i = 0; i < len1; i++) {
> @@ -79,9 +85,7 @@ int levenshtein(const char *string1, const char *string2,
>  	}
>  
>  	i = row1[len2];
> -	free(row0);
> -	free(row1);
> -	free(row2);
> +	free(rows);
>  
>  	return i;
>  }

I'll think about it a bit more and figure out how to patch it up to make
it look better.

BR
Paran Lee