From:   Michael Riesch <michael.riesch@wolfvision.net>
To:     dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Sandy Huang <hjc@rock-chips.com>,
        =?UTF-8?q?Heiko=20St=C3=BCbner?= <heiko@sntech.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        kernel test robot <lkp@intel.com>,
        Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH] drm/rockchip: vop2: fix initialization of possible_crtcs variable
Date:   Wed, 15 Mar 2023 10:01:58 +0100
Message-Id: <20230315090158.2442771-1-michael.riesch@wolfvision.net>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AKCAsoQFGNOTDDBTlEIXXTcCq6TIFi0qVkeR1kEuHuWN0v41SR3KNa01w3Kl?=
 =?us-ascii?Q?b+vP/UmTI9fH5vKy6OxvvtX+wneq0+AkvigFS1DhPYjwcGUVhkAL12Jj6yEV?=
 =?us-ascii?Q?iNhr93NxHcAkjhWa43cLN3VdCnJNMtt17fFPFm4dZBlUqKuy4GGfH2JfI8l8?=
 =?us-ascii?Q?Mh501322vUY8wqGI53dMnJW+p0I4Rnu3OjCXrZ5CbrrZIOXuZw0kldo9qwQb?=
 =?us-ascii?Q?ECOmPDfmST7vhv0Boxx/yaHMOULGr/XOKd73lct9BroplsIAVO7xiPzEQkL4?=
 =?us-ascii?Q?5H9zVGH1B/0Ej+kQNspOIKQMXflBNSUiGlN6H9f9rrac4ZsrCRq7xYe8LFHD?=
 =?us-ascii?Q?Iaggfbp/OkkWY1JLgzOwvd/KV1Sksw9EdlB8DSvdvzq0xKRb0myH8WmAMH20?=
 =?us-ascii?Q?S+s48DjZDbPRrObWKaWQpfLK3Kz5wDVfY2z7WSqiFLXdCOOfK+cFboMy1F9r?=
 =?us-ascii?Q?omrPBi6wjXPr5LhCkmt3iLfo3oPJ5zhDN0hJzK4KT3LHr6UlEre6L/0V5Fpw?=
 =?us-ascii?Q?WuL1BHEpBzLA6s/UoLhsNJrFVVHikIX0aEoOU3h6MZ74ftf3d8gMpd9P7WZr?=
 =?us-ascii?Q?kwONplJzATzPVstSN6+Z3mucRFNzZpBznZjJACrHwKTnQ5fmHnTNHa2SB3hU?=
 =?us-ascii?Q?gT46k7cdlKDKfPy2FQHYdD5MPIcEkeWEV08J5ltN4PaDRflXYm8iKN0fr/Fi?=
 =?us-ascii?Q?VANi72D3pLFlhiVpkRNK644unaFWt7rQIJYMRaUZmegM32uAZq1LoKa3vmjb?=
 =?us-ascii?Q?Tnuta5FB1EtCBUzt0V6JtoDY1w9GSgEdIOgEP5XTNbmOZTQe0kaHkWLqpKrF?=
 =?us-ascii?Q?2OGhPq0IvOVZ27i4795UvexqYAIEjRS3Ghy6X7Dx6UY2I2R5oKOmC9AmW5kX?=
 =?us-ascii?Q?9ms/VkUy03pKEQK08xb8X3e+eD4A4HnxD3vh+b8YH6k8eUGk2bleLBkqwWfq?=
 =?us-ascii?Q?aIh6WqgWyMBzNB/+YnDPNsJ0dZEqGiEoKC22+7e2Ng0hL1YQZCigBXuToHrs?=
 =?us-ascii?Q?oFadQsiOQYkovfO7Vxy8qHF02edHJXOtANGwAStEh9hRo2aCOrGgoM9vYeAS?=
 =?us-ascii?Q?ChvPYDdjxQxjyvD4LjsbLGjLGLeNUdZqnD6tuE5ubLWvgdh9oN7XSugf/VmC?=
 =?us-ascii?Q?bKUoYeZkdX2qedB+droAVxm9yikOWgVxfTyMQIjJ47Clqkj2vUXgEQEc5uuR?=
 =?us-ascii?Q?c2agDn4C4K22BBNcwa/l7kxECrFzeTg6drflnJt/H6NYvBdThCmPA8kXYrAx?=
 =?us-ascii?Q?pjWf/sBLidK1g8FhZQTEj7fDEisQQ2OmgaPngQgJNrZkf+5qYeL+ir4q/Byr?=
 =?us-ascii?Q?X65DyFRkYJgV/1/yWiiDQusUhijTwrwH5Cclwx+fhiMPZlLMPIOWiXeZMLuo?=
 =?us-ascii?Q?gqxYAqc3tzvgyCdeRKUma3KDbBPUJ9AWGClZfxNDbI9rT8ttRuHB91vEKMQp?=
 =?us-ascii?Q?yc23PYbMbSzGsJtwgIiP8u2mLfBw3tmd8FNLzBfO1u0/dm7pMxx2oC2ykXLG?=
 =?us-ascii?Q?6Yjec5tJCAQda831WCahy2+HjozxYbP81MFH7KEybWO+wMLri8SX0eYb0E+e?=
 =?us-ascii?Q?DFczF3rorMYMBKxrE4UFQtDq6C+grgQvgcFl1mdm8W3pfl478FoFEAfPU7Xr?=
 =?us-ascii?Q?WkFK6eHIuce0aIEo3L6ZI/4=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a311ea6-62cb-400f-a0c7-08db25340c09
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 09:02:47.4479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pNzcpwfRjHFFaFHvv3iabw2N1BoyZvoDyKRZFdg/knyLY2yDBkRgPeI5xgt0S55v+yvX8iGXm3VX2Paoo8aBYa76MR/XDA/ImS2g9hHpEuQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9932
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The variable possible_crtcs is not initialized properly since commit
604be85547ce ("drm/rockchip: Add VOP2 driver"). A first attempt to fix this
issue has been made in commit 368419a2d429 ("drm/rockchip: vop2: initialize
possible_crtcs properly") but turned out to be incomplete. Initialize the
variable with zero to cover all possible paths.

Fixes: 368419a2d429 ("drm/rockchip: vop2: initialize possible_crtcs properly")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 1667e5324b29..0569f1211d9b 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -2301,7 +2301,7 @@ static int vop2_create_crtcs(struct vop2 *vop2)
 	nvp = 0;
 	for (i = 0; i < vop2->registered_num_wins; i++) {
 		struct vop2_win *win = &vop2->win[i];
-		u32 possible_crtcs;
+		u32 possible_crtcs = 0;
 
 		if (vop2->data->soc_id == 3566) {
 			/*
@@ -2329,8 +2329,6 @@ static int vop2_create_crtcs(struct vop2 *vop2)
 			}
 		} else if (win->type == DRM_PLANE_TYPE_OVERLAY) {
 			possible_crtcs = (1 << nvps) - 1;
-		} else {
-			possible_crtcs = 0;
 		}
 
 		ret = vop2_plane_init(vop2, win, possible_crtcs);
-- 
2.30.2