From:   <VaibhaavRam.TL@microchip.com>
To:     <gregkh@linuxfoundation.org>
CC:     <arnd@arndb.de>, <Kumaravel.Thiagarajan@microchip.com>,
        <linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
        <Tharunkumar.Pasumarthi@microchip.com>
Subject: RE: [PATCH v7 char-misc-next] misc: microchip: pci1xxxx: Add
 OTP/EEPROM driver for the pci1xxxx switch
Thread-Topic: [PATCH v7 char-misc-next] misc: microchip: pci1xxxx: Add
 OTP/EEPROM driver for the pci1xxxx switch
Thread-Index: AQHZTfJPZe6eTNovTEKQ1bRHyBB32q7yT44AgAZ9oqCAACVkgIABebMg
Date:   Wed, 15 Mar 2023 09:07:12 +0000
Message-ID: <DM4PR11MB6238653CE39A429E4B10B9C497BF9@DM4PR11MB6238.namprd11.prod.outlook.com>
References: <20230303170426.353-1-vaibhaavram.tl@microchip.com>
 <ZAm7PDSIUN5HMxUu@kroah.com>
 <DM4PR11MB62385D0541F7AF8EC7E9F6CE97B99@DM4PR11MB6238.namprd11.prod.outlook.com>
 <ZA9Me2d9IsoYGifp@kroah.com>
In-Reply-To: <ZA9Me2d9IsoYGifp@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1m1H45mszHRNuKmB9PP6qGRdRwc0rBwKJzyzAXRmUNaRLCIBC6xiXaWUBSX2?=
 =?us-ascii?Q?Dlqjhd3z4cL/6qRELqXRKn/67CK80RDNzNQNfoh0qwGur3ny6k7eWpHBGpZ9?=
 =?us-ascii?Q?31lVy5nzbeUxqQ7OJcDRIk/i5vHpY7V9M5PmvZ+aZcxRWRa+Ydq0esT0e5z8?=
 =?us-ascii?Q?GNy85BWcy0bbY4dcnKSnDPa/5MtzYasczx8sFReb+JDof8y2tB4NrUrbszrs?=
 =?us-ascii?Q?UZpm6IUKEBFHxrGZ0/TJEGP6F4WxLURq/iUj1DmORfDnn/vZc2WNO5oJQcuc?=
 =?us-ascii?Q?Ev3dvN5oetUhAooHQ7wutnXQf5CMadJ4DSZL+7ShPk+rC7rUtaf2jmbT453f?=
 =?us-ascii?Q?eBF/r/cH4nyMTLGuHPB5JSpElybJXoOcT3F2V+mvn9FtEnno32HdaisAp429?=
 =?us-ascii?Q?ITp7kv9gwjeN+NmRVm6MH7n1v0oGa8KaFVDOjcJW4CNmW1sr1ViML08V08Ma?=
 =?us-ascii?Q?dZIaG18IbYSV+sB6uebIP6ryKDUxw9qw9wN1+WxK87+yFbmDQYlNdAcjg5RF?=
 =?us-ascii?Q?e/fcaSL2BlIN2JhxvqBTztQbcFfuYwhZyc1jUFNqQoganvBg5UVGvZUTlrPu?=
 =?us-ascii?Q?Oz6dzfxYnMoe7mIdwdk2QV4vOmJgIk308cv2PVIA67JOszlxVhBJJjfWIhET?=
 =?us-ascii?Q?fNvY8ej0xo6L72/rDP78AGWBHRZkmxEo0oqxom8isksDiyaIAoZfYVrMSB+C?=
 =?us-ascii?Q?9UzTguyWoBkbR9mxDq5e3/LtYoyCFy4FbKbEd3nGQrCRcekS2S81/Lri22Hk?=
 =?us-ascii?Q?YM+NH3cs+Xz1WbYLAgbNo/SImqnU+OBNL90PWQU/Ps83S7/pYxOVA4THQ3Wl?=
 =?us-ascii?Q?k+fzRVRe8ccNPU+SSjTCgpF7mRc34AiEh5Wh0PXukhYLciaonw3odiIdrHsZ?=
 =?us-ascii?Q?G70KhGJzauHvbPEjdBJdiTl7js/Ag6kt7shVdSW2wT6vNU9UQU6PpwUDKjOH?=
 =?us-ascii?Q?r+eQD0xQKiZAxWzx9JNawYs1lcE8Uqma19GpK2dH4lvrp1gu5ANm4uyf0cTO?=
 =?us-ascii?Q?bOfIW1DqZ68m+6fsIdDPYbPHT454bo3Cqv/CcXpAG6r/Xh/YAbnuwbAtgHKV?=
 =?us-ascii?Q?3+TDEhd2rh0HUMXJ5p/Rr2ReK/wfFpAttLcYbPBudOEiO4hobOHxPQYm4yC7?=
 =?us-ascii?Q?3i5RTvsVxRUb2+lqdnMTlFMxkYeNW1AygoKv52/cTp03GfBTQfOYFdelDDC8?=
 =?us-ascii?Q?J6AA+zjYSpG2C4KNBP+hIfAw0VWII7LdBYAJQuGpQyCsuH3sSu4vo6YolJiw?=
 =?us-ascii?Q?pvkKO+qB9H2EA5ibPuasjb1c8SbkWIJv8neCV/q+ayVQd9rT/TY4ij2hURr+?=
 =?us-ascii?Q?13UbX6Gud2TAjKtbToDC6tvzkv2HIBjMmA/WSvfFLERJIxnmZrFU/gJmSl2k?=
 =?us-ascii?Q?/U80L72SMloNO/sBps3k8F3MWsQi1ucQfQ6qfCboKKufCdnz/ajxnVPWAJrP?=
 =?us-ascii?Q?Wt2AKyXmH4+s33Yu31FsIhyzMZ8lLPT3fqUdjJ/h5vlS/Sg3haSi3P2zK4l7?=
 =?us-ascii?Q?cHWjonAqonHAIIiwm8QtXqQvNxOdMB2aH1chlvIcFMIkR4WVwykZRYOVSe/6?=
 =?us-ascii?Q?GIw6FZSJ/oi2GHoLvmUxQBLYT9RFuGBx759lY6M1EDOyzH+3yIWdQVgGMVO8?=
 =?us-ascii?Q?cw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6238.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1de035a9-fdfe-45c3-311e-08db2534aa0b
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 09:07:12.4131
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rdG68rp0nYnJJuopB6ieLk2zz4VatQZ5gWl7SQRIJR9djr/i2dj97hD6kArn/CePeeEg61LEgzH+NpJaJrN1Ahn1X3rHW1Vz5usGt9Xe2dw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5568
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


From: Greg KH <gregkh@linuxfoundation.org>=20
Sent: Monday, March 13, 2023 9:47 PM
To: VaibhaavRam TL - I69105 <VaibhaavRam.TL@microchip.com>
Subject: Re: [PATCH v7 char-misc-next] misc: microchip: pci1xxxx: Add OTP/E=
EPROM driver for the pci1xxxx switch


On Mon, Mar 13, 2023 at 04:01:15PM +0000, VaibhaavRam.TL@microchip.com wrot=
e:
> > > Again, default group will handle this automatically, you should=20
> > > never need to call a sysfs_*() call from a driver.  Otherwise somethi=
ng is usually very wrong.
> >
> > Are you recommending similar to this snippet?
> >
> > static struct bin_attribute *pci1xxxx_bin_attributes[] =3D {
> >       &pci1xxxx_otp_attr,
> >       &pci1xxxx_eeprom_attr
> >       NULL,
> > };
> >
> > static const struct attribute_group pci1xxxx_bin_attributes_group =3D {
> >       .bin_attrs =3D pci1xxxx_bin_attributes, }; ..
> > ..
> > auxiliary_device.device.attribute_group =3D=20
> > pci1xxxx_bin_attributes_group
>
> Yes.
>
> > This creates sysfs for both EEPROM and OTP at once and handles for its =
removal, right?
> > But, In this case, I have to check whether EEPROM is responsive and onl=
y then create sysfs for it.
> >
> > Can you please provide some guidance, on how to handle this situation w=
ithout using sysfs_*().
>
> Use the "is_visible" callback in your group to tell the driver core if th=
e specific attribute needs to be created or not.

I have added "is_bin_visible" callback and it is working fine. Sysfs for EE=
PROM and OTP is created inside drivers folder

But I have used attribute group inside device_driver under auxiliary_driver=
 structure.
as opposed to what I have mentioned previously because , struct device_driv=
er is exposed to me instead of struct device.
Since there can be only one instance of driver for multiple devices, I cann=
ot account for multiple instances of EEPROM/OTPs present in those devices.

Is it possible to use sysfs_create_group in this situation?

Thanks
Vaibhaav Ram