Date:   Wed, 15 Mar 2023 16:44:14 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH v2 19/27] KVM: x86/mmu: Move KVM-only page-track
 declarations to internal header
Message-ID: <ZBGFXrpSXpF5NUlV@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230311002258.852397-1-seanjc@google.com>
 <20230311002258.852397-20-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230311002258.852397-20-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MTSQBuwd8bv/nIUeertNd9laLRWlw5gjlYx4ipbcPasN9h5YK8GGAXuSoN1F?=
 =?us-ascii?Q?LqNn69B7xeYENGEKMaRaRqtri7jkOLZebvNgNA2FZ1zz4PCdYUcbHmIUB1jh?=
 =?us-ascii?Q?GvyGghVrtg6sJWSM7gd7Bqmj8II0wAHW4eC/kl32tUqynSEPBAX2+FR+aZIg?=
 =?us-ascii?Q?GkYKRSjz0dp7NEBBFyagnGWJSw9NvYdA7aF94MAvqZ8dBIDFeP++RSPczsms?=
 =?us-ascii?Q?IY1eQS8vVn7/Ab9VFxj612s+FTGeKSKAlwqI2Uo5IFv1eVj8R5BfNE8h0MWq?=
 =?us-ascii?Q?yjZfFBpA2LuT81Dq3Glm++uf56M4iV8dfIdHB3sop7icSd2EMwwoOdZM1lcN?=
 =?us-ascii?Q?L5YzR8JXiMQZ0iaNKB2llc3sSgeImcKZ8N8ks0aKJTRxNM+rVksSIACLJoAG?=
 =?us-ascii?Q?mrHQtqfcm1eatTRHU8wByz64I1DtLaKkTBpsF+YiUCDkrl0Do8jg9Xaa3WQE?=
 =?us-ascii?Q?xdGvnvS5z5WTE2/r2uMh0frqVIP0jypAtDros2xoC4L8uH6AFhCg3N0ZNngd?=
 =?us-ascii?Q?IyyRzX7SpmU06KFR6Z+IrsC1ACh7re/eUlXuxev0FwWjxcr5Ze5GPlnwwjNU?=
 =?us-ascii?Q?eA2rwuLy47JgDGWg4eBkQEngJXYaUVzM28Bz/dlG7+hZEbETRj4ry6RyhZOm?=
 =?us-ascii?Q?/N/4CgclnKaQdO9CPE+pT6EIm+T3PcNltrve7BvH4XxCC3ERtvny21hiYF4H?=
 =?us-ascii?Q?yxaCtz+mZDMl0CDASynrvvDV1fEOMW83Zbxrb4w4uYOOGIAKFTAf8srfBHWZ?=
 =?us-ascii?Q?uvQfssQFQyBwVDMbEzF5+Vpj4eM+EGrezkkXGFZ7bKIHYBnDnhlBqJKnB/i5?=
 =?us-ascii?Q?8HktnRYcF0KjwSzL8NNYjHqZ3XBh9JiNMOeq/JetDEW2L+7uce1CEwMKblZJ?=
 =?us-ascii?Q?VkWuLnHhwLJDXrXWBxUlR60+5VnrBocTLxw35pvAbmB5XkuBKZtk042K1NBl?=
 =?us-ascii?Q?jKyMhDk5fwIrQAzcW/eTZP76gJd62W+db5hNtyAZdMNDqkULQIiXVLN6wUMs?=
 =?us-ascii?Q?m3a9LxNNoF5Q9glffIbW8u4Vj/ytulg3qOI6n9/KtBZ5mQv1JEn+NDmMnGJj?=
 =?us-ascii?Q?GZbBuIW/yd4ynC0LeCHvdMl3ugbhifVTVqRelvGEEBw8mwcgY7+3XgMd4K+7?=
 =?us-ascii?Q?KtH/l5/mmvwb/VdzBPdYyxXnCv42tzJ7Zwczm/Fx05R9nxVjWOI3M3P102zk?=
 =?us-ascii?Q?oanESQvMccVkte6J2/aUmHE5MCNgu05I0BoZHSMJ8KpIWNdeSfSJnG/8Bnz3?=
 =?us-ascii?Q?8CJy6SFs6yADLQUf2cVHexf61gcN1Hc2WkMq+lJtE6tLoZlJEHz1xNeKdFGH?=
 =?us-ascii?Q?AMrj4F+LwYTV6ZN+FtHcZWsSSncjizxBKCfMoFhlU8oHincBsAfxYH2aEyFN?=
 =?us-ascii?Q?HP+e+7dpiXd99VrbQU+9p9evVufbWqBMX9iKmtdl1JHD3DINHUqUYNLqoI/R?=
 =?us-ascii?Q?KgqJZGfMBGGeMO7VPnql5HRg/2YjFW35RP9hk0jPjmgRPtZlbDJeVdy4Zu+6?=
 =?us-ascii?Q?m/g5Mg6AgKf+lyUM9/da3kO0xqLf2x3LM1BD7JGY5/nx5TxZ4B72q8t0CLAo?=
 =?us-ascii?Q?hP1saeGnTKH7VozCRSVmQNw3U3LoL20wlg0rs2Qo+TFcSg9s4bloWH+aSEcW?=
 =?us-ascii?Q?Hw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d842227-b818-4440-13e9-08db2534e48b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 09:08:50.7466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BYthy5EuaIlbvpMMr0A9GP96MOXodWivWR3EiiI7jHYqH14259jiYUAUgBDP51ziQSlEl/1l/mvgnqho0U1aIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7649
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 10, 2023 at 04:22:50PM -0800, Sean Christopherson wrote:
> Bury the declaration of the page-track helpers that are intended only for
> internal KVM use in a "private" header.  In addition to guarding against
> unwanted usage of the internal-only helpers, dropping their definitions
> avoids exposing other structures that should be KVM-internal, e.g. for
> memslots.  This is a baby step toward making kvm_host.h a KVM-internal
> header in the very distant future.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  arch/x86/include/asm/kvm_page_track.h | 26 ++++-----------------
>  arch/x86/kvm/mmu/mmu.c                |  3 ++-
>  arch/x86/kvm/mmu/page_track.c         |  8 +------
>  arch/x86/kvm/mmu/page_track.h         | 33 +++++++++++++++++++++++++++
>  arch/x86/kvm/x86.c                    |  1 +
>  5 files changed, 42 insertions(+), 29 deletions(-)
>  create mode 100644 arch/x86/kvm/mmu/page_track.h
> 
> diff --git a/arch/x86/include/asm/kvm_page_track.h b/arch/x86/include/asm/kvm_page_track.h
> index e5eb98ca4fce..deece45936a5 100644
> --- a/arch/x86/include/asm/kvm_page_track.h
> +++ b/arch/x86/include/asm/kvm_page_track.h

A curious question:
are arch/x86/include/asm/kvm_*.h all expected to be external accessible?

Thanks
Yan