IronPort-SDR: rHAfbj9EpA/wx9hFCU9lI1yBrgCCSQZCSVG+S2jXiB61idKPMklY62C5BFc9zDo+F9vJwNWBbb
 WLkODDaNqUkP+T/fqZPdIAwKVezVXpwAmy+mBTQEv+HlWlvAR6jgmp9RtljXpu9WxnQnQRiKxI
 i6MQg2Yw9qoAHzvDvAl8NZARVYGirLPRO3w3D6vJw5S434cl14kOKoUE8sAnm8mJCFk2OMwtph
 YVlOrDjvLfybiY4ecopPpHNCnr/TuLqby9XrMLMvoZKzQQ/RRyEzzlcBF3Z2Nd2cWPTcbFPQ/E
 aVI=
IronPort-SDR: GxqejzvbAnp62rGtsElnpxhlQNVSedvUfko9wV0awmJBknNRcChdxxkYaLeq13bKyQSgLJ09no
 yfpPQZG+LxYzMfWPPgmaKqcZqQ0DWyDrCS4y/Ug9O7SECLNcI0iWQUanGM/P8fJ6AKPMR9GqrE
 Eo50l7k75ebFcHfActa3WsfTtl0XAswPfKyzffqCisndHR8XcUsfiXoJgNK00idoPU60tTttU0
 Odchozg5noTENrA196wbMmsxMJpLedWbtSicnu8IG/kBaZO8dRYO1Fq1wxd8zAhuOlOHgXXWpf
 a5E=
WDCIronportException: Internal
Message-ID: <c7315ca2-3ebf-7f3b-da64-9a74a995b0ae@opensource.wdc.com>
Date:   Wed, 15 Mar 2023 18:12:48 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v3 02/38] ata: add HAS_IOPORT dependencies
Content-Language: en-US
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-pci@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
        linux-ide@vger.kernel.org
References: <20230314121216.413434-1-schnelle@linux.ibm.com>
 <20230314121216.413434-3-schnelle@linux.ibm.com>
 <CAMuHMdVry2YViJ5oFgo9i+uStWbhy7mXKWdWvCX=qgAu1-_Y1w@mail.gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <CAMuHMdVry2YViJ5oFgo9i+uStWbhy7mXKWdWvCX=qgAu1-_Y1w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 3/15/23 17:39, Geert Uytterhoeven wrote:
> Hi Niklas,
>=20
> On Tue, Mar 14, 2023 at 1:12=E2=80=AFPM Niklas Schnelle <schnelle@linux=
.ibm.com> wrote:
>> In a future patch HAS_IOPORT=3Dn will result in inb()/outb() and frien=
ds
>> not being declared. We thus need to add HAS_IOPORT as dependency for
>> those drivers using them.
>>
>> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
>> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
>=20
> Thanks for your patch!
>=20
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -342,6 +342,7 @@ endif # HAS_DMA
>>
>>  config ATA_SFF
>>         bool "ATA SFF support (for legacy IDE and PATA)"
>> +       depends on HAS_IOPORT
>>         default y
>>         help
>>           This option adds support for ATA controllers with SFF
>=20
> ATA_SFF is a dependency for lots of (S)ATA drivers.
> (at least) The following don't use I/O port access:
>=20
>     CONFIG_SATA_RCAR (arm/arm64)
>     CONFIG_PATA_FALCON (m68k/atari and m68k/q40)
>     CONFIG_PATA_GAYLE (m68k/amiga)
>     CONFIG_PATA_BUDDHA (m68k/amiga)
>=20
> (at least) The following can use either MMIO or I/O port accesses:
>=20
>     CONFIG_PATA_PLATFORM (m68k/mac)

But for these arch/platforms, would there be any reason to not have HAS_I=
OPORT ?
It is supported right now, so we should have HAS_IOPORT for them.

>=20
> Gr{oetje,eeting}s,
>=20
>                         Geert
>=20

--=20
Damien Le Moal
Western Digital Research