Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F23CC61DA4 for ; Wed, 15 Mar 2023 09:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232184AbjCOJsv (ORCPT ); Wed, 15 Mar 2023 05:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232139AbjCOJsM (ORCPT ); Wed, 15 Mar 2023 05:48:12 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A76836703B; Wed, 15 Mar 2023 02:47:11 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id D2BC392009C; Wed, 15 Mar 2023 10:47:04 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id CAFB692009B; Wed, 15 Mar 2023 09:47:04 +0000 (GMT) Date: Wed, 15 Mar 2023 09:47:04 +0000 (GMT) From: "Maciej W. Rozycki" To: Niklas Schnelle cc: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michael Grzeschik , Wolfgang Grandegger , Marc Kleine-Budde , Jesse Brandeburg , Tony Nguyen , Ralf Baechle , Greg Kroah-Hartman , Bjorn Helgaas , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , netdev@vger.kernel.org, linux-can@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-hams@vger.kernel.org Subject: Re: [PATCH v3 20/38] net: handle HAS_IOPORT dependencies In-Reply-To: <20230314121216.413434-21-schnelle@linux.ibm.com> Message-ID: References: <20230314121216.413434-1-schnelle@linux.ibm.com> <20230314121216.413434-21-schnelle@linux.ibm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Mar 2023, Niklas Schnelle wrote: > those drivers requiring them. For the DEFXX driver there use of I/O > ports is optional and we only need to fence those paths.can It also Some writing mess-up here, should it read: "For the DEFXX driver the use of I/O ports is optional and we only need to fence those paths. It also [...]" ? > diff --git a/drivers/net/fddi/Kconfig b/drivers/net/fddi/Kconfig > index 846bf41c2717..fa3f1e0fe143 100644 > --- a/drivers/net/fddi/Kconfig > +++ b/drivers/net/fddi/Kconfig > @@ -29,7 +29,7 @@ config DEFZA > > config DEFXX > tristate "Digital DEFTA/DEFEA/DEFPA adapter support" > - depends on FDDI && (PCI || EISA || TC) > + depends on FDDI && (PCI || EISA || TC) && HAS_IOPORT This part would incorrectly disable the driver for !HAS_IOPORT and is not needed given the change below: > diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c > index 1fef8a9b1a0f..5f386eba9618 100644 > --- a/drivers/net/fddi/defxx.c > +++ b/drivers/net/fddi/defxx.c > @@ -254,7 +254,7 @@ static const char version[] = > #define DFX_BUS_TC(dev) 0 > #endif > > -#if defined(CONFIG_EISA) || defined(CONFIG_PCI) > +#ifdef HAS_IOPORT > #define dfx_use_mmio bp->mmio > #else > #define dfx_use_mmio true is it? Maciej