Date:   Wed, 15 Mar 2023 10:53:36 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Murali Krishna Policharla <murali.policharla@broadcom.com>,
        Lukasz Majewski <lukma@denx.de>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: dsa: don't error out when drivers return
 ETH_DATA_LEN in .port_max_mtu()
Message-ID: <ZBGVoEWp728Kb1tw@corigine.com>
References: <20230314182405.2449898-1-vladimir.oltean@nxp.com>
 <20230314182405.2449898-2-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230314182405.2449898-2-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kRczJ0Bmxei32y/WIbjmy5FrjIpd/tfPMvaQ6K/j+2UZ8frqTpIaknK0KcAi?=
 =?us-ascii?Q?472yT5Dox0uXZyafeg8stam1CXbQGMRl2HiTJB0tvGb8AsERJwUlWqWBZyxy?=
 =?us-ascii?Q?Tg5yeMwh+LQSOJN4Wr9fmFB1gBdMVDvRBofBecApBnATTjNUrerhb2ZikTEE?=
 =?us-ascii?Q?431dYoWH/PoDCQkpXLGAJxnzivnA4Fz/k0kOhUgrJgk6DqYdWclQE+4vR1NS?=
 =?us-ascii?Q?7jvygU1erKVy0XpK7xpAnNH84f1qx/3cZbT2/MBhnu18wchS21Q45aqIwMao?=
 =?us-ascii?Q?Zr+NlGf4sA6d4W9EGeq+acedh9AY67pAcI8Mpeee3nLUz2LXCe/qEhqFPMfl?=
 =?us-ascii?Q?SnTaAw4jcU7QvU97Ybk17t4bEG0p7kXT3lJLklnqLrTKWGezhfC+35YkDFIU?=
 =?us-ascii?Q?eNTKtfbjFR2rWEyVfEHqJVjQh2gqr8AUh5PFH831paO+hR8Vi4zkiL3ai2EY?=
 =?us-ascii?Q?qt6Ml/60iW9A41bsQko7YGMyg/gmuRO6ooehSN/SNGIbOwM7V5AyUV8lgewI?=
 =?us-ascii?Q?OI/jrlfRAEnwWQkw+iduxBfcNVFC7C1ph4Sq5pEYkr6zMm0/VZRE3hPJOuTE?=
 =?us-ascii?Q?BGynigPWacysU5yviunI8CApxUuRD7srxiqxvphr/hZyIZX4iHwUSJ0DLi/Q?=
 =?us-ascii?Q?jBXRHx1gazhQvcbsMdhk5vf46i+pUrkWk/7ufhGtDw3EJmvHVNyfIyZd8yvs?=
 =?us-ascii?Q?PrllPHR4d1DMAjZh5Ump2G/vmzgaxWNoqBvxdc9kMrH9JD02meIEaaS9QO3l?=
 =?us-ascii?Q?Z87cQT8jBbA2EIhSfEVQw/yzODVU/+Czu1wLdsgOsK7Z2VSCG9dOtlqQ/4mD?=
 =?us-ascii?Q?66Qh5Q7I8CfXWQSKzEUkKS1WbcY8JeDMboe1UKEBwC+ECFXpk2yxTUrm+MCr?=
 =?us-ascii?Q?0HFQcCK7YFCxTPAbL8l+Os1jec5REquljLk8sZzpjS+w5PvWPpBCgQrxZeT7?=
 =?us-ascii?Q?LC2nljWyC4HQxB06mPYsKItCiWHUu4SS0kHiloKHlk4PUl8SoIbXEG6Q0bsX?=
 =?us-ascii?Q?1htV94JTAFthP3HHTWDQcqHykt0X3kWXgayLAX7r/oUmEJlxVPODySy9aGHN?=
 =?us-ascii?Q?fnF1JU3eQ1MZaaUbkmXO9lD0aFCZ75+LpO2tm9hGAt60Xsp0XifjEGjOcHuH?=
 =?us-ascii?Q?XFmaROTCrbhb1KkxT/lWSNMQHji7hSTE4zms5j+f/yFJ8UVzuiJDyrQ4VA5Z?=
 =?us-ascii?Q?dsHgWD3zsWYUH+pZxZ/oybsGdWpYS30Omoj2334WnFlT5Wp3FXma5eEekaxQ?=
 =?us-ascii?Q?cdoDRHeoYOrSkZqqzpDVIa0m2uWUIxVVYRBY8woTgbjDKSBfVys/yWL3EasS?=
 =?us-ascii?Q?wTP4VfBUNhBgn6Wvy3v6UPpsMlvk3SfGV+XNEIgbun7p/b/blHE5Y7+4WtR3?=
 =?us-ascii?Q?4OCMr3DTzOSnk5suwQjKCphvqnDngyXT41VPkSvORlNXaPXqyeNluWHFLFZv?=
 =?us-ascii?Q?CtNmIaLgc0cO+g4AYcKtY8hEcDOWQQ7CQ6v51wbRwZfRWnd2IXox8E6z67CB?=
 =?us-ascii?Q?H9Qo0sD2vr1m8OjRNTadq4jBbk7yDk72RZHRsvDVK8pfUguIAN1CvYAdytc4?=
 =?us-ascii?Q?w53LQ6AgzcNbAMtUXXqkFFmmWCeQFHZrULW2MdwDsZU5wB/5zn6WQyLqTKTm?=
 =?us-ascii?Q?va6nLMKntWpnlMF8cYwdrb3rYRNbOIpZxglQBmH6LG569hY+Q3d2Z0GrPyOW?=
 =?us-ascii?Q?35KTmg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c525db8-e5cb-4606-811b-08db253b294e
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 09:53:43.2333
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kIDYPvVtQsflG1gwGJzZqrJbrA4Nr5kBXD+ejXFFBkAlFEfBCXDhxn+em977MqgVY8jhXe3PvG3W1gQrQjObMHZOG29HNNKTFvD60qZtT7Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5239
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 08:24:04PM +0200, Vladimir Oltean wrote:
> Currently, when dsa_slave_change_mtu() is called on a user port where
> dev->max_mtu is 1500 (as returned by ds->ops->port_max_mtu()), the code
> will stumble upon this check:
> 
> 	if (new_master_mtu > mtu_limit)
> 		return -ERANGE;
> 
> because new_master_mtu is adjusted for the tagger overhead but mtu_limit
> is not.
> 
> But it would be good if the logic went through, for example if the DSA
> master really depends on an MTU adjustment to accept DSA-tagged frames.
> 
> To make the code pass through the check, we need to adjust mtu_limit for
> the overhead as well, if the minimum restriction was caused by the DSA
> user port's MTU (dev->max_mtu). A DSA user port MTU and a DSA master MTU
> are always offset by the protocol overhead.
> 
> Currently no drivers return 1500 .port_max_mtu(), but this is only
> temporary and a bug in itself - mv88e6xxx should have done that, but
> since commit b9c587fed61c ("dsa: mv88e6xxx: Include tagger overhead when
> setting MTU for DSA and CPU ports") it no longer does. This is a
> preparation for fixing that.
> 
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>