Date:   Wed, 15 Mar 2023 10:54:29 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Murali Krishna Policharla <murali.policharla@broadcom.com>,
        Lukasz Majewski <lukma@denx.de>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: dsa: mv88e6xxx: fix max_mtu of 1492 on
 6165, 6191, 6220, 6250, 6290
Message-ID: <ZBGV1e00JTncoW3k@corigine.com>
References: <20230314182405.2449898-1-vladimir.oltean@nxp.com>
 <20230314182405.2449898-3-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230314182405.2449898-3-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aXatHj1eElZybJCctNajc5L8AVZm90LPIKPOAk5L8SD6taD1HyNYX8l1K7Pk?=
 =?us-ascii?Q?KbTBtdwzoZtcp7I3wJHej+a28qjLte0M68ygHbvQubOTg5NnRWkusbgwH7Td?=
 =?us-ascii?Q?BdYgXjL52hg4ll6WDkjHWctGgBN2tDPI9Al050hanuA1X1qgwI5GVwiBuLZL?=
 =?us-ascii?Q?vqRufkKnMqy43IaQlBCWETLNYbuqp/2Nj2jQ8APxAeazZ8zlJxhcOG4X5cTx?=
 =?us-ascii?Q?W+aJPLAb95HpVBRzYpLBmMGZ9957b+XUbgTVi1K2WxWEm2lysWyE37pXXRWa?=
 =?us-ascii?Q?Q0Cveuru0Zf9vnj3bePZ2rIB38o2bcL8QFo8s28y9A6Tx55PZ2mRbxsUXzzs?=
 =?us-ascii?Q?NLwfRF/IZqx6IXaOeqy5k84qofDG+pgvb8nC+emaYFFoC3lu38HswKlZC5XN?=
 =?us-ascii?Q?uJHevXU3DqVvfx1Yu0eOGF6GvbXdy1JQQfaqDYeLBVwtyrlTpyuMru62nA/c?=
 =?us-ascii?Q?n5adj//DVAOGGpYkFTirGUo8Y8WU7axtA4hmlr1Xvcg0HDEXWDqWtibtiAXa?=
 =?us-ascii?Q?VfMQRfNhl72US++HJHVweIK7aM7CYcTnvbI3rbL2pFSOCZLX/n23JUeclboe?=
 =?us-ascii?Q?Bs/KJCxC80OlIs4sWWvPHLaIch43vdQc/HD1JN6SxTEsZ0wMPB45NxLYSAfh?=
 =?us-ascii?Q?At+4KLd6FCDKs6UaVxzpGh2U0dEbLS8rnEPD8rjo/KQI36AKB5pQE6y4bTUx?=
 =?us-ascii?Q?cmFlXMjz1GK4W6KrUkqi4O87ASenSmDAeEYvEKJ9MgtwLE2qLhfitSlhl5nN?=
 =?us-ascii?Q?DpKy3RvK8rAtFlDrmFx2amTrQ2mWCO7zoF+coCYKLLSd74uySgs8jJdl5xVW?=
 =?us-ascii?Q?1yBOFs6UD3JAjuuAniifxwE18ICEH2+ilmfgMwrvpPT4lQlLgZoC4kpVzjFK?=
 =?us-ascii?Q?wWezvnQJj0znBgvujFIFy97Xwxd/ox0OGFsxWXQYyWhY0NVAlor6Oy/uZFg7?=
 =?us-ascii?Q?S7Gow7feCe2Zd2u/0ebm37Z+CnNwOIIOZHsMMND31KFmDfnUTH5ds0RcUoyC?=
 =?us-ascii?Q?4QGB4yUWLHZwcEkgZ52uinsVt2cAaS729MfDkPkqmHbntT1EbKzA4yiBOmaJ?=
 =?us-ascii?Q?ma5RvTMV9D9vm0msyUUYgzbEoRE+06r+B41WUa+312TrYNb4XEHVeS3phqVt?=
 =?us-ascii?Q?Te+zU1m5eV2l9MkF0cZrj2OKgVNZ4N0hPpr+jyekDSLo5N6+DDncAwdMAAbY?=
 =?us-ascii?Q?vYeNwCFYGamt4+4Lmh3p6i02n+evHha+Ez/2ZOqlI74Xst/MnFvB9rs9XRiq?=
 =?us-ascii?Q?d7k8pr7fq/nvw6EuHVn2Pgg9NtQQc3jvD5RlNCxRdM4XVcx5jCehMaaH7PfP?=
 =?us-ascii?Q?/Vc2yoT50xowLn7V1rqTisiHQ0vSbKFD+tP9m2Irhnbf1NAYk4TFj2Kz3n6r?=
 =?us-ascii?Q?dcVeFo86kgE4tshPxEwY7To1X1J9cUVIzcjQ9JyNg6x9xGPQbGpwOpMyzwxd?=
 =?us-ascii?Q?G5unUQK7Z1F0V5jSYJ/0ZUSz/o1Knxb47W163VZSdw162+/nu+gd5Y0huN+x?=
 =?us-ascii?Q?kDVyXiZ8HGVacDPQSRKvVlWhV2wC835jPwbvmi2XW0Nbc6+e0IjD2GcGVIsA?=
 =?us-ascii?Q?HF3lXC2s4/tUQUlIeh12eVIZZwDKgfU6GB3V1f3KvF/YjvyItj6iOuNcycCS?=
 =?us-ascii?Q?9uFVh0IzyLu7xh+vqraW3/HyCl88bNvQWrxGJr0K10VKpIwlRh9aozkkahk5?=
 =?us-ascii?Q?eU+t3A=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0fe7688-477a-4b5a-5a65-08db253b48f3
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 09:54:36.2762
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WK5wLS3KjkNKLtx/SheJEOVzOPYDswdJOAcMV2fykalYkqrliLFIVzIDwlYKh4yc4g51jBz4LB5SmuVG8+TPhdkU/CYKfhoLKskYlDE/7v8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5239
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 08:24:05PM +0200, Vladimir Oltean wrote:
> There are 3 classes of switch families that the driver is aware of, as
> far as mv88e6xxx_change_mtu() is concerned:
> 
> - MTU configuration is available per port. Here, the
>   chip->info->ops->port_set_jumbo_size() method will be present.
> 
> - MTU configuration is global to the switch. Here, the
>   chip->info->ops->set_max_frame_size() method will be present.
> 
> - We don't know how to change the MTU. Here, none of the above methods
>   will be present.
> 
> Switch families MV88E6165, MV88E6191, MV88E6220, MV88E6250 and MV88E6290
> fall in category 3.
> 
> The blamed commit has adjusted the MTU for all 3 categories by EDSA_HLEN
> (8 bytes), resulting in a new maximum MTU of 1492 being reported by the
> driver for these switches.
> 
> I don't have the hardware to test, but I do have a MV88E6390 switch on
> which I can simulate this by commenting out its .port_set_jumbo_size
> definition from mv88e6390_ops. The result is this set of messages at
> probe time:
> 
> mv88e6085 d0032004.mdio-mii:10: nonfatal error -34 setting MTU to 1500 on port 1
> mv88e6085 d0032004.mdio-mii:10: nonfatal error -34 setting MTU to 1500 on port 2
> mv88e6085 d0032004.mdio-mii:10: nonfatal error -34 setting MTU to 1500 on port 3
> mv88e6085 d0032004.mdio-mii:10: nonfatal error -34 setting MTU to 1500 on port 4
> mv88e6085 d0032004.mdio-mii:10: nonfatal error -34 setting MTU to 1500 on port 5
> mv88e6085 d0032004.mdio-mii:10: nonfatal error -34 setting MTU to 1500 on port 6
> mv88e6085 d0032004.mdio-mii:10: nonfatal error -34 setting MTU to 1500 on port 7
> mv88e6085 d0032004.mdio-mii:10: nonfatal error -34 setting MTU to 1500 on port 8
> 
> It is highly implausible that there exist Ethernet switches which don't
> support the standard MTU of 1500 octets, and this is what the DSA
> framework says as well - the error comes from dsa_slave_create() ->
> dsa_slave_change_mtu(slave_dev, ETH_DATA_LEN).
> 
> But the error messages are alarming, and it would be good to suppress
> them.
> 
> As a consequence of this unlikeliness, we reimplement mv88e6xxx_get_max_mtu()
> and mv88e6xxx_change_mtu() on switches from the 3rd category as follows:
> the maximum supported MTU is 1500, and any request to set the MTU to a
> value larger than that fails in dev_validate_mtu().
> 
> Fixes: b9c587fed61c ("dsa: mv88e6xxx: Include tagger overhead when setting MTU for DSA and CPU ports")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>