Message-ID: <5b360c35-1671-c0b8-78ca-517c7cd535ae@intel.com>
Date:   Wed, 15 Mar 2023 10:56:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH bpf-next v3 0/4] xdp: recycle Page Pool backed skbs built
 from XDP frames
Content-Language: en-US
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Menglong Dong <imagedong@tencent.com>,
        "Mykola Lysenko" <mykolal@fb.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, bpf <bpf@vger.kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Ilya Leoshkevich" <iii@linux.ibm.com>
References: <20230313215553.1045175-1-aleksander.lobakin@intel.com>
 <ca1385b5-b3f8-73f3-276c-a2a08ec09aa0@intel.com>
 <CAADnVQJDz3hBEJ7kohXJ4HUZWZdbRRamfJbrZ6KUaRubBKQmfA@mail.gmail.com>
 <CAADnVQ+B_JOU+EpP=DKhbY9yXdN6GiRPnpTTXfEZ9sNkUeb-yQ@mail.gmail.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <CAADnVQ+B_JOU+EpP=DKhbY9yXdN6GiRPnpTTXfEZ9sNkUeb-yQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFZ3WTNGOWF0N1dHc25yNEMvM2JnODVVVEszNUtST1VtR3JKVWZvR1ZWeERL?=
 =?utf-8?B?QWRnNHN6MWtUZ0R4QVF6RjRmVGRINkRuOE1zb3pwMHNCMHl6cUdRd1k4Ukln?=
 =?utf-8?B?d3dnRTJTNFRIdzd6VjNjUkFuUGI4YUtoVnFJSFJhYzNYVHVnOEJ5NldEa05F?=
 =?utf-8?B?czBreXZMVDhmdDVhTHN6RFlqczhKTGNzK2NBKzlMN2M2bCtnQXVPVDkxQm1Q?=
 =?utf-8?B?bk9ka0phWUhiSWxQNEhodVo0OWNjaGplMWlBZDh6ZEFrWUlzMUpleVRqNEtO?=
 =?utf-8?B?NERCM0JHcWF3UGd1QzdWOW4vdXZFdDJuTDU5LzIzL2w5ZUJ0NVUvSGRGR05l?=
 =?utf-8?B?R0IyK3hYL05xZkQwOFE2V24xL3lEZVovR29qbXAwUElpTVRCMnJQSXRXTzZq?=
 =?utf-8?B?ZWJpQkdpUkM0M0I2QXgydDhabjdWd2FYQ0w2ZEgrNHRWTkJhK1RRb0o0eXh4?=
 =?utf-8?B?VStBaUhPK2JpMlFtRGFKWUlkbGVDM1JGZ2o5WGN1YkdtTFhpK0tEWVhzUzNY?=
 =?utf-8?B?dm9aMVRxcjkyNDJpb0FZbzJaWnluZ1EyY1M5d1h6SkU0N2FhV1hIK3pKRHVu?=
 =?utf-8?B?UGJ2Ly9sYmhhc2p6UG10WmxGUUFQWVJmVFV3dSt1UC9Jc01ickdYZ2lrQm03?=
 =?utf-8?B?c2lINm9YU2U4QUlsbzRPbWtsUWU5OXZwV1hLYzRWRDZlcEthUiswOUs4L09S?=
 =?utf-8?B?M1ZoZ21CSFpLNTR1enZxcWM5Q2hEM3ZwMmpyYkNobkgxRGNZYUtzd0JiUEpB?=
 =?utf-8?B?emVDWWZueXlGN3NZTkUyN29mZG5IRUtrT0NsT3ozbFF1Qk9XSjF4RUpXVjgw?=
 =?utf-8?B?d2xmL3lJZ2NiR0xjc2RkVi9zYnlNbjFLOUQvMFlGSkZEc1NKZkNlS2llcXVv?=
 =?utf-8?B?WlRub2pKdkZ6RjJkOG1RT0FOdlJPMlVDMHV4bGIwc2F2UGFocUg5YkxRU0NT?=
 =?utf-8?B?eGorTU5GUHB2MitIRVRoMzkyS1FiZlF3c2tLSCtvTlZTMzZnSWtPSHRhckQy?=
 =?utf-8?B?SGsvMXhrS1prSGMyY051UEZPbHA1VEFSZm9DcEVjVkxkbGhzZkV1QVhuWnlJ?=
 =?utf-8?B?enhxS3FjclpoZzBIeW85SkZGcGdDZGZlUEpYWDV1RWVjOEVncXR2cXo3Rkpp?=
 =?utf-8?B?S1Robzl0SlNzNzFUZGl0NS82TlBhTjY4TDgvNXp4RmtlRmQ4bXZKS0ZvVFFO?=
 =?utf-8?B?dTJzNjFLaFZLWXNCMWxJQzdzK2VUR2c0bC9uWWc4UzVVWjM5Y1pqOHBMb1hW?=
 =?utf-8?B?dVkvOVU1ODMrUHJ3SzlBcnhQU2FYOUh6eHlVQVpxd213NnRyakZzV1M0VTNJ?=
 =?utf-8?B?eGg1WkxEK3RPekY3dlh2aU9GU2c3eG1mNEQrWnNkMURINWJxWVo5cXNiQXhr?=
 =?utf-8?B?UUVVcDZQQitRK1JOT2dXcE5rMDBqNmZDUVpJZnZuQytXdDlwYW9mNHdqUjha?=
 =?utf-8?B?ZWhZdDE2d1ZMaXZrWUF4OFdxTE1TZWxuWmtjVlU1N1NQUW9MR0RGWVJQTUdH?=
 =?utf-8?B?T1JLRFQ4VkhvNVgzMnVJSjQyZGVwRzI1TEE5ZGtweEpORkUwOWRETFBXeUk4?=
 =?utf-8?B?WTF2Z0I1WGZudjJMK3REcXdZWkZOMEFPSVhXS3poVU5YamtrK09yVjlTR2py?=
 =?utf-8?B?bFV0T2R5eE9HMFhGdXF4YnJSMFVtTm4vQytSOWtndzFHUjA2MDFrMmFSaTQy?=
 =?utf-8?B?MFBxZGUyVmJLV1NMVjFmWjVTUk92aVZ3M1JQK2VkZS9EVkE0QnNLVmk5ZFo2?=
 =?utf-8?B?eXI0eUVTQ2N3WmxpWGR0NmNoZzgzT2cyd1lzcThWMVpZbnJpQ0VJdXRNNjAr?=
 =?utf-8?B?ZkZvV3dWVERoZWFlUVFNQlcvbThYeDBmYXp4VnlzaFFmcE5peEJWS3cxd2Jm?=
 =?utf-8?B?bzdLZmVXUytSQkE5ODlpTUVRZFpWTk85M2NnWml4dXJJRTZoWWJteDFvSUFQ?=
 =?utf-8?B?ZVphQnV5OUxDekdST0ZXNGNhb0ZxS0tkcGNOYjArUENXTnU0bTd1YVB5SGpW?=
 =?utf-8?B?clpaMHF1UGlWbGExOWg5U0dqOUhJQiszakliVUZSaDZTTWZkUHhmeHltT0Zj?=
 =?utf-8?B?U3VmQmg4MHgyb3ZyUGtqMDBvRUlac0M3WDY4WkQ3SDYyS0pvdWhGY3I1NTVZ?=
 =?utf-8?B?dzVQcW55S1Bkam00WmlqRkIyNVJFdm03TC9lVzlxQ0dTaXA5UjF3UHlLL1hH?=
 =?utf-8?Q?UvzuCPuKJam7BCCJroEhNKo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e2cf7e1-0164-42c5-2881-08db253bb6cf
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 09:57:40.6197
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QArTjp0xVKvrg2jEngcDH4d9ppe398BHQr6arJPRNMXLv2hQjrJFf63Hg+X9yazlY6PGFltuiqdjh07btYJ6iIwYs32erPM4EXpfSUeNQlM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7618
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Tue, 14 Mar 2023 16:54:25 -0700

> On Tue, Mar 14, 2023 at 11:52 AM Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:

[...]

> test_xdp_do_redirect:PASS:prog_run 0 nsec
> test_xdp_do_redirect:PASS:pkt_count_xdp 0 nsec
> test_xdp_do_redirect:PASS:pkt_count_zero 0 nsec
> test_xdp_do_redirect:FAIL:pkt_count_tc unexpected pkt_count_tc: actual
> 220 != expected 9998
> test_max_pkt_size:PASS:prog_run_max_size 0 nsec
> test_max_pkt_size:PASS:prog_run_too_big 0 nsec
> close_netns:PASS:setns 0 nsec
> #289 xdp_do_redirect:FAIL
> Summary: 270/1674 PASSED, 30 SKIPPED, 1 FAILED
> 
> Alex,
> could you please take a look at why it's happening?
> 
> I suspect it's an endianness issue in:
>         if (*metadata != 0x42)
>                 return XDP_ABORTED;
> but your patch didn't change that,
> so I'm not sure why it worked before.

Sure, lemme fix it real quick.

Thanks,
Olek