Message-ID: <e15eac65-94d4-6a70-cab1-4fdb550116f7@collabora.com>
Date:   Wed, 15 Mar 2023 11:34:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] Revert "arm64: dts: mediatek: mt8173-elm: Move display to
 ps8640 auxiliary bus"
To:     Pin-yen Lin <treapking@chromium.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
References: <20230315041107.2886940-1-treapking@chromium.org>
Content-Language: en-US
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230315041107.2886940-1-treapking@chromium.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 15/03/23 05:11, Pin-yen Lin ha scritto:
> This reverts commit c2d94f72140a28d0f516b7c5e8274a9c185a04ff.
> 
> The `lg_lp120up1_mode` defined in panel-edp.c is not working for some
> panels used on elm/hana devices. Move the panel node out of the aux-bus
> subnode so the driver only uses the modes retrieved from the EDID.
> 
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> 

This commit was sent to fix display functionality on MT8173-Elm (Acer Chromebook
R13).... apparently this should get fixed with [1].

Investigating if this is the case.

Regards,
Angelo

[1]: 
https://patchwork.kernel.org/project/dri-devel/patch/20230315035508.2874915-1-treapking@chromium.org/

> ---
> 
>   arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++-----------
>   1 file changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index d452cab28c67..d45a2aeb0eb1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -90,6 +90,18 @@ switch-volume-up {
>   		};
>   	};
>   
> +	panel: panel {
> +		compatible = "lg,lp120up1";
> +		power-supply = <&panel_fixed_3v3>;
> +		backlight = <&backlight>;
> +
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&ps8640_out>;
> +			};
> +		};
> +	};
> +
>   	panel_fixed_3v3: regulator1 {
>   		compatible = "regulator-fixed";
>   		regulator-name = "PANEL_3V3";
> @@ -282,20 +294,6 @@ ps8640_out: endpoint {
>   				};
>   			};
>   		};
> -
> -		aux-bus {
> -			panel: panel {
> -				compatible = "lg,lp120up1";
> -				power-supply = <&panel_fixed_3v3>;
> -				backlight = <&backlight>;
> -
> -				port {
> -					panel_in: endpoint {
> -						remote-endpoint = <&ps8640_out>;
> -					};
> -				};
> -			};
> -		};
>   	};
>   };
>