From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org, robh@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH] tty: serdev: serdev-ttyport: add devt for ctrl->dev
Date:   Wed, 15 Mar 2023 18:54:00 +0800
Message-Id: <20230315105400.23426-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hUL88jz6qWz9urCKea+Envxim2EOdWsD9G6lzud9zL0BYTc42sicBjnKjxUv?=
 =?us-ascii?Q?Cm7PRweEEZWoWliId34+AIAKY8tVjNS0QVFzQXVSFOERdhBVO3NmyVS2jNt6?=
 =?us-ascii?Q?ceGkDaX9+eWwXIbxGQPJe80eIljNfW/Yfjgo1OS9Lv6ZjpBiI1lzhU31UlZb?=
 =?us-ascii?Q?fTisZT7aHEVSbSa8G+FCR9dMCrq12Ws3OhPu8KeuruhD22sH/64QkAkkRisy?=
 =?us-ascii?Q?fHVriMdB2nf1zGatYFEWgrGGAkHU+v5JOXk8W6syzIXOLzN2Zszq475Rm0XK?=
 =?us-ascii?Q?4YVRGpvfC6ZpNyq8mCBG6ENknvpXdeVy0CGwFirq86TH9EAdedNQDTKterZF?=
 =?us-ascii?Q?8BBP8iMyi2qBCdQq9F9vmuYsCQJ2uLs74Ihc8M3MCv1h47rthrynPH3fxE0b?=
 =?us-ascii?Q?twxtbP7RgHs3a9sufNLagT79cU0ouCqqasaq25y9U16Fpgcsq6012Xc5Xm62?=
 =?us-ascii?Q?d9ysKmJkDvwlmm6VFEBXWRXPlT6q+sgWCMdMbYrUguFVyTRqvPnm2/ho2+n4?=
 =?us-ascii?Q?Sgq5+udAkfd8rDMPDTfB9ADttfBwtWreETS5tICfIXZ9Vux/ujqy4dRy2xCY?=
 =?us-ascii?Q?Q2OknH9+VPVwdD0vNYP3fQxXgxocWbLL4W9Ra6wDzCuz03jx8mQQ47y/GAKR?=
 =?us-ascii?Q?VQ26a0PB1SmEeqI9D+aUU8lMrmBcWBgkUvKLdKdKo7/NzXfUENPnA2Mn+RXk?=
 =?us-ascii?Q?CfINHRNmdmlLXr5DpZVUl6VVNIW2SycX9KtSJfucjf5IeAU18FRg5hAx6KWN?=
 =?us-ascii?Q?L9M5ChAwtf7FXmNK6oz7NvUP2clsZX+X5FtmNGMrrMlHdy41l7zNDxeG0UPM?=
 =?us-ascii?Q?/GcwSzdnjqxxJzXW18B1S6Lo+y/wrAOzuAlEPo6ZKhteKF5OCIWXPu8Lseoa?=
 =?us-ascii?Q?J0CIGjivBnA3veltRTFEgnNmF3w/hlatV4jPVU+dvh0XG6Y1gUJQkN8J4btw?=
 =?us-ascii?Q?ZcX9mdZFlhhHKhXginVr3mpBilVVTDtoQlXIz/rGcu4nKCQCUzaXOivKUdJA?=
 =?us-ascii?Q?/YuLwbRkKceHstS/GQ3+sL47wWEhRn9R7ozXyz+NYp+0wmhxkPfgEKPxBgcO?=
 =?us-ascii?Q?OzrOHWraWQQ93RgPlANpTAD8gSOrPACi5SE3FBChzP2c5iqW8YQgJlG1CmSp?=
 =?us-ascii?Q?aBaKzgNR2M917EFsa2IZZl1Kzm4PS9atT4N6D3e+VP0OwCXLnxU4Ew1g1MZW?=
 =?us-ascii?Q?fxN5j7GVNXoUdMm+t0Itxj8+sUcOLstSk/fxErUbGXdqY2R64qe4BeuKAyrM?=
 =?us-ascii?Q?zmOYn6eVgdNc+oobSU+6hMSDu/3BPz0lX9+9sVpxN3qFD8NYC3vQKJK68V/F?=
 =?us-ascii?Q?z6CeM8Svha6f5TiywpJzsk6E+vnxdwQYf5qevraq3eRe62VE9scrLt/JSRwd?=
 =?us-ascii?Q?ZWmnmUJ12eKZBBa3KT9nY2T9LcWnqy1GvhO1IFkGu571IYP9BbO1aGAqO4BO?=
 =?us-ascii?Q?SaJgTkwH79R22mn0j1Btc3RwOmCqobPes1DKZukt5p37z/YSFsPmtzPexgv6?=
 =?us-ascii?Q?hRhv3xR3v9c34BOrd1r4wg6rhZDhs/xTBHQQZb43LMVyQt6uzNmLSmXWss2O?=
 =?us-ascii?Q?trKyNygduP0u8iCj3H+7Xayk/eLz4odthQVSFxSf?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9cf8f53-2066-435e-0238-08db2544055d
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 10:57:08.4323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v1jWeLxnwscOEmeIrpiTxhLBC4Jm6fLzFW3Lyt5T3wzVknsCPGj5Rd15E64ZZKr1XCfDF4Pqpym6I+LTG047gg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9263
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

For serdev framework, the serdev_controller device is the tty device,
which is also the child device of the uart_port device. If we don't set
devt property for ctrl->dev, device_find_child(uport->dev, ...) may
always return NULL in uart_suspend_port() function, which prevents us
from properly handling uart port suspend, so fix it here.

Fixes: bed35c6dfa6a ("serdev: add a tty port controller driver")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serdev/serdev-ttyport.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index bba37ab90215..c58af8141380 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -268,6 +268,7 @@ struct device *serdev_tty_port_register(struct tty_port *port,
 {
 	struct serdev_controller *ctrl;
 	struct serport *serport;
+	dev_t devt = MKDEV(drv->major, drv->minor_start) + idx;
 	int ret;
 
 	if (!port || !drv || !parent)
@@ -282,6 +283,7 @@ struct device *serdev_tty_port_register(struct tty_port *port,
 	serport->tty_idx = idx;
 	serport->tty_drv = drv;
 
+	ctrl->dev.devt = devt;
 	ctrl->ops = &ctrl_ops;
 
 	port->client_ops = &client_ops;
-- 
2.17.1