Message-ID: <e482a189-823f-35b1-b411-4c4db22a86a6@quicinc.com>
Date:   Wed, 15 Mar 2023 16:52:39 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH V8 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <mturquette@baylibre.com>,
        <sboyd@kernel.org>, <linus.walleij@linaro.org>,
        <catalin.marinas@arm.com>, <will@kernel.org>,
        <p.zabel@pengutronix.de>, <shawnguo@kernel.org>, <arnd@arndb.de>,
        <marcel.ziswiler@toradex.com>, <dmitry.baryshkov@linaro.org>,
        <nfraprado@collabora.com>, <broonie@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
        <quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
        <quic_arajkuma@quicinc.com>, <quic_anusha@quicinc.com>,
        <quic_poovendh@quicinc.com>
References: <20230214163116.9924-1-quic_devipriy@quicinc.com>
 <20230214163116.9924-5-quic_devipriy@quicinc.com>
 <ZAZ+GeGu8mW1XqpG@surfacebook>
 <15d270ca-1068-b926-efc9-a14ddfc90a54@quicinc.com>
 <CAHp75VfMae9M2R0Bw6-sYuHPPberakEzKct65SXV0XEaOFtXTg@mail.gmail.com>
Content-Language: en-US
From:   Devi Priya <quic_devipriy@quicinc.com>
In-Reply-To: <CAHp75VfMae9M2R0Bw6-sYuHPPberakEzKct65SXV0XEaOFtXTg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/8/2023 6:54 PM, Andy Shevchenko wrote:
> On Wed, Mar 8, 2023 at 11:52 AM Devi Priya <quic_devipriy@quicinc.com> wrote:
>> On 3/7/2023 5:28 AM, andy.shevchenko@gmail.com wrote:
> 
> ...
> 
>>>> +    depends on OF
>>>
>>> No compile test on non-OF configurations?
> 
>> As per the generic convention followed in other
>> SoCs, we do not have compile test on non-OF configurations
> 
> Why not? So, you have to explain the deliberate narrowing of the test coverageOn adding 'depends on OF || COMPILE_TEST', the driver compiles
for non-OF configuration as well.
Will update this in the next spin!
> 
>>>> +    depends on ARM64 || COMPILE_TEST
> 
> ...
> 
>>>> +#define FUNCTION(fname)                                     \
>>>
>>> PINCTRL_PINFUNCTION() ?
>> I see that there are quite a bunch of files that has to
>> be modified for using the generic data type and
>> macro for the pin function definition
>> We shall post a separate series to accommodate the changes
> 
> Sure, that's fine. Please do!
Sure, thanks
> 
>>>> +    [msm_mux_##fname] = {                           \
>>>> +            .name = #fname,                         \
>>>> +            .groups = fname##_groups,               \
>>>> +            .ngroups = ARRAY_SIZE(fname##_groups),  \
>>>> +    }
> 
> ...
> 
>>>> +#define PINGROUP(id, f1, f2, f3, f4, f5, f6, f7, f8, f9)    \
>>>> +    {                                               \
>>>> +            .name = "gpio" #id,                     \
>>>> +            .pins = gpio##id##_pins,                \
>>>> +            .npins = (unsigned int)ARRAY_SIZE(gpio##id##_pins),     \
>>>
>>> Can you embed struct pingroup?
>> Will take care of this in a separate series
> 
> Ditto. Thanks!
Sure, thanks
> 
>>>> +    }
> 
> ...
> 
>>>> +};
>>>
>>> No MODULE_DEVICE_TABLE()?
>> The MODULE_DEVICE_TABLE(of, ipq9574_pinctrl_of_match) entry has
>> been added at the end of the file
> 
> So, you know what to do then to address my comment :-)
Yep, got it!
> 

Best Regards,
Devi Priya