Date:   Wed, 15 Mar 2023 12:29:05 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        Simon Horman <simon.horman@corigine.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: can: tcan4x5x: Add tcan4552 and
 tcan4553 variants
Message-ID: <20230315112905.qutggrdnpsttbase@pengutronix.de>
References: <20230314151201.2317134-1-msp@baylibre.com>
 <20230314151201.2317134-2-msp@baylibre.com>
 <680053bc-66fb-729f-ecdc-2f5fe511cecd@linaro.org>
 <20230315104914.qpwhnv6drjwau5jr@blmsp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="nomegujo7vfexmwg"
Content-Disposition: inline
In-Reply-To: <20230315104914.qpwhnv6drjwau5jr@blmsp>
Precedence: bulk


--nomegujo7vfexmwg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 15.03.2023 11:49:14, Markus Schneider-Pargmann wrote:
> Hi Krzysztof,
>=20
> On Tue, Mar 14, 2023 at 09:01:10PM +0100, Krzysztof Kozlowski wrote:
> > On 14/03/2023 16:11, Markus Schneider-Pargmann wrote:
> > > These two new chips do not have state or wake pins.
> > >=20
> > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > > ---
> > >  .../devicetree/bindings/net/can/tcan4x5x.txt          | 11 ++++++++-=
--
> > >  1 file changed, 8 insertions(+), 3 deletions(-)
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b=
/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> > > index e3501bfa22e9..38a2b5369b44 100644
> > > --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> > > +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> > > @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller
> > >  This file provides device node information for the TCAN4x5x interfac=
e contains.
> > > =20
> > >  Required properties:
> > > -	- compatible: "ti,tcan4x5x"
> > > +	- compatible:
> > > +		"ti,tcan4x5x" or
> > > +		"ti,tcan4552" or
> > > +		"ti,tcan4553"
> >=20
> > Awesome, they nicely fit into wildcard... Would be useful to deprecate
> > the wildcard at some point and switch to proper compatibles in such
> > case, because now they became confusing.
> >=20
> > Anyway:
> >=20
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>=20
> Thank you. Indeed the old generic name could be replaced, unfortunately
> I don't have a list of devices that this generic wildcard matches.

The mcp251xfd driver supports "microchip,mcp2517fd",
"microchip,mcp2518fd", "microchip,mcp251863", and "microchip,mcp251xfd".
It always does auto detection and throws a warning if the found chip is
not consistent with the firmware (DT, ACPI).

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--nomegujo7vfexmwg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmQRq/8ACgkQvlAcSiqK
BOhz7Af+Ijf/SfgPsTnfv7fBmVGkSnNMyFFNZrx4qRYBaKVOQLO/yM1cbTi9nvpB
+8Jb+Dar80wua5kHmFcb/Uipad3/MF/JtA8TPKB1CAagvEWgw2MIAKyzTVGJzPxR
sSIlDOINkWgmmhEvN0C+jNT51CgvO/6+0j4ZidDf3lwBgyofKAK6lSD+y5UupLYJ
/eKt/oQFhlgDMVeatstmBGh0eMO2XV+T2Q5t/MVdqa/teoUrIfp3i98MPLpfB1uh
nPXml9k3s5LDhFGnq31TrCBfcQ8n/S0QnphX+dyIKIuHBoa9YhbYgLXZrCQEm+fu
HwpLvTBfsA9deh1Xx9r4avsdU5zz0Q==
=AotW
-----END PGP SIGNATURE-----

--nomegujo7vfexmwg--