MIME-Version: 1.0
Date:   Wed, 15 Mar 2023 05:30:34 -0700
From:   Angus Ainslie <angus@akkea.ca>
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     Martin Kepplinger <martin.kepplinger@puri.sm>, robh@kernel.org,
        krzysztof.kozlowski@linaro.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, kernel@puri.sm,
        linux-imx@nxp.com, devicetree@vger.kernel.org,
        phone-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Subject: Re: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove
 dis_u3_susphy_quirk from usb_dwc3_0
In-Reply-To: <20230314072832.GC143566@dragon>
References: <20230309204608.237605-1-martin.kepplinger@puri.sm>
 <20230309204608.237605-12-martin.kepplinger@puri.sm>
 <20230314072832.GC143566@dragon>
Message-ID: <c2cf4eb5fc984aec8a21adfc440b511e@akkea.ca>
User-Agent: Roundcube Webmail/1.3.17
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Shawn,

On 2023-03-14 00:28, Shawn Guo wrote:
> On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote:
>> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
>> 
>> This reduces power consumption in system suspend by about 10%.
> 
> Is there any other impact than this nice power gain?  Otherwise,
> I would wonder why the quirk was enabled in the first place.
> 

This comes from the early days of board bring-up and IIRC it seemed to 
stabilize flashing using the mfgtools over USB. Whatever gremlin was in 
those early boards is long gone and this is no longer needed.

Cheers
Angus

> Shawn
> 
>> 
>> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi 
>> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> index 0b4b49fa1392a..f557632f574fa 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> @@ -1322,7 +1322,6 @@ &usb_dwc3_0 {
>>  	#address-cells = <1>;
>>  	#size-cells = <0>;
>>  	dr_mode = "otg";
>> -	snps,dis_u3_susphy_quirk;
>>  	usb-role-switch;
>>  	status = "okay";
>> 
>> --
>> 2.30.2
>>