Date:   Wed, 15 Mar 2023 14:08:03 +0100
From:   Sebastian Reichel <sre@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCHv2 10/12] power: supply: generic-adc-battery: add
 temperature support
Message-ID: <20230315130803.aold4bo7x27x3hza@mercury.elektranox.org>
References: <20230314225535.1321736-1-sre@kernel.org>
 <20230314225535.1321736-11-sre@kernel.org>
 <CACRpkdZ0j8HQzzXtDbVcxAJkBsdRXUKNJm3BmLB583JfnetAWw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hiy7k232xoaf3bj7"
Content-Disposition: inline
In-Reply-To: <CACRpkdZ0j8HQzzXtDbVcxAJkBsdRXUKNJm3BmLB583JfnetAWw@mail.gmail.com>
Precedence: bulk


--hiy7k232xoaf3bj7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Linus,

On Wed, Mar 15, 2023 at 09:04:15AM +0100, Linus Walleij wrote:
> On Tue, Mar 14, 2023 at 11:55=E2=80=AFPM Sebastian Reichel <sre@kernel.or=
g> wrote:
> > From: Sebastian Reichel <sebastian.reichel@collabora.com>
> > Another typical thing to monitor via an ADC line is
> > the battery temperature.
> >
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>=20
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>=20
> >  static bool gab_charge_finished(struct gab *adc_bat)
> > @@ -115,6 +118,8 @@ static int gab_get_property(struct power_supply *ps=
y,
> >                 return read_channel(adc_bat, GAB_CURRENT, &val->intval);
> >         case POWER_SUPPLY_PROP_POWER_NOW:
> >                 return read_channel(adc_bat, GAB_POWER, &val->intval);
> > +       case POWER_SUPPLY_PROP_TEMP:
> > +               return read_channel(adc_bat, GAB_TEMP, &val->intval);
>=20
> Hm. I wonder if these should rather all use read_channel_processed()?
>=20
> The difference is that you will then support ADCs with internal scaling
> which is beneficial. Most of the time it doesn't matter.

read_channel is a local helper, the driver uses the processed
variant of iio_read_channel:

static int read_channel(struct gab *adc_bat, enum gab_chan_type channel,
                int *result)
{
        int ret;

        ret =3D iio_read_channel_processed(adc_bat->channel[channel], resul=
t);
        if (ret < 0)
                pr_err("read channel error\n");
        else
                *result *=3D 1000;

        return ret;
} =20

-- Sebastian

--hiy7k232xoaf3bj7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQRwygACgkQ2O7X88g7
+posVQ/9EN49adbU7MGa07ofbn9QEThOKKK7sZpl+dk5sebGmmgklHLBifQpAsFV
L54r2G3VeKr7OHlEReVM3hqBWSgLizSoJuA4mc3T3SR8eOlH4MfVHJcw0sGh5dmN
7x+K8xiU0dxPgPXy1YCs3qKRIaGceTWUdO7N/kcGkef2PUNmtPB2+tSREpwtw2A7
zCRZNDwb7mw6OohlK9cueMim1daE2nnDukAXPmgON6Tazm/TB4ugVZHDUrpv3cPM
pVYc71yrO3ZiQ1fW5VI/xsNoY7CJDDWkNeaE7LD3vm6icnhvSQLTD8p1d4uOzjCm
z+fF8IqyuoaiUogE0QcGjeGqd/4nXUJSuxHf5NYplMdOwgQiso4gxqb4AMsu5SeL
Pft2dz8kBcnTetCoNHi0aRJxSRF+V5zrXDGexKs+MIJ6qFw1xNnfs0JsrR7FTpg/
CgfAF8s5CAvoh795kDROwVb+lMNt0dzm5mbP6Ka60ECtLRKpr0odhhW3I50uvO1t
N9IghkXuVOgKDwhd0UFhiJGBLcorpyhLpPE4ZxfrWZq11hZS0au9TuYPZsudx88N
4ZSzK+l3RQrPPhlDgJv3S2WMaVXp1XK9rwj2YQyf0jwu/3aPrtuvIyZ+s3ag76p2
tGnTiVEn+2C4fKcSP68Dlt8AtzCK86lYpuim6fgB/KvdjRY33Lw=
=1aSX
-----END PGP SIGNATURE-----

--hiy7k232xoaf3bj7--