Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A31C61DA4 for ; Wed, 15 Mar 2023 13:40:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232453AbjCONkd (ORCPT ); Wed, 15 Mar 2023 09:40:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232333AbjCONk3 (ORCPT ); Wed, 15 Mar 2023 09:40:29 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47A4C7D89; Wed, 15 Mar 2023 06:40:19 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E7B691FD76; Wed, 15 Mar 2023 13:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678887617; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JDMwZnj0jpzJKMut3O94VkQeRgqjxGWKZ5FCPetUts8=; b=BjaXSNRMbW7UVWsqkIPQS48AvhzPCz0KmnAAWTpY7yjhSJ+yzG6bUUvO6aoLUrqEjn61J8 IZcnP7fGpe+cQI5ARDl91zXTmYOJg9ceBhTh3fjh2K76V/NgD9G8gTPzN5vh5SXy/TG8ej rs3/DiNfMsFKgXCgGkzdb5MlwUaF23M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678887617; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JDMwZnj0jpzJKMut3O94VkQeRgqjxGWKZ5FCPetUts8=; b=MXJhsVmRLm74iRenhRKigv2/GAwervP22DuCtg6PX8YkAPaj3QnYIqB5MVoR+ubFrsUbgw 1D7r4yTOJ7q4ndDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 625DE13A2F; Wed, 15 Mar 2023 13:40:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gnM+F8HKEWTjLwAAMHmgww (envelope-from ); Wed, 15 Mar 2023 13:40:17 +0000 Message-ID: Date: Wed, 15 Mar 2023 14:40:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 0/7] remove SLOB and allow kfree() with kmem_cache_alloc() Content-Language: en-US To: Lorenzo Stoakes Cc: Mike Rapoport , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org, "David S. Miller" , Eric Dumazet , Frederic Weisbecker , Jakub Kicinski , Joel Fernandes , Jonathan Corbet , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Mike Rapoport , Neeraj Upadhyay , Paolo Abeni , "Paul E. McKenney" , Steven Rostedt References: <20230310103210.22372-1-vbabka@suse.cz> <93d33f35-fc5e-3ab2-1ac0-891f018b4b06@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/14/23 23:10, Lorenzo Stoakes wrote: > On Mon, Mar 13, 2023 at 05:36:44PM +0100, Vlastimil Babka wrote: >> > git grep -in slob still gives a couple of matches. I've dropped the >> > irrelevant ones it it left me with these: > > I see an #ifdef in security/tomoyo/common.h which I guess is not really > relevant? And certainly not harmful in practice. Thought might be nice to > eliminate the last reference to CONFIG_SLOB in the kernel :) Yeah I wrote in the cover letter the tomoyo change is already going through tomoyo tree. And based on Jakub's feedback the skbuff change will be also posted separately.