MIME-Version: 1.0
References: <20230315120934.16954-1-sinthu.raja@ti.com> <20230315134656.bt3mczw73h3z2j57@privacy>
In-Reply-To: <20230315134656.bt3mczw73h3z2j57@privacy>
From:   Sinthu Raja M <sinthu.raja@mistralsolutions.com>
Date:   Wed, 15 Mar 2023 19:24:33 +0530
Message-ID: <CAEd-yTQV2k=-W3LXYgq-4jrLCtR_ncij8UAPWWfd4xsJzGU2tg@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO
 lines for Rev E2
To:     Nishanth Menon <nm@ti.com>
Cc:     Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Sinthu Raja <sinthu.raja@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 15, 2023 at 7:17=E2=80=AFPM Nishanth Menon <nm@ti.com> wrote:
>
> On 17:39-20230315, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.raja@ti.com>
> >
> > Rev E2 of the AM68 SK baseboard has updated the GPIO IO expander pins
> > functionality. To match the Rev E2 schematics, update existing IO expan=
der
> > GPIO line names and the corresponding node which uses the expansion(exp=
1)
> > node.
> >
> > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > ---
> >
> > Schematics Ref: https://www.ti.com/lit/zip/sprr463
>
> Looking at https://www.ti.com/tool/SK-AM68 looks like E1 never hit
> production, is that correct?
Yes, E1 didn't hit production.
>
> Does this need a "Fixes" tag?
It is a migration from E1 to E2 so I assume that a Fixes tag is not require=
d.

Regards
Sinthu Raja
>
> >
> >  arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 12 +++++-------
> >  1 file changed, 5 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/ar=
m64/boot/dts/ti/k3-am68-sk-base-board.dts
> > index 2091cd2431fb..27a43a8ecffd 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > @@ -60,7 +60,7 @@ vdd_mmc1: regulator-sd {
> >               regulator-boot-on;
> >               enable-active-high;
> >               vin-supply =3D <&vsys_3v3>;
> > -             gpio =3D <&exp1 10 GPIO_ACTIVE_HIGH>;
> > +             gpio =3D <&exp1 8 GPIO_ACTIVE_HIGH>;
> >       };
> >
> >       vdd_sd_dv: regulator-tlv71033 {
> > @@ -264,12 +264,10 @@ exp1: gpio@21 {
> >               reg =3D <0x21>;
> >               gpio-controller;
> >               #gpio-cells =3D <2>;
> > -             gpio-line-names =3D "CSI_VIO_SEL", "CSI_SEL_FPC_EXPn", "H=
DMI_PDn",
> > -                                     "HDMI_LS_OE", "DP0_3V3 _EN", "BOA=
RDID_EEPROM_WP",
> > -                                     "CAN_STB", " ", "GPIO_uSD_PWR_EN"=
, "eDP_ENABLE",
> > -                                     "IO_EXP_PCIe1_M.2_RTSz", "IO_EXP_=
MCU_RGMII_RSTz",
> > -                                     "IO_EXP_CSI2_EXP_RSTz", " ", "CSI=
0_B_GPIO1",
> > -                                     "CSI1_B_GPIO1";
> > +             gpio-line-names =3D " ", " ", " ", " ", " ",
> > +                               "BOARDID_EEPROM_WP", "CAN_STB", " ",
> > +                               "GPIO_uSD_PWR_EN", " ", "IO_EXP_PCIe1_M=
.2_RTSz",
> > +                               "IO_EXP_MCU_RGMII_RST#", " ", " ", " ",=
 " ";
> >       };
> >  };
> >
> > --
> > 2.36.1
> >
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DD=
B5 849D 1736 249D


--=20
With Regards
Sinthu Raja