Message-ID: <aea59bed-12b6-d020-a09e-1ff35c1b4410@kernel.org>
Date:   Wed, 15 Mar 2023 17:23:10 +0200
MIME-Version: 1.0
Subject: Re: [PATCH 06/27] interconnect: remove MODULE_LICENSE in non-modules
Content-Language: en-US
To:     Nick Alcock <nick.alcock@oracle.com>, mcgrof@kernel.org
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        linux-pm@vger.kernel.org
References: <20230224150811.80316-1-nick.alcock@oracle.com>
 <20230224150811.80316-7-nick.alcock@oracle.com>
From:   Georgi Djakov <djakov@kernel.org>
In-Reply-To: <20230224150811.80316-7-nick.alcock@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Nick,

Thanks for the patch!

On 24.02.23 17:07, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.

I think that it might be better to remove not just the MODULE_LICENCE,
but also the other module related code in this file.

Thanks,
Georgi

> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Georgi Djakov <djakov@kernel.org>
> Cc: linux-pm@vger.kernel.org
> ---
>   drivers/interconnect/core.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 25debded65a8..de61a639fab4 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -1146,4 +1146,3 @@ device_initcall(icc_init);
>   
>   MODULE_AUTHOR("Georgi Djakov <georgi.djakov@linaro.org>");
>   MODULE_DESCRIPTION("Interconnect Driver Core");
> -MODULE_LICENSE("GPL v2");