Date:   Wed, 15 Mar 2023 16:43:20 +0100 (CET)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     Kloudifold <cloudifold.3125@gmail.com>
cc:     Alison Schofield <alison.schofield@intel.com>,
        teddy.wang@siliconmotion.com, sudipm.mukherjee@gmail.com,
        gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        outreachy@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase
In-Reply-To: <ZBHlycBoZ0JRwHZm@CloudiRingWorld>
Message-ID: <d231df94-c8db-aa3e-98c9-3d56f758675b@inria.fr>
References: <ZBHlycBoZ0JRwHZm@CloudiRingWorld>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


On Wed, 15 Mar 2023, Kloudifold wrote:

> Hi Alison,
>
> Thanks a lot for your help, so if I send my v3 patch, should it be like
> below? (Philipp said "please make the Subject more unique", but the
> Subject could be only a few permutations of very few words, I can't see
> how it could be any more unique.)
>
> Subject: [PATCH v2] staging: sm750: Rename functions from CamelCase to snake case
>
> sm750 driver has sm750_hw_cursor_* functions, which are named in
> camelcase. Rename them to snake case to follow the function naming
> convention.
>
> Changes in v3:
> - Add this changelog (Philipp)
> - Move lkp tags and link to the correct location in commit log (Alison)
> - Update the commit msg (Philip)
> - Update the commit log (Bagas, Julia)
>
> Changes in v2:
> - Use new function names in call sites (LKP)

All these changes should go below the --- line, not above it like this.
The history of changes is for people who are following along in the email
discussion.  Once the patch is accepted, they won't be meaningful.  So
they should be the in the part that disappears, which is the part below
the ---.

julia

>
> Signed-off-by: Kloudifold <cloudifold.3125@gmail.com>
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@intel.com/
> ---
> git diff message
> ---
>
>