Date:   Wed, 15 Mar 2023 16:57:29 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Sean Anderson <seanga2@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/9] net: sunhme: Just restart
 autonegotiation if we can't bring the link up
Message-ID: <ZBHq6UM8GwOaDye4@corigine.com>
References: <20230314003613.3874089-1-seanga2@gmail.com>
 <20230314003613.3874089-2-seanga2@gmail.com>
 <ZBF/wr8HUg49gWZK@corigine.com>
 <a5eea573-2418-d4dd-94b7-72bda4978666@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a5eea573-2418-d4dd-94b7-72bda4978666@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/dzePyNhz0SLGC+VVP2Avr8My0tTo8NxB80znZoTH5x0+0KmU8Dk3+6dJyLH?=
 =?us-ascii?Q?aswoRMonw5t0K/hKiIsmzDRiUki2ad4IKgz9RWBjZCI9THxinwrMd3My8+Pz?=
 =?us-ascii?Q?YzMgv3HngIK2+V8nONofybbNstcjgL+BQnguihtOLUZwvf6nV+/boGqBoEcm?=
 =?us-ascii?Q?UaRiwwnN6sxM2AKUmm+CvuYrtl4fowjKHKT7QqvmMeTD4VLCz9mavTlNHfPd?=
 =?us-ascii?Q?71fbevvGuZQMY7ZXwn6Uj0T82FdmJmDmh69HJZIH9sxMz9J+zsNFxEBvd6hW?=
 =?us-ascii?Q?J6yVCq7NPFxMeyZ9uYOa3NvVxGVlBaTSehyJxEA4WmqHyvGIHAWlCHcBGrpT?=
 =?us-ascii?Q?JlbgZYOXCaArSuWH6HRT0COfVnyF5uDpXw8116S7YS04+jOeSCipgr5U1s3k?=
 =?us-ascii?Q?lE68emfbKMdfcXAkm8RV9hM/lPWnyniJdLiW/S2+WF6K80FNWx6CvfFaAu7K?=
 =?us-ascii?Q?i68JrY9T8VpEp31ild8As9o+KVFQaxyhvCxkoijBKSy0Da5giMFvE+JX220m?=
 =?us-ascii?Q?5/RrfSYXGlFxAi7Q/YsUwHd+bgwtCkoRWPOVSiUHAGWXlFrLKZ1/INbF+w/b?=
 =?us-ascii?Q?bRUN1FM9588c0WVjkGzZguvNMgrcuROtZbavC8r6espMOc0mSEMfxNQwV5Q2?=
 =?us-ascii?Q?BYIaDqqMEx+hFmsoWFtsjm6YONI0PDrypfMYBb4g9qkVh7dw5fPGJv+AYzqE?=
 =?us-ascii?Q?SXx4RswX0TVmtJTXVAPhjgmCHf/tJ+1o7pWe2PISOyGRyzyQfJYIPWK26JgE?=
 =?us-ascii?Q?i0revf3OY75QTrldlsBpq0dvyUAmafyunL+E644qCK4VSan8y4epmAAlglqP?=
 =?us-ascii?Q?4ozCqQ0ibtHPg/7ijHn9ddioVvYMfZrxDOGO/nuiPAk5jwFOWM7QzBd/Waag?=
 =?us-ascii?Q?/xco9jYysOgZ17JeZ4A3ADoVt/+tEP0rQxbvH2Doh3z6iOgF/2IQn7bw9s+/?=
 =?us-ascii?Q?pJx6sRMiR699qPpD1aywlbn9SXvzdHhmMBfZkmcrW3V+M/IwR/wPbGxcedFA?=
 =?us-ascii?Q?a76roM0jHF1J+hzgBNtioc3B0FhH5Yf3GLD4Dga0+ApY2sYv+/liMqwXLXlR?=
 =?us-ascii?Q?pyY66x5nEcANkHqHEnBVOLFFyGXKLKFdLpJL821mZRxc3VitE6buqnKsYc/E?=
 =?us-ascii?Q?mxb8oVPX+Dh0B93lHfgUYuaKAbQ7JtiDBgmnaRNhcg+72RuiSEi/BEL+bA1F?=
 =?us-ascii?Q?B1cOwiVh+HB9kqZiV5R3qFsez164J8P4GWBHpsZPUBvtLR3rtEQlmXXWs0sL?=
 =?us-ascii?Q?rdMuyQ36IgLNncgTcyevvP6s77EUoyJn+RE83GF9t4pbvaL1/CTSzapiEF4n?=
 =?us-ascii?Q?5lC1A1Gq/35Vg14XCLmijpwPjn5yrHeHBXLnMwgukxx0/UopCX0zaK4bEb2X?=
 =?us-ascii?Q?G6s9wWGsMsRmdaLp5HUGnX+cI1CsVHJs3SuvZpkyJGTx/2hLDg+zxFC4oz31?=
 =?us-ascii?Q?FK9l7egvCkhXYDW5gFVIREkUFZpJ3BLCQsES8RiiruO7Ul733rTruzETaGqy?=
 =?us-ascii?Q?cL6AbE9If9cGjK6EHwf/mi5j/lsn/UW/nyXKP9KYlrhpLth/dLblR58QS2Oe?=
 =?us-ascii?Q?VdpmIKNpQPjhaWPxEadSti53ieEHk3fzgQs1sl9wleOqL4IrPmGygWsxPss7?=
 =?us-ascii?Q?ZVbsZH7RWfDbsNct2mVgCYiB2N+fTuB83Rd+8FQk5ql/YjdqHxwZtr0lLsFl?=
 =?us-ascii?Q?0KBrNA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 181ef5a4-1e54-4b42-3ad5-08db256dfed8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 15:57:36.1709
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GfOG5h7FRgZXkiE4w0IykZFkpDlN9n+OL6RXvXhB3onkGoGq3lszKCBYwINrtPGBMOELX1B0k/CTCYDUSOnN3fLM8lCCsTUdmHvLUstZxWs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5037
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 15, 2023 at 11:35:19AM -0400, Sean Anderson wrote:
> On 3/15/23 04:20, Simon Horman wrote:
> > On Mon, Mar 13, 2023 at 08:36:05PM -0400, Sean Anderson wrote:
> > > If we've tried regular autonegotiation and forcing the link mode, just
> > > restart autonegotiation instead of reinitializing the whole NIC.
> > > 
> > > Signed-off-by: Sean Anderson <seanga2@gmail.com>
> > 
> > Hi Sean,
> > 
> > This patch looks fine to me, as do patches 3 - 4, which is as far as I have
> > got with my review.
> > 
> > I do, however, have a general question regarding most of the patches in this
> > series: to what extent have they been tested on HW?
> 
> I have tested them with some PCI cards, mostly with the other end
> autonegotiating 100M. This series doesn't really touch the phy state
> machines, so I think it is fine to just make sure the link comes up (and
> things work after bringing the interface down and up).

Understood, I'll proceed with my review on that basis.

> > And my follow-up question is: to what extent should we consider removing
> > support for hardware that isn't being tested and therefore has/will likely
> > have become broken break at some point? Quattro, the subject of a latter
> > patch in this series, seems to be a case in point.
> 
> Well, I ordered a quattro card (this hardware is quite cheap on ebay) so
> hopefully I can test that.

Yes, for some reason I was searching on eBay too :)

> The real question is whether there's anyone using this on sparc. I tried
> CCing some sparc users mailing lists in the cover letter, but no luck so
> far.

Yes, that is the question.