Date:   Wed, 15 Mar 2023 16:59:19 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Sean Anderson <seanga2@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/9] net: sunhme: Unify IRQ requesting
Message-ID: <ZBHrVz18X00K88S8@corigine.com>
References: <20230314003613.3874089-1-seanga2@gmail.com>
 <20230314003613.3874089-4-seanga2@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230314003613.3874089-4-seanga2@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8gGtWujEYawG17YtEm0IRZo4QFbz75+/Ro5/N5ClZaVN8bnvJS7hTr+vEDfw?=
 =?us-ascii?Q?qTo0h4uuR8WDbPRvSeXV4mMikk9paEZm1m9+CB9kIPXflOUwjwSZNRXLCL5c?=
 =?us-ascii?Q?hfiNiEtv9GciWPp8hGyYtS354gicw102Ksuu84WfJmOHwdmYiyfh2mdaqhgh?=
 =?us-ascii?Q?dmSJ7W5ktLicr9KZlcAb9jt9/K0+zWf/4iNifL9Cnwlm1ZlYuZ3QvjvvYU6H?=
 =?us-ascii?Q?X5uo+/jDLra/5dOSgAcWD8YwdQDTGRM9FxPBN1oKS/39pg22VCO8k8iwW7km?=
 =?us-ascii?Q?7whzbcw6CDVzwWxPLy9GH3gL2ArX6PPslKT7lm54hSRlZICz9rg649aJUyl+?=
 =?us-ascii?Q?rg6bN0ZD0Isnmrejl/q0tC0J0BiUVQJqL0kRav6TsDW/rcRoLiZjvSMasKqq?=
 =?us-ascii?Q?rm7Hw1qkWeaedF0LnoCyczNmDo+7SGk0TbgdV8A/nDJhLEBWr9s0ICPN6FyX?=
 =?us-ascii?Q?7+T+Z4yuR9ETQYxl5s8DKcVhJxZypyCLC55VLzVHWumk9ZSUUpZdfpCij36c?=
 =?us-ascii?Q?RziqsP8UQnC4/RUtOqY315iEEzqD+yYYMVtDhD/WnJCnsbz1PtjlU3EPqueu?=
 =?us-ascii?Q?0DpBTzeYuVzEMoVj5Xwnt7HnebxBVboN2e4C8dJZK+FB+lWFatu0He6g2u3y?=
 =?us-ascii?Q?xG+pzAjUIFgPBa1tAs8r+FiYTLa3pzzXvDifQFgQFyKYeY4Fxgl2S3R3yjkU?=
 =?us-ascii?Q?FD6W4neuRQJZUa+rmyqAVxUPgPQ97hE3bkhmtxctzd1i1nOxo1mAwNvITNNu?=
 =?us-ascii?Q?c14IFQHHiRv/dlILx2xmZXDIforulBNPPR0+lTvbffqWt5WvzbjUT8twptir?=
 =?us-ascii?Q?PyrXjyg0SaJRqMfiTUGXQyeVZDqM8XUbbhjjwBmS+RQ3yh23jBvsQT4H8nHH?=
 =?us-ascii?Q?ejvVRekpGSphCsc/icuLrGZAxZrCAfWRw/2iyISRP544Oc73ljx79WF/mIag?=
 =?us-ascii?Q?Fw/oqGU8HabKqLldBxjTxN699VX6PzY6go4lfSGXQmteHQj6o1XUAWZJuOxB?=
 =?us-ascii?Q?JFTwFzMAhebyp/DI377tkivHrTsiJinW3ynNVWTcpxdnMkq9ODuaaXRfz1/F?=
 =?us-ascii?Q?Jz3XkyaO3DDx+H0pIqO3EQslnDducq0De58lv/TebcSuQr7WEYJWzQba7k/H?=
 =?us-ascii?Q?G4oSdjqxIARBwzE11vS4U4t9aT7IlYkTgFOVuEfONsnWKcs9tE7RKIbmaV3u?=
 =?us-ascii?Q?AWXxbIgeAqoBTsSm+DEOA1fv8XIO5++gono3qtFq0y771NHbz67Sg4GVaotB?=
 =?us-ascii?Q?bExcjSWOpP0hJpAF8DFKr2rbt/wVsIa+MRat2eR4da2swHZu3MYNhhufpsuk?=
 =?us-ascii?Q?yVyj3nk5IwX2R86mYA/8b8ZV6j6WojQdWWEFw3U3R9wWwnf8fVcHw3UWfU17?=
 =?us-ascii?Q?QHnQzbJbzFJSQUULztyOEnuJzkPcyV9YBqWbKm/jnmi8KTaA+6ZQ5w7EEBi+?=
 =?us-ascii?Q?Z/CnaNNzpnzSOB8Fxy47R4DREklKgSKM338t8Qf3zZ1Mrp7OhsxVo/nS5vDs?=
 =?us-ascii?Q?u2eYre+qxm4Mc8xG6RRShlJ7pLaaB9bLeisFU6g97hRSa9syKKW5uHiPFdO1?=
 =?us-ascii?Q?ZOS0/VragV59Ix8nY3802UsL1jfhOCbOgvfkcKdzrM85XvmZe9w2I2VxAZej?=
 =?us-ascii?Q?31SYw/efYreSTrSz5LuTAXhx+H6Sju/lfcMVft4fafa0r8cFOvLudG1aVtDs?=
 =?us-ascii?Q?8WQ0uA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e08d4eb-65ba-433e-12b7-08db256e401e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 15:59:25.6649
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P0oryEUmFTTL5CLTIox3gYxMwqKgSxMHvEsF5Ucbp5gwUKvlK/Dt1y/opPpn3M/GtRvJUbo+1a34H0jQ6X7RcxdxVCtbdhpO0JbOD5fK0hY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5037
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 13, 2023 at 08:36:07PM -0400, Sean Anderson wrote:
> Instead of registering one interrupt handler for all four SBUS Quattro
> HMEs, let each HME register its own handler. To make this work, we don't
> handle the IRQ if none of the status bits are set. This reduces the
> complexity of the driver, and makes it easier to ensure things happen
> before/after enabling IRQs.
> 
> I'm not really sure why we request IRQs in two different places (and leave
> them running after removing the driver!). A lot of things in this driver
> seem to just be crusty, and not necessarily intentional. I'm assuming
> that's the case here as well.
> 
> This really needs to be tested by someone with an SBUS Quattro card.
> 
> Signed-off-by: Sean Anderson <seanga2@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>