From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Khadija Kamran <kamrankhadijadj@gmail.com>,
        Nathan Chancellor <nathan@kernel.org>
Cc:     Alison Schofield <alison.schofield@intel.com>,
        outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: initialize timeouts in probe only
Date:   Wed, 15 Mar 2023 17:24:23 +0100
Message-ID: <279821116.9N5E1g01tA@suse>
In-Reply-To: <20230315150656.GA2938956@dev-arch.thelio-3990X>
References: <ZA9mThZ7NyRrQAMX@khadija-virtual-machine>
 <ZBHUr7bANuhnOnIV@khadija-virtual-machine>
 <20230315150656.GA2938956@dev-arch.thelio-3990X>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On mercoled=EC 15 marzo 2023 16:06:56 CET Nathan Chancellor wrote:
> Hi Khadija,
>=20
> On Wed, Mar 15, 2023 at 07:22:39PM +0500, Khadija Kamran wrote:
> > On Wed, Mar 15, 2023 at 02:34:31PM +0100, Fabio M. De Francesco wrote:
> > > Aside from what I said and asked for with the other message of this s=
ame
> > > thread, please take note that you can build a specific module if you
> > > prefer
> > > not to re-build the whole kernel and other modules at the same time.
> > >=20
> > > I'm pretty sure that the instructions to do so are in the
> > > OutreachyFirstPatch
> > > tutorial.
> > >=20
> > > If they are not there, please let us know.
> > >=20
> > > Fabio
> >=20
> > Hey Fabio!
> >=20
> > In the Outreachy FirstPatchTutorial under the 'Compiling only part of
> > the kernel' section there are ways to compile only some part of the
> > kernel.
> >=20
> > I have tried using "make W=3D1 drivers/staging/axis-fifo/" and it says
> > 'nothing to be done for'.
>=20
> Is CONFIG_XIL_AXIS_FIFO enabled in your configuration?

@Khadija:

Maybe that you won't find CONFIG_XIL_AXIS_FIFO among the staging drivers=20
entries while using "make menuconfig" (or the other similar commands for=20
working with the configuration).=20

In that case, first enable the CONFIG_OF option if disabled.=20
CONFIG_XIL_AXIS_FIFO depends on the former.=20

=46or "CONFIG_XIL_AXIS_FIFO depends on CONFIG_OF" we mean that you can the=
=20
former if and only if the latter is already enabled.=20

Actually, CONFIG_XIL_AXIS_FIFO depends also on two other options. However y=
ou=20
shouldn't worry about those others because they are commonly enabled in mor=
e=20
than 99% of PC distributions.

> > Should I start with the steps to reproduce? :'(
>=20
> I did see a report of this same warning occurring with GCC but the
> report I commented on cane from clang/LLVM; using that toolchain may
> make it easier for you to reproduce this issue. The robot's reproduction
> instructions are fine but I think doing it manually is actually simpler.
>=20
> Ubuntu 22.04 should have a pretty modern version of clang/LLVM, which
> you can install via 'sudo apt install clang lld llvm'.
> https://apt.llvm.org is another resource.

@Nathan: Congratulations, you now have another clang/LLVM adept!
(Obviously, I'm just kidding :-))

=46abio