MIME-Version: 1.0
References: <20230315121303.3358416-1-tmricht@linux.ibm.com>
In-Reply-To: <20230315121303.3358416-1-tmricht@linux.ibm.com>
From:   Namhyung Kim <namhyung@gmail.com>
Date:   Wed, 15 Mar 2023 09:42:47 -0700
Message-ID: <CAM9d7cg8FJP+P57-reTFjp7t_YX-zS_8_txjx2EuZjmxO7EULg@mail.gmail.com>
Subject: Re: [PATCH] perf/test: Fix wrong size for perf test Setup struct perf_event_attr
To:     Thomas Richter <tmricht@linux.ibm.com>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        acme@kernel.org, robh@kernel.org, jolsa@kernel.org,
        svens@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com,
        hca@linux.ibm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

On Wed, Mar 15, 2023 at 5:15=E2=80=AFAM Thomas Richter <tmricht@linux.ibm.c=
om> wrote:
>
> The test case ./perf test 'Setup struct perf_event_attr' fails.
> On s390 this output is observed:
>
>  # ./perf test -Fvvvv 17
>  17: Setup struct perf_event_attr                                    :
>  --- start ---
>  running './tests/attr/test-stat-C0'
>  Using CPUID IBM,8561,703,T01,3.6,002f
>  .....
>  Event event:base-stat
>       fd =3D 1
>       group_fd =3D -1
>       flags =3D 0|8
>       cpu =3D *
>       type =3D 0
>       size =3D 128     <<<--- wrong, specified in file base-stat
>       config =3D 0
>       sample_period =3D 0
>       sample_type =3D 65536
>       ...
>  'PERF_TEST_ATTR=3D/tmp/tmpgw574wvg ./perf stat -o \
>         /tmp/tmpgw574wvg/perf.data -e cycles -C 0 kill >/dev/null \
>         2>&1 ret '1', expected '1'
>   loading result events
>     Event event-0-0-4
>       fd =3D 4
>       group_fd =3D -1
>       cpu =3D 0
>       pid =3D -1
>       flags =3D 8
>       type =3D 0
>       size =3D 136     <<<--- actual size used in system call
>       .....
>   compare
>     matching [event-0-0-4]
>       to [event:base-stat]
>       [cpu] 0 *
>       [flags] 8 0|8
>       [type] 0 0
>       [size] 136 128
>     ->FAIL
>     match: [event-0-0-4] matches []
>   expected size=3D136, got 128
>   FAILED './tests/attr/test-stat-C0' - match failure
>
> This mismatch is caused by
> commit 09519ec3b19e ("perf: Add perf_event_attr::config3")
> which enlarges the structure perf_event_attr by 8 bytes.
>
> Fix this by adjusting the expected value of size.
>
> Output after:
>  # ./perf test -Fvvvv 17
>  17: Setup struct perf_event_attr                                    :
>  --- start ---
>  running './tests/attr/test-stat-C0'
>  Using CPUID IBM,8561,703,T01,3.6,002f
>  ...
>   matched
>   compare
>     matching [event-0-0-4]
>       to [event:base-stat]
>       [cpu] 0 *
>       [flags] 8 0|8
>       [type] 0 0
>       [size] 136 136
>       ....
>    ->OK
>    match: [event-0-0-4] matches ['event:base-stat']
>  matched
>
> Fixes: 09519ec3b19e ("perf: Add perf_event_attr::config3")
>
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/tests/attr/base-record       | 2 +-
>  tools/perf/tests/attr/base-stat         | 2 +-
>  tools/perf/tests/attr/system-wide-dummy | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/tests/attr/base-record b/tools/perf/tests/attr/ba=
se-record
> index 3ef07a12aa14..27c21271a16c 100644
> --- a/tools/perf/tests/attr/base-record
> +++ b/tools/perf/tests/attr/base-record
> @@ -5,7 +5,7 @@ group_fd=3D-1
>  flags=3D0|8
>  cpu=3D*
>  type=3D0|1
> -size=3D128
> +size=3D136
>  config=3D0
>  sample_period=3D*
>  sample_type=3D263
> diff --git a/tools/perf/tests/attr/base-stat b/tools/perf/tests/attr/base=
-stat
> index 408164456530..a21fb65bc012 100644
> --- a/tools/perf/tests/attr/base-stat
> +++ b/tools/perf/tests/attr/base-stat
> @@ -5,7 +5,7 @@ group_fd=3D-1
>  flags=3D0|8
>  cpu=3D*
>  type=3D0
> -size=3D128
> +size=3D136
>  config=3D0
>  sample_period=3D0
>  sample_type=3D65536
> diff --git a/tools/perf/tests/attr/system-wide-dummy b/tools/perf/tests/a=
ttr/system-wide-dummy
> index 8fec06eda5f9..2f3e3eb728eb 100644
> --- a/tools/perf/tests/attr/system-wide-dummy
> +++ b/tools/perf/tests/attr/system-wide-dummy
> @@ -7,7 +7,7 @@ cpu=3D*
>  pid=3D-1
>  flags=3D8
>  type=3D1
> -size=3D128
> +size=3D136
>  config=3D9
>  sample_period=3D4000
>  sample_type=3D455
> --
> 2.39.1
>