Message-ID: <92a53663-0359-5e87-2561-340a8719521c@acm.org>
Date:   Wed, 15 Mar 2023 09:51:23 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH -next] scsi: scsi_dh_alua: fix memleak for 'qdata' in
 alua_activate()
Content-Language: en-US
To:     Yu Kuai <yukuai1@huaweicloud.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, hare@suse.de, axboe@kernel.dk,
        sconnor@purestorage.com, michael.christie@oracle.com,
        brian@purestorage.com, yukuai3@huawei.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        yi.zhang@huawei.com, yangerkun@huawei.com
References: <20230315062154.668812-1-yukuai1@huaweicloud.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20230315062154.668812-1-yukuai1@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/14/23 23:21, Yu Kuai wrote:
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 362fa631f39b..a226dc1b65d7 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -1145,10 +1145,12 @@ static int alua_activate(struct scsi_device *sdev,
>   	rcu_read_unlock();
>   	mutex_unlock(&h->init_mutex);
>   
> -	if (alua_rtpg_queue(pg, sdev, qdata, true))
> +	if (alua_rtpg_queue(pg, sdev, qdata, true)) {
>   		fn = NULL;
> -	else
> +	} else {
> +		kfree(qdata);
>   		err = SCSI_DH_DEV_OFFLINED;
> +	}
>   	kref_put(&pg->kref, release_port_group);
>   out:
>   	if (fn)

Reviewed-by: Bart Van Assche <bvanassche@acm.org>