Message-ID: <9d478a5d-a7af-ab9f-a04e-fc40a95bc861@gmail.com>
Date:   Wed, 15 Mar 2023 10:53:06 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] mm: mempool: Optimize the mempool_create_node function
Content-Language: en-US
To:     Li zeming <zeming@nfschina.com>, akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20230315191243.3289-1-zeming@nfschina.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20230315191243.3289-1-zeming@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/15/23 12:12, Li zeming wrote:
> The pool pointer variable gets the kzalloc_node function return value
> directly at definition time, which should be more concise.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>

This looks pretty useless as a change, the generated code is going to be 
the same before/after, it is also not more readable, and it is 
definitively not an optimization in the sense that optimization should 
be used as meaning: the code is more efficient after that change.
-- 
Florian