Date:   Wed, 15 Mar 2023 11:47:36 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>,
        <gregkh@linuxfoundation.org>
CC:     <outreachy@lists.linux.dev>, <martyn@welchs.me.uk>,
        <manohar.vanga@gmail.com>, <zoo868e@gmail.com>,
        <jerrykang026@gmail.com>, <cuigaosheng1@huawei.com>,
        <arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
        <linux-staging@lists.linux.dev>, <eng.mennamahmoud.mm@gmail.com>
Subject: Re: [PATCH 1/2] staging: vme_user: add space around operators
Message-ID: <641212c8d481f_253a1e29437@iweiny-mobl.notmuch>
References: <b56c7b94e59a4051373af8b5d90a0685dfc9233a.1678882204.git.eng.mennamahmoud.mm@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b56c7b94e59a4051373af8b5d90a0685dfc9233a.1678882204.git.eng.mennamahmoud.mm@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5udeOK1KMyNwrTLKmACtjRPyNUTTfAJc2Q5M3+a5aNW41ar9IQ0EF29jQOOm?=
 =?us-ascii?Q?hjc9w1iEAwsIqCxtjinkMGr9C5xPV5quAam3fuZwlOCag+LmFBDeFUDRINbM?=
 =?us-ascii?Q?F8u19k3fXUDkyHmEzdNX/j5Nr0wahsAT1pez60Rnlxn7YGVjoS3DhTfVYMN6?=
 =?us-ascii?Q?3re4Hn2eYauUNS0LidxW6ABJvz6WcUmbHZJOqw0HxeUZw2pvSmLL+4MT+JPB?=
 =?us-ascii?Q?UKxTXs+RDtWn5jJCQK0bXiYQYMMxqx/elIfWm/Ytln5lBJyqYNH1/mvNp4/G?=
 =?us-ascii?Q?94K56M7jVyMngRgTfzDrCDXDB9RHBtVwbAAzXbD9YswIHsQnPM0BXIfSuJmk?=
 =?us-ascii?Q?oyE1V45yS4FUqxhMLKONNueviNVryk1sR3TDMNnf2slfl7vbGoOzb1y9DCDV?=
 =?us-ascii?Q?XEPaj2oDyHSZP0wraJrW+M5oKHXtSjcfZYLje5OsTawpH9IJNMG4ecBm1asg?=
 =?us-ascii?Q?K7t0WsHA7V6hE6wcMNvM9Rd7a9uSs7T+oroWeN61y7aQbkiA3mgPu/29V7W+?=
 =?us-ascii?Q?qgX38dxJPe3JcQ3DKrCGMbJJyRoTHOrzuw1Ehipiio0M65NG3PcnK3c7jtD+?=
 =?us-ascii?Q?n/aLdPt9S//A+7xWD1Eqt0LKHtIOVGQgLeFTeW+1AmLH3m5umcteEOAPxHAU?=
 =?us-ascii?Q?l3d7w4YRkVHXhJemZKJ3TtrVD1LHv/BmKKxL91YRHbULMdx/6OiAzozwX0L3?=
 =?us-ascii?Q?LMKPhELo5/NXIyQuImNsPiJJtQbffLi6k6jzPOj6ePh3KZ1deoWb/X/A8ayt?=
 =?us-ascii?Q?HpZND0+HP76TGKNsqeE7ISShDaYLFnXUzg3WvU3/1ljeQoFEQANrf1QbbaPd?=
 =?us-ascii?Q?L6IN5UBdA9IlWeCdqLvzH25ie+Aw2A8ufN/JaoEm2BfQS11hJfhKcXZUXrbG?=
 =?us-ascii?Q?VS73MyhPVMtxfBmAqYPuJ/Rfz5wWR9KFM0hdK11v1+ubEDF8OvfEDbz1s5nn?=
 =?us-ascii?Q?3DsLZzljUfSKD8Ij9flVHjHEnWmpCn1GARKq7VNXfr1tezW+zg5kPBPVMgSg?=
 =?us-ascii?Q?0itDN2GF8imsDvymM4+T2KtqitVWs//ZxYpC2guukA4QcOvBZP9ZPSik49cX?=
 =?us-ascii?Q?2wVpq7VyEJepLwukxRWpSuU0GGw1Stc5kaBXYsNbzcAnD/+xoke5j62oqLLN?=
 =?us-ascii?Q?LbQ1M/H6WjLqiAZTEVEJUBKSUMxx5mWHDocLccKaCMJebbSdMdg7gQ33MEjk?=
 =?us-ascii?Q?zyhn26k/g3NZ8zzvkKlef/JnLmEMoGc/k8CDCYo/39bB8oS+N2lehWeJYaLj?=
 =?us-ascii?Q?wF29hBb76KiucMMqzKsHPzQiZ/JNDkTVI3pW+QmJYE6nu6Hnnn3iPwjpJ/dK?=
 =?us-ascii?Q?MglrocJEYsbq/FhMYWa4cuRsO1zIcZm8qIj/lVGOHli0FcMWZ/LGuQvO8Rfy?=
 =?us-ascii?Q?JaNBZSS/+cWqG+CtLZbdnP/VFOBvHBDK5F1p4vmL3mknCGgbVN7CbiFiLss8?=
 =?us-ascii?Q?IIaft7ow9xtHqiJe0dbBSa+weI/1v8SZ2TOJX5kYNMOhNnO5StzM0FdVweNw?=
 =?us-ascii?Q?eiTLi+5hUkcXgQlz9J2L5nQ3XKSyufLFXHv6i8+oLoE6BYdr0hDPcqCGd+tY?=
 =?us-ascii?Q?6aPMLOh32DGh6eXThEhp8a0dWT+H2AlY8z0suFeL?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f19267d6-cada-4075-d2b6-08db2585c0b4
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 18:47:39.9042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XKX6z3lX9M4ccEEV9KHwUFo+M4rI52uTghEwvUOnl4ie+u7LwE4TPbGU8c2esR5yIrZCUGRlqLEtcfEIuHptCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5511
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Menna Mahmoud wrote:
> add a space before and after the operator, for readability.
> 
> Reported By checkpatch script:
> 
> CHECK: spaces preferred around that '+' (ctx:VxV)
> +		image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_ATOMIC);
>  		                                            ^
> CHECK: spaces preferred around that '<<' (ctx:VxV)
> +	temp_ctl &= ~(3<<4);
>  	               ^
> CHECK: spaces preferred around that '>>' (ctx:VxV)
> +	cbar = (cbar & TSI148_CRCSR_CBAR_M)>>3;
>  	                                   ^
> CHECK: spaces preferred around that '<<' (ctx:VxV)
> +		iowrite32be(cbar<<3, bridge->base + TSI148_CBAR);

Similar comment to what Fabio made.

But I'll add some formatting comments.

It looks like you have submitted a 2 patch series which fixes all the
checkpatch errors in the vme_user driver?

Kudos for separating out the 2 patches for the 2 different types of
checkpatch errors!  And for submitting a series which fixes the entire
driver!

But you should also include a cover letter for your series.

How are you creating this series?  Are you using 'git format-patch'?
'b4'?  If not using 'b4' I strongly recommend it.[*]

Both of those tools can help with formatting a cover letter and b4 will
help keep track of multiple versions of the series as you fix things.

Ira

[*] https://git.kernel.org/pub/scm/utils/b4/b4.git