Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6ACC61DA4 for ; Wed, 15 Mar 2023 18:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232701AbjCOS7X (ORCPT ); Wed, 15 Mar 2023 14:59:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbjCOS7U (ORCPT ); Wed, 15 Mar 2023 14:59:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C7995BD5 for ; Wed, 15 Mar 2023 11:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678906706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kwq97ii9j4Uobk/QWp3tFh+rm8HJDcqt7MfCwBpcIz0=; b=WJbocRNCO4bVngRaw/Bu251/klvBAxvU0LQaqQCsJpfWWpkj/u3mELl27tHK5Yl2rt4wC2 qz26Is4BRK5FGDPUQiMCWsBKSKE/8XUkC98ZKuF0aY5DAvWeCmjyv/mFEL8dgMi4XOZPog ZX6yplNA6mj9tSeVhTyoZx6IQxB9qiQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-244-Zjt2OQuKN0-KF39f8u_sNg-1; Wed, 15 Mar 2023 14:58:24 -0400 X-MC-Unique: Zjt2OQuKN0-KF39f8u_sNg-1 Received: by mail-wm1-f71.google.com with SMTP id m30-20020a05600c3b1e00b003ed31d151ecso1105323wms.1 for ; Wed, 15 Mar 2023 11:58:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678906703; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kwq97ii9j4Uobk/QWp3tFh+rm8HJDcqt7MfCwBpcIz0=; b=LjAOLGHqEBW97kpXeFHmJXirIUdXJMKITTuRT3nfEPkAvvMyahHcAwuCbnAv1RGfBz mPvNDkshVkcgg12t/Q1Ee1kuFDP02GKTQr70IDmcHRs8wfh2R8bFtLMevjuQfRy1FDPI tMKPWTBU4O3cfTMmXFFweaLNCNTKtGnvNWAZI39YwghD5/k/32guTTh39KVVDdm7ppkC uwkx/dxivVp5vKyjJu2uZAPnlxaWPmlS0wvRshL/XVLqzUImFJWbkVXzXcwyX19cMlEm DbybRMSQrFOio2xi3n515EvZKIOEas3dWadUDNFLL+qDCU9xgOZzB+14ubchT4w28mOK BCJw== X-Gm-Message-State: AO0yUKU3vilgOOQWoIi9U4PPBrJbV+ownVD+4kZ/3Qz7zOlpDXF2hKkP o74reK6TCm+LLiUdS7xdCtijdtHa1Boe0kIFDquCfLs11jfHRU5jueTnnP20NN79fgRBUx/IDgY QJKNl2vPGHwmDPiwDqK3ZZqtp X-Received: by 2002:a05:600c:3591:b0:3e2:1dac:b071 with SMTP id p17-20020a05600c359100b003e21dacb071mr15684809wmq.13.1678906703226; Wed, 15 Mar 2023 11:58:23 -0700 (PDT) X-Google-Smtp-Source: AK7set9wHxtbJeJaGu+TUflUL+yBb+lhiGSDGexB3h7ZOMkBv9oBaMw6khZUH1IgPgUBcAEXtdGuIg== X-Received: by 2002:a05:600c:3591:b0:3e2:1dac:b071 with SMTP id p17-20020a05600c359100b003e21dacb071mr15684794wmq.13.1678906702944; Wed, 15 Mar 2023 11:58:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:2f00:2038:213d:e59f:7d44? (p200300cbc7022f002038213de59f7d44.dip0.t-ipconnect.de. [2003:cb:c702:2f00:2038:213d:e59f:7d44]) by smtp.gmail.com with ESMTPSA id k26-20020a7bc31a000000b003eb596cbc54sm2862421wmj.0.2023.03.15.11.58.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 11:58:22 -0700 (PDT) Message-ID: Date: Wed, 15 Mar 2023 19:58:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v19 01/15] splice: Clean up direct_splice_read() a bit Content-Language: en-US To: David Howells , Jens Axboe , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard References: <20230315163549.295454-1-dhowells@redhat.com> <20230315163549.295454-2-dhowells@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230315163549.295454-2-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.03.23 17:35, David Howells wrote: > Do a couple of cleanups to direct_splice_read(): > > (1) Cast to struct page **, not void *. > > (2) Simplify the calculation of the number of pages to keep/reclaim in > direct_splice_read(). > > Suggested-by: Christoph Hellwig > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > cc: Jens Axboe > cc: Al Viro > cc: David Hildenbrand > cc: John Hubbard > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb