Date:   Wed, 15 Mar 2023 12:22:27 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>,
        Julia Lawall <julia.lawall@inria.fr>
CC:     <gregkh@linuxfoundation.org>, <outreachy@lists.linux.dev>,
        <martyn@welchs.me.uk>, <manohar.vanga@gmail.com>,
        <zoo868e@gmail.com>, <jerrykang026@gmail.com>,
        <cuigaosheng1@huawei.com>, <arnd@arndb.de>,
        <linux-kernel@vger.kernel.org>, <linux-staging@lists.linux.dev>
Subject: Re: [PATCH v2 2/2] staging: vme_user: remove unnecessary blank lines
Message-ID: <64121af3e399e_253a1e294a2@iweiny-mobl.notmuch>
References: <4bdfd864b573c164df30ec738afc93b06ce0d573.1678887330.git.eng.mennamahmoud.mm@gmail.com>
 <15b80b699315993d7f0da638f805446f6dc0b480.1678887330.git.eng.mennamahmoud.mm@gmail.com>
 <dcd9b79-bbd5-f160-317b-7fdd6ca6fc64@inria.fr>
 <b37352ef-959e-d950-c0c6-32e1c7268b79@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b37352ef-959e-d950-c0c6-32e1c7268b79@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmlEaDZEcU9BOE13aktud0VGcHd6V1U0UkRKd2FQQ0dRK1lZSnhCdkdqdnlp?=
 =?utf-8?B?YnhLc0dQVWE3WWlLT0NnRGxRSmRjZ2d1UDZIQ3NsNnllSVhhT0dITkJOYjB5?=
 =?utf-8?B?S21jUVFZczFPbkdWODJVekRtQlVHSHFUYXl0YTFhTDlXWE5KVlh1elJWclFJ?=
 =?utf-8?B?RitnN2ZvaXhyS1g3TEIrTHoralJXQ1RZMHJMTVN1MWZDVGVZQWZmNGM2M1Ar?=
 =?utf-8?B?N0UyZjZhV0hBckpKWThFNE96ZTdGWklxaVo3djJqb3RTSDVqRi9lb01qOXV1?=
 =?utf-8?B?cjA0QnVWVXhWckpnaE92bXQ3ZUJHQVcrUkhYMk50TEVSamNLTHhVOHU0L29T?=
 =?utf-8?B?eDJvVHNpdDdoYWs5V2hENHRMSVRadFl6V293Q3N0RDVJU2l5UGNaWCtQVGhu?=
 =?utf-8?B?bXBJL2VkN3VPSHQyWE1zQnIrSUk2RjM5SXAwZW9TWG4weWc4OHlVKzViRWpq?=
 =?utf-8?B?N09WVGlweTZlUFNuTm1IRWZ2dUJTSUsxc2huay9WSHY2Yk5kWFhodXhENG9p?=
 =?utf-8?B?RUhtVU9hTEUwOHd5czlQWFZuU1BqZmxKMlQwdTRjQ1RFWE1TWmZpWDloZ2FL?=
 =?utf-8?B?Um5Uc0NkMlJPY0dGVVBLdSs4b0I5M3kyZWl4OXR5VFQzYVNLQ1ZYa2dmTjh2?=
 =?utf-8?B?aHdUUm9qcHRtUmlhTUVqd2EzT09kSlU4ZFdUdm1iZzUyUXlJdkE5YkVsalcw?=
 =?utf-8?B?Unh6RG5PRUhYRkp3ZllqYW4wN21RMm9lRitsN2JJaHZRckQxdDNiQzhocXJ4?=
 =?utf-8?B?c3kwTjdka0ZtWDdJKzNBaDlCYWNTaFF2cTlCeC9zV0w0dmIxeTM5dlg5ajY2?=
 =?utf-8?B?alg4Wi81OXBKbVdSOGFRQWxZUmc2QzR6TnMxb1l3RlBSbEJQZUNZdEtTQWlW?=
 =?utf-8?B?citxZ05UdEFrYzZuSUFYOTZYVmFJbWNEc0JwRklBalBNZUJlcGFCN2Fuay8w?=
 =?utf-8?B?RkxaTm5PVzl0UjZFTVN2enJOL0hhRVU2ck43N1hud1hmTTdpUUc5NC8wOCs0?=
 =?utf-8?B?Qm4xWXNvUDJNQXRRTEVCYlZuTXpXRVhHeGQvN1pBWHdWb1FYTFFLMVc2cjI3?=
 =?utf-8?B?V0Y4bkZ5dWFtMW9lUzJ4ZzNWZCs0YTR5RWZCSE14T3c1V1c2NmZuVHZWQnB4?=
 =?utf-8?B?dm1jamhERGpSL1d5cVlCUWhMazJoZkx6Y1VidW5udHQvd29uejNRQmFEc1Bi?=
 =?utf-8?B?NWd3SjdOaXVWaFRPK2ZVem5ZZ3F2d21yMm9xSUtOWGg5c0JDc3RGc1FUVTZw?=
 =?utf-8?B?QTJnVGY5bStpVE1CUVVMdmhvZnF1aWVHRWEzV2t5SmdlbkhKcFZNWGEwMDM5?=
 =?utf-8?B?WTIvZk9rWFBOTnRNODNSbEI1OGdFcG94bSs2SHRjcmptcDF0VlBnWFAyMVVM?=
 =?utf-8?B?MXlnN3dKbEFGblpHaTBPYTJNcXNJS2VjUzFGMXNTeE9SbTZsM2llYlpCWEN5?=
 =?utf-8?B?SE9XVTliT3FCWGMyUnpadzZNVG15VlRaM0JMWUVNeWhMT3FBUkV2SUxRZFlP?=
 =?utf-8?B?dW9zT2lJTlhuVThEdW9VenovVjFLSHdiaVhoLy81WTZaanlTSE5yVmlzVkgx?=
 =?utf-8?B?eHBCSjNRVG1ZMDBkamtRbElvVkFvZGV6R2RsWEp4M3I1TUkxNXVOQWd2TTR5?=
 =?utf-8?B?b1N5WTdhQTNHOE92Y0dHMnVyQkZmUXRyT2kxTzFaVi9mbE9vNHZURGdoeHh5?=
 =?utf-8?B?MWtkNjNEQ0JlK1pBMzl2MmorbUFJQkROWVRMRTROdWpTWHk2VElldTVxTWVs?=
 =?utf-8?B?MUFHQlZ1YVlkc1ZLN3VXZ0xOdFQ3ZlM5cVp0RFl0VnBRZFN3VUFCVzBqTndj?=
 =?utf-8?B?dytTUHdyZW1MWGErd29GRnUwUVlTVGVuMzFOVi9tdHRxTDAwODBnWTR1TGh0?=
 =?utf-8?B?UzZWemFkM2JKSVlmd3o1RGQralF1N2ZOYk9CSk1scno5U3lBNnFmMXdEbzVR?=
 =?utf-8?B?TG5zSTExR1hna3A4RHlBZVZIaldiQlJSY1cxSVZpUUllTkJRVTA5Tk13Z1Nv?=
 =?utf-8?B?eWJaaWd6NUtSOXpmSnVpUjh4cjRBSFVnM1lQN1dReWd1UU94MkFNam9VM0xq?=
 =?utf-8?B?czdlVVBZT2hkUFVJNm5nYmdoekovK3UyeGZ0SDNMTG9Sc1VDNExDTTBZUDlC?=
 =?utf-8?Q?gS84U9JS04/hwrcSzpZj5YAZQ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d690d6b5-79cf-478c-3128-08db258a9fc4
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 19:22:32.0612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zdYo4fIEi+1u2pNYhX2/zkat6JATFHxvAUGPrDENeH/0f/EZWsPHO1dOVASAOQafJPRx6u4vTMS6QOH1J8/f7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5552
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Menna Mahmoud wrote:
> 
> On ١٥‏/٣‏/٢٠٢٣ ١٥:٤٥, Julia Lawall wrote:
> >
> > On Wed, 15 Mar 2023, Menna Mahmoud wrote:
> >
> >> remove unnecessary blank lines before a close brace
> >> as reported by checkpatch script
> >>
> >> "CHECK: Blank lines aren't necessary before a close brace '}'"
> >>
> >> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
> >> ----
> > This should be three -s, not four.
> >
> >> changes in v2:
> >> 	edit commit message
> >> ---
> > -s aren't needed here.
> >
> > julia
> 
> 
> I see, Thanks Julia

I agree with Julia that they are not needed here but they also don't hurt
anything.  git format-patch (or b4 etc) add another '---' to the commit
message automatically.

https://lore.kernel.org/all/20221216-cxl-ev-log-v7-2-2316a5c8f7d8@intel.com/

So assuming you had something like ...

<quote>
----
changes in v2:
	edit commit message
</quote>

... in the patch commit message.  That is perfectly ok and I would not
worry about the tools adding a second '---'.

But as Julia said you must make sure to have only 3 '-'s.  :-D

Ira