MIME-Version: 1.0
References: <20230307125358.772287565@linutronix.de> <20230307125538.818862491@linutronix.de>
 <20230315133659.4d608eb0@kernel.org>
In-Reply-To: <20230315133659.4d608eb0@kernel.org>
From:   Eric Dumazet <edumazet@google.com>
Date:   Wed, 15 Mar 2023 13:47:39 -0700
Message-ID: <CANn89iJUE3De9t3Vf-H6K+DAscEM98VZU4FaVCEOhE0ULUz9hQ@mail.gmail.com>
Subject: Re: [patch V2 1/4] net: dst: Prevent false sharing vs. dst_entry::__refcnt
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     David Ahern <dsahern@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 15, 2023 at 1:37=E2=80=AFPM Jakub Kicinski <kuba@kernel.org> wr=
ote:
>
> On Tue,  7 Mar 2023 13:57:42 +0100 (CET) Thomas Gleixner wrote:
> > Move the rt[6i]_uncached[_list] members out of struct rtable and struct
> > rt6_info into struct dst_entry to provide padding and move the lwtstate
> > member after that so it ends up in the same cache line.
>
> Eric, David, looks reasonable?

Yes indeed, thanks for the heads up

Reviewed-by: Eric Dumazet <edumazet@google.com>