Date:   Wed, 15 Mar 2023 14:20:48 -0700
From:   John Fastabend <john.fastabend@gmail.com>
To:     Greg Thelen <gthelen@google.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Ian Rogers <irogers@google.com>
Cc:     bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        Greg Thelen <gthelen@google.com>
Message-ID: <641236b06baa1_63dce208a1@john.notmuch>
In-Reply-To: <20230315054932.1639169-1-gthelen@google.com>
References: <20230315054932.1639169-1-gthelen@google.com>
Subject: RE: [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Greg Thelen wrote:
> After building the kernel I see:
>   $ git status -s
>   ?? tools/bpf/resolve_btfids/libbpf/
> 
> Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> started copying header files into
> tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
> not covered by higher level wildcard gitignores.
> 
> gitignore the entire libsubcmd directory. It's created as part of build
> and removed by clean.
> 
> Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> Signed-off-by: Greg Thelen <gthelen@google.com>
> ---
>  tools/bpf/resolve_btfids/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> index 16913fffc985..52d5e9721d92 100644
> --- a/tools/bpf/resolve_btfids/.gitignore
> +++ b/tools/bpf/resolve_btfids/.gitignore
> @@ -1,3 +1,4 @@
>  /fixdep
>  /resolve_btfids
>  /libbpf/
> +/libsubcmd/
> -- 
> 2.40.0.rc1.284.g88254d51c5-goog
> 

Thanks.

Acked-by: John Fastabend <john.fastabend@gmail.com>