Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Wed, 15 Mar 2023 14:49:45 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Holger Kiehl <Holger.Kiehl@dwd.de>
Cc:     Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: (nct6775) add Asus Pro A520M-C II/CSM
Message-ID: <f8e1c010-c11e-4cd4-a2f8-a074b6983e0a@roeck-us.net>
References: <868bdc4f-9d45-475c-963e-f5232a8b95@praktifix.dwd.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <868bdc4f-9d45-475c-963e-f5232a8b95@praktifix.dwd.de>
Precedence: bulk

On Mon, Mar 13, 2023 at 01:10:31PM +0000, Holger Kiehl wrote:
> An NCT6798D chip is now detected:
> 
>    dmesg|grep nct6775
>    [   23.765392] nct6775: Found NCT6798D or compatible chip at 0x2e:0x290
> 
> And sensors now shows:
> 
>    nct6798-isa-0290
>    Adapter: ISA adapter
>    in0:                      312.00 mV (min =  +0.00 V, max =  +1.74 V)
>    in1:                        1.02 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in2:                        3.42 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in3:                        3.38 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in4:                        1.03 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in5:                        1.02 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in6:                      200.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in7:                        3.42 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in8:                        3.28 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in9:                      920.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in10:                     512.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in11:                     504.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in12:                       1.03 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in13:                     256.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
>    in14:                       1.47 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
>    fan1:                        0 RPM  (min =    0 RPM)
>    fan2:                        0 RPM  (min =    0 RPM)
>    fan3:                      355 RPM  (min =    0 RPM)
>    fan7:                        0 RPM  (min =    0 RPM)
>    SYSTIN:                    +25.0?C  (high = +80.0?C, hyst = +75.0?C)  sensor = thermistor
>    CPUTIN:                    +26.5?C  (high = +80.0?C, hyst = +75.0?C)  sensor = thermistor
>    AUXTIN0:                   +97.0?C    sensor = thermistor
>    AUXTIN1:                   +25.0?C    sensor = thermistor
>    AUXTIN2:                   +25.0?C    sensor = thermistor
>    AUXTIN3:                    +1.0?C    sensor = thermistor
>    PECI Agent 0 Calibration:  +26.0?C
>    PCH_CHIP_CPU_MAX_TEMP:      +0.0?C
>    PCH_CHIP_TEMP:              +0.0?C
>    PCH_CPU_TEMP:               +0.0?C
>    TSI0_TEMP:                 +27.9?C
>    intrusion0:               ALARM
>    intrusion1:               OK
>    beep_enable:              disabled
> 
> Signed-off-by: Holger Kiehl <holger.kiehl@dwd.de>
> Tested-by: Holger Kiehl <holger.kiehl@dwd.de>

Applied. In the future, please watch out for:

CHECK: From:/Signed-off-by: email comments mismatch: 'From: Holger Kiehl <Holger.Kiehl@dwd.de>' != 'Signed-off-by: Holger Kiehl <holger.kiehl@dwd.de>'

Little discrepancies like this just make my life harder.

Guenter

> 
> diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
> index 76c6b564d7fc..1e6abfc7974d 100644
> --- a/drivers/hwmon/nct6775-platform.c
> +++ b/drivers/hwmon/nct6775-platform.c
> @@ -1052,6 +1052,7 @@ static int __init nct6775_find(int sioaddr, struct nct6775_sio_data *sio_data)
>  static struct platform_device *pdev[2];
>  
>  static const char * const asus_wmi_boards[] = {
> +	"Pro A520M-C II",
>  	"PRO H410T",
>  	"ProArt B550-CREATOR",
>  	"ProArt X570-CREATOR WIFI",