From:   Kazuki <kazukih0205@gmail.com>
Date:   Thu, 16 Mar 2023 07:07:22 +0900
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Sudeep Holla <sudeep.holla@arm.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Hector Martin <marcan@marcan.st>,
        Sven Peter <sven@svenpeter.dev>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] PM: s2idle: Don't allow s2idle when cpuidle isn't
 supported
Message-ID: <20230315220722.cyw4smvxlb5c5got@kazuki-mac>
References: <20230214215003.70683-1-kazukih0205@gmail.com>
 <CAJZ5v0gVi3U2K-Sj-W0QtBbbEw+HOd3FDSAyL-ugbhuxLeLZUA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJZ5v0gVi3U2K-Sj-W0QtBbbEw+HOd3FDSAyL-ugbhuxLeLZUA@mail.gmail.com>
Precedence: bulk

On Tue, Feb 21, 2023 at 04:40:01PM +0100, Rafael J. Wysocki wrote:
> On Tue, Feb 14, 2023 at 11:04 PM Kazuki Hashimoto <kazukih0205@gmail.com> wrote:
> >
> > s2idle isn't supported on platforms that don't support cpuidle as of
> > 31a3409065d1 ("cpuidle / sleep: Do sanity checks in cpuidle_enter_freeze()
> > too"), so update the suspend framework to reflect this in order to avoid
> > breakages.
> 
Hello, apologies for the late reply.
> Hmm.  Doesn't the cpuidle_not_available() check in cpuidle_idle_call()
> trigger then?
> 
> The commit mentioned above hasn't changed that AFAICS.
Yes it does, but there's nothing in enter_state() that's preventing the
system from entering s2idle. Both the suspend and cpuidle subsystems
need to be aware that the system is entering s2idle, otherwise it'll
result in breakges.

Thanks,
Kazuki