From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Arun Ramadoss <arun.ramadoss@microchip.com>,
        Russell King <linux@armlinux.org.uk>,
        Marek Vasut <marex@denx.de>, linux-kernel@vger.kernel.org
Subject: [PATCH v2 net] net: dsa: microchip: fix RGMII delay configuration on KSZ8765/KSZ8794/KSZ8795
Date:   Thu, 16 Mar 2023 01:19:16 +0200
Message-Id: <20230315231916.2998480-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Vh+Q5AjDRQedt3w/zqk9KJI11uRvDsC9qmepwqj+RPoG8ME3t9IAPdNq17KX?=
 =?us-ascii?Q?M76c4WHyMsCBfQjph2m/wPHJZdMrlMgRQl2zM7mkMK6x+4uISmE3NDWb2o1n?=
 =?us-ascii?Q?96jRomTB1HdC2YriN/GAgjvUAZKaA+Df+SoG1uBdFw4jA5FmB1f2icZRnJAS?=
 =?us-ascii?Q?Gp6QUUK5AZYGZ111KKZvtDVTghqP6F6S1B+NW6qaDUDG/1gvlP/jNxGjqUxY?=
 =?us-ascii?Q?hfRq/ptBRUSCiKADkMgB+AFdGaiRvMBnQ6w9kKtzw+3G3vQxsFIhCWHaZ/Mp?=
 =?us-ascii?Q?jKKzxGd/kj81fkNcHe+oBbNgnEOr2DXqVvBJbt43t+XDbDNQUYpo/v7pL/CX?=
 =?us-ascii?Q?IAvUepLdNJkzW8OvVPHZRVtJAPxJ8XnI/MP7X2+8gvrrMFb8zJV3bYADM02O?=
 =?us-ascii?Q?42+eNYNURy8NwhJPW7NDnvMpzm6wtIzFHYUBIjjHbX7JYdWTKMC8aopmA/9S?=
 =?us-ascii?Q?7DXN+CBCxG9U8QpQIqJZW8JO15GHE87fJFhIfGTipUvbCPpKBpDVl87SfFvd?=
 =?us-ascii?Q?P/ue3OytrAXTuUfSGxUVnm+DMtU41XlH8D10TDYhc6QnF/LP5uYGUReDuYV9?=
 =?us-ascii?Q?oqcuVLeqSyvKZkbjHza31+U2SVUcFKfUH7NLltwF//uNKWAOgEPwEpOGBiM4?=
 =?us-ascii?Q?YlrTIxp/g/ystXAu2AGckHkFWhkEzDqBSSicV1LR41Ru+76pM16rpRr4odwO?=
 =?us-ascii?Q?4ynbQ4DprbtLzEl9FOG5GQhPMtdsFElnI90pVM/oQhlDqdvAT3mlmsTcvtnH?=
 =?us-ascii?Q?c8hr8yEdqvEi9FUWhTDeMU+ZMYMZyVS7QfAu740BmGCWceTs67MmwCiC2ZGw?=
 =?us-ascii?Q?VN/ZRG4w2CUNe6k1GFxRVpn2csBUf4LuOpryhgyW+3oCNM4C9uBBUB1041lB?=
 =?us-ascii?Q?PP90xHGKrpuElmMUf5f/A0PgPuWFJORDfZUIdPQNW2yyya7tooP0JMRYeKbk?=
 =?us-ascii?Q?BQyb9m1Sw9OKnRAjepMBedzJ7aykdkv3yzWDbq107qp2wYY0dRtNzRrbAWUi?=
 =?us-ascii?Q?vtfO1V+WgOJ2Zb7CLpndEu4MzuFfLZDVuTiTjLhKrLoqKc9tn3ch1iYLui40?=
 =?us-ascii?Q?C957Up+KY+MUyjlvJyQrzsjaaknFUVZFmtir1fDQI2ERuU1ATKh+QSl4yKLj?=
 =?us-ascii?Q?RulY4qYfEJ+kWlzqPdRvo4Nexb57t+tU056xrcWEkVbBElkokK3Nsgp1bN/I?=
 =?us-ascii?Q?gSw3HcP2u1xRyvmVe0pZO16/yaqxT5gL4pKgZPhKiziWFpXzMrfy9cSloehS?=
 =?us-ascii?Q?frafxWAUd5bxpSg0ilyzWPuas7kk/bD8MbPDBCWwn6whGYjPwwF4vo7gBVHf?=
 =?us-ascii?Q?17E0MY6C9jOOFtgSQTVBkJOhmuNea9Fm5OK4deL4L4bMI3C5CnPDFv41YnCl?=
 =?us-ascii?Q?yYsQjsSejAKrrpIDcPS6Mwtc7dYD69coFWtNNvv9BR/9QG4qPG4dLkc8mO9s?=
 =?us-ascii?Q?t1FXSy4obQcGAYB9W0ck8r6XZFfZvCx+h2cSjPiv1yPk+johLYq9Wu8YttkQ?=
 =?us-ascii?Q?6hmQmJLPzh5uZEaSsDBcbEeYnvfcDDoPflIbLj7b/0SVbkB6QkSt8s45Pux5?=
 =?us-ascii?Q?/quK4c/r4sfEfSlYqXru3E4p5UUhQDQZVsMNa97YmivDvpDdEE8qYmj/6u4Q?=
 =?us-ascii?Q?zA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5864f415-8e5e-44d8-e534-08db25abb8e2
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 23:19:27.6757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n0XTZ7NzZ0xsr5XqPtwREkncUs+C/YV2++RRd54Td8Jo6j+vtJBS7Ksqv3G1RRcR/sIdrZl4GWxPB1v8fqkyRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8228
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Marek Vasut <marex@denx.de>

The blamed commit has replaced a ksz_write8() call to address
REG_PORT_5_CTRL_6 (0x56) with a ksz_set_xmii() -> ksz_pwrite8() call to
regs[P_XMII_CTRL_1], which is also defined as 0x56 for ksz8795_regs[].

The trouble is that, when compared to ksz_write8(), ksz_pwrite8() also
adjusts the register offset with the port base address. So in reality,
ksz_pwrite8(offset=0x56) accesses register 0x56 + 0x50 = 0xa6, which in
this switch appears to be unmapped, and the RGMII delay configuration on
the CPU port does nothing.

So if the switch wasn't fine with the RGMII delay configuration done
through pin strapping and relied on Linux to apply a different one in
order to pass traffic, this is now broken.

Using the offset translation logic imposed by ksz_pwrite8(), the correct
value for regs[P_XMII_CTRL_1] should have been 0x6 on ksz8795_regs[], in
order to really end up accessing register 0x56.

Static code analysis shows that, despite there being multiple other
accesses to regs[P_XMII_CTRL_1] in this driver, the only code path that
is applicable to ksz8795_regs[] and ksz8_dev_ops is ksz_set_xmii().
Therefore, the problem is isolated to RGMII delays.

In its current form, ksz8795_regs[] contains the same value for
P_XMII_CTRL_0 and for P_XMII_CTRL_1, and this raises valid suspicions
that writes made by the driver to regs[P_XMII_CTRL_0] might overwrite
writes made to regs[P_XMII_CTRL_1] or vice versa.

Again, static analysis shows that the only accesses to P_XMII_CTRL_0
from the driver are made from code paths which are not reachable with
ksz8_dev_ops. So the accesses made by ksz_set_xmii() are safe for this
switch family.

[ vladimiroltean: rewrote commit message ]

Fixes: c476bede4b0f ("net: dsa: microchip: ksz8795: use common xmii function")
Signed-off-by: Marek Vasut <marex@denx.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
---
v1->v2: rewrite commit message

v1 at:
https://patchwork.kernel.org/project/netdevbpf/patch/20230222031738.189025-1-marex@denx.de/

 drivers/net/dsa/microchip/ksz_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 5a7ce2aede68..50fd548c72d8 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -315,7 +315,7 @@ static const u16 ksz8795_regs[] = {
 	[S_BROADCAST_CTRL]		= 0x06,
 	[S_MULTICAST_CTRL]		= 0x04,
 	[P_XMII_CTRL_0]			= 0x06,
-	[P_XMII_CTRL_1]			= 0x56,
+	[P_XMII_CTRL_1]			= 0x06,
 };
 
 static const u32 ksz8795_masks[] = {
-- 
2.34.1