Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB24C7618B for ; Wed, 15 Mar 2023 23:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233272AbjCOXeE (ORCPT ); Wed, 15 Mar 2023 19:34:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233137AbjCOXdW (ORCPT ); Wed, 15 Mar 2023 19:33:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0F0AA54C9; Wed, 15 Mar 2023 16:32:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BED661EAD; Wed, 15 Mar 2023 23:32:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6495FC433D2; Wed, 15 Mar 2023 23:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678923156; bh=+YAjggYPMIMFzS2s0i4vOJVcRpRIRhcFzyxIXJgll7I=; h=From:To:Subject:Date:In-Reply-To:References:From; b=GkENUOjTwYq1fl253mizZwLvqpNVvkFJdwukGX1kn/Dg22iwbuzXONArNJgMkNaiV OkxkoriJP9Kr+IoPFCHZIloqUh6lYqmu/vCUrpJPIpbNv8dsgpOoiIXB2iOGZ5BRL1 RXCCX/PCfZMCxu/M8LaIcjcVRKrUeljpwdGpMRYbh4c7JLeS3WvwT+eRP6utSvsAIy wg01aoRWXzUrCcWlksUFISCiDm9ZN/uiPupzoPBS/Z8SUa1KlgO5+vXuELZdh6VY4X wyu0PdzFqLRl1pennL/6SiZfu1onJ5uc2+1A01IqysicLyIT1/9s0qAvzr+MYXtwaX 3FqcNwRNnSTpw== From: Bjorn Andersson To: Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross Subject: Re: [PATCH] arm64: dts: qcom: sm8550: fix LPASS pinctrl slew base address Date: Wed, 15 Mar 2023 16:35:07 -0700 Message-Id: <167892332561.4030021.8220167893365746546.b4-ty@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230302154724.856062-1-krzysztof.kozlowski@linaro.org> References: <20230302154724.856062-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Mar 2023 16:47:24 +0100, Krzysztof Kozlowski wrote: > The second LPASS pin controller IO address is supposed to be the MCC > range which contains the slew rate registers. The Linux driver then > accesses slew rate register with hard-coded offset (0xa000). However > the DTS contained the address of slew rate register as the second IO > address, thus any reads were effectively pass the memory space and lead > to "Internal error: synchronous external aborts" when applying pin > configuration. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sm8550: fix LPASS pinctrl slew base address commit: a5982b3971007161b423b39aa843bdb6713a9d44 Best regards, -- Bjorn Andersson