IronPort-SDR: JoktVlhxwupNc9fRBT3hCiMviyLWu9vurEsPMgXhzwkg/o+FM3CoVJjEUtK7wgzBGEGkD8XekP
 V6Dx7YJdXLms6Lw4iUn4U5r92B9rqoGQyqPua5OC7zoajJ815U13GKqNYzQ7/UZU/LMudGRosy
 c3FjG9VJMb5ktn1EJPp4dvIyDSnfJoZqP9yafbvYMvyXdIUgj+8VH1/9dmvT61fROPemOpwfSu
 fHl3X+lzGin+GtdE//PJciZafAGmfxUbXtoM5pY6tOQxTvBXUmmXGMQ7dHZ+IWdpPxlrdbepgv
 96M=
IronPort-SDR: yLEGJyRGVPln3bQQB7S6M65K9xYCTTJo6a4d6iuDBbKxo9HBdJ8HzP92gPCJJWwgKkHlciUGVP
 /Wn/hdtqg/pSzPmYeqRNenUdlSnFKCnmzu5S9Ei45+wDOwDmjTjb4899WNq4QCZDCxvPxT9byf
 87ZpXEUOwd4wRkpE3smTpl7d7LxhtGXGyqgDydUZ7ffUPI+h9dtqn6vlNC4nz4RUd9gdzUZfmd
 R204tDjYBaPIU5rETK59p631Smc/krviBvGhgEOOZLkYGjfPOF7P6ruLXP10oV72800Mx22P1Z
 DnY=
WDCIronportException: Internal
Message-ID: <9a1c49b0-2271-53c7-7f48-039f83d39e82@opensource.wdc.com>
Date:   Thu, 16 Mar 2023 08:57:40 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH v3 02/38] ata: add HAS_IOPORT dependencies
Content-Language: en-US
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Niklas Schnelle <schnelle@linux.ibm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-pci@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
        linux-ide@vger.kernel.org
References: <20230314121216.413434-1-schnelle@linux.ibm.com>
 <20230314121216.413434-3-schnelle@linux.ibm.com>
 <CAMuHMdVry2YViJ5oFgo9i+uStWbhy7mXKWdWvCX=qgAu1-_Y1w@mail.gmail.com>
 <c7315ca2-3ebf-7f3b-da64-9a74a995b0ae@opensource.wdc.com>
 <CAMuHMdVajEYsw8HrKw0GwV+09gbtkhjVMuKZ6RSBvq6got=jAg@mail.gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <CAMuHMdVajEYsw8HrKw0GwV+09gbtkhjVMuKZ6RSBvq6got=jAg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 2023/03/15 20:36, Geert Uytterhoeven wrote:
> Hi Damien,
>=20
> On Wed, Mar 15, 2023 at 10:12=E2=80=AFAM Damien Le Moal
> <damien.lemoal@opensource.wdc.com> wrote:
>> On 3/15/23 17:39, Geert Uytterhoeven wrote:
>>> On Tue, Mar 14, 2023 at 1:12=E2=80=AFPM Niklas Schnelle <schnelle@lin=
ux.ibm.com> wrote:
>>>> In a future patch HAS_IOPORT=3Dn will result in inb()/outb() and fri=
ends
>>>> not being declared. We thus need to add HAS_IOPORT as dependency for
>>>> those drivers using them.
>>>>
>>>> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
>>>> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
>>>
>>> Thanks for your patch!
>>>
>>>> --- a/drivers/ata/Kconfig
>>>> +++ b/drivers/ata/Kconfig
>>>> @@ -342,6 +342,7 @@ endif # HAS_DMA
>>>>
>>>>  config ATA_SFF
>>>>         bool "ATA SFF support (for legacy IDE and PATA)"
>>>> +       depends on HAS_IOPORT
>>>>         default y
>>>>         help
>>>>           This option adds support for ATA controllers with SFF
>>>
>>> ATA_SFF is a dependency for lots of (S)ATA drivers.
>>> (at least) The following don't use I/O port access:
>>>
>>>     CONFIG_SATA_RCAR (arm/arm64)
>>>     CONFIG_PATA_FALCON (m68k/atari and m68k/q40)
>>>     CONFIG_PATA_GAYLE (m68k/amiga)
>>>     CONFIG_PATA_BUDDHA (m68k/amiga)
>>>
>>> (at least) The following can use either MMIO or I/O port accesses:
>>>
>>>     CONFIG_PATA_PLATFORM (m68k/mac)
>>
>> But for these arch/platforms, would there be any reason to not have HA=
S_IOPORT ?
>> It is supported right now, so we should have HAS_IOPORT for them.
>=20
> That's the point: on Amiga and Atari, HAS_IOPORT is optional, and
> not related to IDE support. On Mac, it is never present.

Ah. OK. I see now. So indeed, applying the dependency on the entire ATA_S=
FF
group of drivers is very coarse.

Niklas,

Can you change this to apply the dependency per driver ?


--=20
Damien Le Moal
Western Digital Research