Message-ID: <5c160cba-4104-996f-04bc-df2a59acf7ea@intel.com>
Date:   Wed, 15 Mar 2023 16:59:38 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH v2 1/9] selftests/resctrl: Return NULL if
 malloc_and_init_memory() did not alloc mem
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        Babu Moger <babu.moger@amd.com>
References: <20230215130605.31583-1-ilpo.jarvinen@linux.intel.com>
 <20230215130605.31583-2-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230215130605.31583-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFVGMUREUFd1MlVHUkEwWDdNZzJDcDVBU2wrYXlkcGVsOWRQN2h2MC95Ni9S?=
 =?utf-8?B?VU1xUGpWTUhHWnpiWnJseGlmZmRNT1VmR2JjY3RZTEU5SmtZa3FYbFYxZTBL?=
 =?utf-8?B?bXVpdEdCalZia2xEWTlMWUJ6cWVzcXlQb3VDZ1ljcjkxY0llWmUvTzB0cDFx?=
 =?utf-8?B?bk9WajlZSHVVbVd5Yzg1bWdicjdhRm9URmNoYVVhWDl0ME5PbHZPckxOWUg2?=
 =?utf-8?B?QzltVm1YRnZaSnE1ajVZL3dwbkpKRzJlMUs2M1I2RHUvMXFHN3dTenFJNWl2?=
 =?utf-8?B?RHJhSVZTNHFuR1UxRWlya2htNTY4RTRBaVk0QWVCbEZqV29ya3o3VDdETXhl?=
 =?utf-8?B?RExYRGFpOTZhU3lJbHdOYXhzd0tnRlN2OGd3L3FMVVhzR2xTeFV1d0QyRUlI?=
 =?utf-8?B?SnUyMlRFNXQwd2hJSHB2ZnVSayt2MzBESDJIK2ZmWGx2Y3lWMFdlbnFWZzdQ?=
 =?utf-8?B?ZmJCUDN5MXV2ZTRFR1hWUVVUTWlyQjBPZWxJcXY0YXVBWjFoRFpDLzdWY2dR?=
 =?utf-8?B?Tk1UT25PQUYxbk9jVTg3UWh3L2pHY211c1NaVk42aDlTb0RoVWZ2c1dWWHA4?=
 =?utf-8?B?dWNON3I4ZkpCOHhMbXRLajJEc09FWWd0ZHM0QXlOdUxncWhLTC9UdEJJOE80?=
 =?utf-8?B?TDk0SXcveDNJOXRSak9CV1FjTmVVcFh1ai9sUWF0RjN3SGZQL1hxQ0k4QlV0?=
 =?utf-8?B?Qm1GWWp4RWIwcGNwemc4dmxxdUFEeG1nalVJMzczbEJNUHNCRkl6Vk5mSTUx?=
 =?utf-8?B?TVJ0QUNWVW5qVDdmMms0eGlIYnV5YUlEWGl0aUVwMkpsdmFQWEhGdWl6TW91?=
 =?utf-8?B?aGt1K0IzeittSG5HcVE5VWNPU2Y2dlVvdEtqQ1BoNnFWN0plUWFNaytjNWFW?=
 =?utf-8?B?bEN1RlV0N1d4YWFEYUdjU1lRVVdTYTVHdmNtV2ZUWForWFFKVzRwd2hFQVg1?=
 =?utf-8?B?aFV4UWE1MGt5dFF4ZkZnUTVMWWw2dnFOV3V0N3pLZ2VoQXpYQ0xxbXFSM0Fs?=
 =?utf-8?B?SFdSMjRMcjN6WEhhZjdieUMxVU1kSkg0RW4rODNsUzlIbEJDRjZxT1FiYlp3?=
 =?utf-8?B?RGhuWWJteVphTTFRTWJlbkNzQ0ZidEhvU1JZVjBQdEZJOEdjQjhDeFMwaGQ5?=
 =?utf-8?B?RFhJakprbDJsOWVmTWROcHFYUi8xYTREeUdWWkxkZVhpU2Q2L3B1M3pkc2sy?=
 =?utf-8?B?OHh5cGNDeGJDRFMrUHhINGQ4MGl2bVd2TXoxOC8yTDhENzJMdUVWN3BjMVZE?=
 =?utf-8?B?dGVKT1U2K2pZS0VMNXJWQ2wxOUphVU5xQU85V3RzdU9RQzNmRXh4c0J5VjdG?=
 =?utf-8?B?TjErMTVyUG9nK0xjNUVrUU9Hb0trNldYcWJNK2ZYUW1MaWNuRTl1NHhSSTVa?=
 =?utf-8?B?YnNhTExvc01iQkxYeEtpaGFUWlhKenlLNjFtYUllOGhnNEZ6SzVFdlBPS000?=
 =?utf-8?B?OXo5NjR1TWp5azQ2Sm1UOUJMUVdPOEhRVXBYWVJPbUZBeFVpazliWHZ4czVx?=
 =?utf-8?B?REVzSDlONUh6cnJlMzdWblRFak54U2FLL1FOWHloaGROSHBiS012UHV4bzQ4?=
 =?utf-8?B?S3FjRlI0dnRiRmxPcDVSYy92RXMyaC9xc3VKWVBNMExIWkRwanZRc0dxMW1J?=
 =?utf-8?B?K29jZ281cjdiV25LOVl5cEtnWEFSM1ZMR3RWLzAwa3d3YzR4M2lOUjZFdCtX?=
 =?utf-8?B?N1dHRERObXRGYXhWWEFnc3R3WktWQ1hUcnFnbEs1RzJYMHlQb2liL2tMN1ZK?=
 =?utf-8?B?am1lTVo0YTBLQkkrazNoaS9RZmIveERydDVDRmY5TmZuZFFIMXRlZCtldlVY?=
 =?utf-8?B?TnFETzJRbHRzRElMTU1MaDNBVTVGazlJZUxRRUVVcXNRMmQ5VnZJYi91Mmcz?=
 =?utf-8?B?a3lIVC9RVGEvVTBySjlpVFBnKyt0OUpuUVA3WEcwOGw5ZmFpSUFxVDV1R3A1?=
 =?utf-8?B?WXF6Mk5FUmNmNUpFWUoycy9jazV0ZDV5VERnTG1RQVpnY051dFR6aG1vRG1V?=
 =?utf-8?B?UTFLNjRKQzFrODZnditxS3NhQnl6UjVWMEVJQVE5L0VCRUsrRmMvOFNiU0Zn?=
 =?utf-8?B?azFCTllaTW9zakJCc2N3NXovUHpqa0dJeHRkL0tCTEQ3RjMrejV2OG15dVVr?=
 =?utf-8?B?em1yTWFpbHd2WWJvTThhZEUvNUVOb3RCcEdGd1p5NGxRN0YvVnlvN0hiemRu?=
 =?utf-8?B?a0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 57feb5b0-ceee-4349-2049-08db25b1571b
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 23:59:40.6235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hx2cBC6HTusZh5Mrkv6KRQE1e27MC8lsBRSRgiIxIkSeKTzWvHJiVMkcDxHRXp8wd2Ye2KdroWDXOJcCp0zlVdm5qsRGe1PJrrVeJk6pTPM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7083
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 2/15/2023 5:05 AM, Ilpo Järvinen wrote:
> malloc_and_init_memory() in fill_buf isn't checking if memalign()
> successfully allocated memory or not before accessing the memory.
> 
> Check the return value of memalign() and return NULL if allocating
> aligned memory fails.
> 
> Fixes: a2561b12fe39 ("selftests/resctrl: Add built in benchmark")
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette