Message-ID: <dd0b7a91-14b4-8ecb-e62a-7deb966072e2@intel.com>
Date:   Wed, 15 Mar 2023 17:01:41 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH v2 2/9] selftests/resctrl: Move ->setup() call outside of
 test specific branches
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
References: <20230215130605.31583-1-ilpo.jarvinen@linux.intel.com>
 <20230215130605.31583-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230215130605.31583-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1RxeW14VnYzWjlYT1pIelNITkVOUFBCeWt6UjM1alBIUGpNd09McEFyWXA2?=
 =?utf-8?B?QTZjc2NTRjJrS293ZmNybUNkTU5QNEhIcjVTWlVjM2ZGZ2FDQ0t3Y1NhOHB1?=
 =?utf-8?B?c1hXZUNXYnBkazU0TGRrKzVvcmsxSDQ4SjhjRmVGQXRvV1RwdzBwWFQrMTB3?=
 =?utf-8?B?VEZHc0dNS0ZiR0JqbUx6YnNsMm5QSTRoTzU4cDZSNjJKWDc5N2hhdkNpaVFz?=
 =?utf-8?B?QlBQeW1Oa2c3cDNKTWVXaTVxUENDbUhnaEIxcFdwKy9OVUpSM21UVCtwc21u?=
 =?utf-8?B?Y1VjMm1oZjh3aTNLT0tyUzhoQnYvL2dnNHBORFgzUW54Z0VIdXVoNzZVVVh1?=
 =?utf-8?B?MjFRZEFic3E0U0NocjVCNFk1SjczaVA4MHQxSDdEVEZYZTBpU1Z6MW9Jc3BS?=
 =?utf-8?B?amFGMWlkbk9GQzY0Ly9CbjFaYnljajFiRzlDYmtmckp3eVpNK0IvczhucjdU?=
 =?utf-8?B?NFhRZTk4a2xvY2JQWVAxZFFJSVVYSFRJMXJUNlpaY0d4TW14cU1VSSt0VUxX?=
 =?utf-8?B?SFRPbHA1NHhOT1RHYk41RzBSOTJ0ZFF5TTEyeFQ5M2pFVTQxSHJXcnQrTTg1?=
 =?utf-8?B?NkJRUlVWUXkyb2p1amNubStUSGJjV0FrSHpjcXlkUUV1aXVCUHRJYUZzQUs3?=
 =?utf-8?B?cXRkc2ZnT0RrQi91WlV2ODR1c01nOXZXc1lTbjVpUzhsYi9MUkpJaUJ4R2NR?=
 =?utf-8?B?VG8xZ0grQVgxT1FEekVqV0d3VmZxS2ZXUjFuaXdJeG9sUi9BcFVqZkJXWXRx?=
 =?utf-8?B?M0M3ZFFyM09kSkRrODhNY1VlQXIvMXFmcjJvWXFhZ3pES3ZVQmdwZndtRzJW?=
 =?utf-8?B?K2xQb3JZZmQ5Z0JPRVhYQ3dBZmw4S1hmc0VNTFdlUGc5SFc1Rk9hdmVkWUZS?=
 =?utf-8?B?VXZZRW9EZEVvcHVJQ3ltMzJQM1RpN29kVXl3b1hlaE5lWkNPbCtZSTZtMmMx?=
 =?utf-8?B?YWZRR282U1B4L3BNMHBmU1FFRkNZZ2RoRXFmeitTMU5sUHg0VE9UN0haeDJ2?=
 =?utf-8?B?NzB1Tzc2VzRWQXVJMUxucjNURmIzN2Erejlsb3IxNE9SWElmTTkyWG9hUzNV?=
 =?utf-8?B?UmxSOUVqcmN3NWovdVdteEk5b2NXeHFPbklseFlvc3o3TXFTamFPUnZNMng0?=
 =?utf-8?B?T0d0cWNDZHRIbHh6dDRFeU1LbzBIYXRqNm5sUmlsQVhYTDlTVzIxVHBIVXNr?=
 =?utf-8?B?eExTUWtiTnFtY2VPTTdvUEx4RlJDYlluWFRQN0RUTllaVXBnd1FLd2lEeVd4?=
 =?utf-8?B?WHc0UnpXcy9vTStYcGlZYlorR2NvYVdiaVcvM0pLa3pLSTczNFJhTHNsUzZ6?=
 =?utf-8?B?clprdHNKdFVWbkUySmt4OFI1UGxsYy93T2s1Q3lMM0RvTm9BVlRTZEdUQ2Ev?=
 =?utf-8?B?UFcraFhNdFRmVWhRRS9vT3FDM3JScG5MZVdOUjRyWTVTUkFwNVJMU0lPMEk1?=
 =?utf-8?B?QWRXQWNzTmJ1M3RuSXFTL0pKeER1cDhtaUVuMVRlWTBRRjNBODRubEhVR3Bi?=
 =?utf-8?B?cFJldjhWOUxXYlZDMzBwQ3V3L2FWTmpzRVdIUDhsaElKNm9uMkxaUXMyL1NM?=
 =?utf-8?B?OXFQQkp4MHNzdG1LdHBINDVNMXpUWFdpOXpTWE9YRUxVeHNRcit4bzA4QkRP?=
 =?utf-8?B?ZXc5MjNmb1BaZVhERFBUdTAwZFFwZGVKanl3VTl4N0tOandWNm4vejNYR01S?=
 =?utf-8?B?QlVVRm1wL21VQ1pHaFhJaEphVFhJNjdJZ1hLbUxrWlJFWHY4bEYwaGNYNEc4?=
 =?utf-8?B?eE5TNWtTNXkwMHl0b2JrdWdNVVp6UGs0anU5WjRyS1E0U1p6MzZGWXZoa1c3?=
 =?utf-8?B?Rlk0bFJZNWtrMzFLQy9NVEFKZjN5WUY0WEpZT1RJOXB0MGVkR2kxYTNnL3hk?=
 =?utf-8?B?bEh5d05RN2VNRmwzYWJLd2hJMERTaEVjMThHVlk3QWVwWjRFVGZuYjhOWkh1?=
 =?utf-8?B?eTArNlNCRVBqYklSZ2NraWdWckNPbERuQzdVeEhCMWQrV3NiTFhISFg2bVNC?=
 =?utf-8?B?OFFDdDlCS05zV1RhK00xSUZsbDhqa1FvR1BvTUNCZUY0ODdNZ0h5d2RlSE15?=
 =?utf-8?B?K3lFUmJEYUFPUVV1UnJiWmdHK2R0VjNOVERkM1JqTEtwWVhJQ3RHTmtZRzdD?=
 =?utf-8?B?YzQ3V2NvNnBKZnJ6ZVlyV2pRVWJIcW9TNmErcUt0UDVSdm85a1BwUWxkb3Rw?=
 =?utf-8?B?NGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a82a39c-753a-4be4-8078-08db25b1a0ac
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 00:01:44.0186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SDiAfRDEOR9Yi1lLlOmQjjLrUXDTj39LMAwS2mlEQo8+OMxzAQl/0mmWLAd/iFGL2Db+GlaUksBted5/tIXLtWtLDSqKRURlL5CMFE7BkHQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7083
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 2/15/2023 5:05 AM, Ilpo Järvinen wrote:
> resctrl_val() function is called only by MBM, MBA, and CMT tests which

Surely not a reason for a resubmit, but just fyi ... using "()" implies
that it is a function so there is no need to add the text "function".

> means the else branch is never used.
> 
> Both test branches call param->setup().
> 
> Remove the unused else branch and place the ->setup() call outside of
> the test specific branches reducing code duplication.
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette