Message-ID: <c17e8676-61b8-bd00-f8df-8c3a4794397a@intel.com>
Date:   Wed, 15 Mar 2023 17:02:08 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH v2 3/9] selftests/resctrl: Allow ->setup() to return
 errors
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>, Babu Moger <babu.moger@amd.com>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
References: <20230215130605.31583-1-ilpo.jarvinen@linux.intel.com>
 <20230215130605.31583-4-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230215130605.31583-4-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vk9jRFo4Z0huTDJOcGxjUU1MYWRnWm9LSnRYTVlZUHV3aVR3ZGUrN1hsYkpv?=
 =?utf-8?B?WjhDcUNYRE9MeVU1cXQyaWJlLzl5akR4d3BUMngvRStzZjBDeGNXZWplUmhz?=
 =?utf-8?B?bE5ldmg5eExqZ3kycGJWdW9lZjdaU2UwSWlUWVcxek11dUc5VEl4Unl0SXp1?=
 =?utf-8?B?TzZnWWxkWVdKdWc3NWxOMEppaEp6azBqSC9Wemk4VE1HYUdYMmwrd0NNaE9N?=
 =?utf-8?B?NGdoNTVKcXdUVGdmblY4Q1R5WmRnSm5RS21SUzFhZFdOdklqQk9PT3IvWS91?=
 =?utf-8?B?UXJEQ3FNTzB2RG5FNzRTTGRPZlV3ZmgzQ1Q3blNSdjA1MVB1bWM1TXJXY3dD?=
 =?utf-8?B?cVFESlp1Nm5NcVdMM20yVXZmd2NEenFQTFFiR29xeUJZWVhsY2VFeEpxdWYy?=
 =?utf-8?B?UEtjazdZQnFmWTBOUnBObFNMek1OT2ltUmpBR05sclRtZG5yNDdnb0lRNzd1?=
 =?utf-8?B?ay80MVVmUDlKK2ZUS050eEVPTU5hY1B1NlBxVDk3Tko3QnY3Vy9STnh0VEV6?=
 =?utf-8?B?S2NoaGVQTEQ3NTlweStSaWV4QWNXNTRBbStHRmJkT2tjcFVnZ0R5RytBZGNn?=
 =?utf-8?B?a0JzNHJHM3hFVzVML2IvUXhZYUF2OUtDTXhTZkZBY2pGcjhub2M3SW1sL3FU?=
 =?utf-8?B?d3VOWmJ6cEwzVVFxcHA5ZU95UWhmbVE1R2RHRGlnMHpNNk9UZjd0dTZjVFNW?=
 =?utf-8?B?SHNIMW1OQmdXTnZwTjZyaGJ6VitxdThXTC9xUVhKT3MvSlJHVVczallHYUNS?=
 =?utf-8?B?YXI1dnl1dU5OaG1CMDNVQTdkbXRBbi9hM2UrS01zTzFuRWtTUnBmSk1Ja0dw?=
 =?utf-8?B?RWE1aHhzTU9tdFBMMTkyNWdmNkpaU1ArOFJuakxGUXBJUGQ4N2xQYnVaV2ZE?=
 =?utf-8?B?eDFWdzNUMGtkZWZPVmtIN3pYK0dYUTNjVUdHdU56aDVicHVNV2NUZU5pZUZB?=
 =?utf-8?B?NG02N0tFanpVRVB2TWlsTjRMMlUxZFNDTUxqcU5MS0dVRkVBOElQOXYxWXZB?=
 =?utf-8?B?bkJGMm5IdngyMWw2dU5IakdkWmZDTlRDK1NNYnVoYmJzeEI1eUxJVHFDK1B1?=
 =?utf-8?B?VTFWNXV3SFVBNHJ0aGJubzVtdnJ1VWFwcVRudHpld3IvT1NtRjlYVHZwQVNV?=
 =?utf-8?B?b1ZIVjQ4MEpQZUxTazd4ejRQZXQramtyWnpzbjczUkpoc1RndGs5TXhZNmUr?=
 =?utf-8?B?cmtLYUszTTB0WU5LZnVvcUJFdmsyZmhFODgrYnkzL0M0bDdEQTQ5QUkyaWQy?=
 =?utf-8?B?eFRHenNvT1NhSy94QjRsNHdFNzlobHFiRUhXYm5iRy92dHZWMDgvYWxZVk1h?=
 =?utf-8?B?SnduTFk1Uk1sOE9sQk5JWnIva0hTeGxTQnFad3JNY2Z6ZTJTbXJIK1lBZnJj?=
 =?utf-8?B?RloyQjZYeElHM1p4UlZZQUpkbnJ1eFFid21aMnNLNHZUVGc1R3F4YXBhR3cz?=
 =?utf-8?B?Q2dPSDVsbTY1YU5TNFkrQ3MrTFNDVFIvNHZmV3VRemZuSmRTZXBDMUhjL3R1?=
 =?utf-8?B?MEV0YlZVSGpwZEZDMWpRNi9Ea2pVaFg4TVQ5aXZueENuRmJpUGkxOFpOQnJr?=
 =?utf-8?B?THZkbVpWbHBPTWxVcGFnYmlJY0xaOVdyNG5FV25PMjU2N2ZxL3FabzBCYy8w?=
 =?utf-8?B?ZXlhUG8rTDc1ZkFhVXpldkFySlhGcE9DMmsxU3RrMVpSWkxodG9nQ3Z2akYx?=
 =?utf-8?B?bEZyY3NNbEdvQTVUc2FocjVlbCtWcHBleEpPLzVqTitFYU9GRSthQ2thNXdr?=
 =?utf-8?B?VTZ1b0ZJTFMxMnExZUxyRC90YSswYkRjUFhXM3p4NmQ3c3JIN2M3dEwwYnJH?=
 =?utf-8?B?MWgyQytPbzdpb29zVHhYRXo1eHdydTVicWg3VTN1NFpLR3hBMHU5OFoybWk1?=
 =?utf-8?B?aWFtdTNiNUxhUWd3eHVHKzFXUlVMOXFjMThsNmNTQWhkZHJyd1JuYlVZSzk4?=
 =?utf-8?B?WVc4bmxHWVh1WnNlWXZrZ1FQcXNFM3lMU2I1VDIxM3dTTktmeDBMRlNUSURP?=
 =?utf-8?B?V3l0cmVJWTN2RU1FcFJ0dHFMVlhNMGJCc1FWZWU5ODVWbDgxTGZtQ2wrSzBX?=
 =?utf-8?B?VW0vRVM4Z1VOYkJMeE1LZlRzaEdTSG9lN3hvM2MwL3ROZkh3d0xwQXZvUWtx?=
 =?utf-8?B?TThCUlNFbDhYK0JuWHAxQVNMZzI4OGU2NjN1dm1Oc1l0QlFtMk1MSWE1L1ly?=
 =?utf-8?B?clE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 554b0a1d-6441-42c7-5121-08db25b1b0d2
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 00:02:11.1256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9YJ7XvHP3myUD2CIXNcsEzQwQfRhYDrsnxMSKrORNh4C6gnuEfeXJXNgQuCgWtlu8sidcxgo9ri5nyL/a2yVMeSI5d+6NLdSwso2RSCsFvQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7083
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 2/15/2023 5:05 AM, Ilpo Järvinen wrote:
> resctrl_val() assumes ->setup() always returns either 0 to continue
> tests or < 0 in case of the normal termination of tests after x runs.
> The latter overlaps with normal error returns.
> 
> Define END_OF_TESTS (=1) to differentiate the normal termination of
> tests and return errors as negative values. Alter callers of ->setup()
> to handle errors properly.
> 
> Fixes: 790bf585b0ee ("selftests/resctrl: Add Cache Allocation Technology (CAT) selftest")
> Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette