Message-ID: <26867b28-df48-20ea-96f5-df28c4c57b79@intel.com>
Date:   Wed, 15 Mar 2023 17:02:31 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH v2 4/9] selftests/resctrl: Check for return value after
 write_schemata()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>, Babu Moger <babu.moger@amd.com>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
References: <20230215130605.31583-1-ilpo.jarvinen@linux.intel.com>
 <20230215130605.31583-5-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230215130605.31583-5-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0ZhVnZpanNjdGVtMVRONmxLTEZadEFIZHp5Y1NCaVJQWnAvNTluL2ZEWERq?=
 =?utf-8?B?N3JzaDhZbEhidUgrMTZNb0laczVuWmVtanRsVUdXZDFnTTRUaXFnb3VvNkRS?=
 =?utf-8?B?NGY0djBBcGFoM1J4d3VkT3YzbXpkUmxmSTFmVWs0YVAvTUYvcWJ0d0wvL01t?=
 =?utf-8?B?THh4Q0VPM2FmbU1XWEE5Z3pQWDNTMUIrd0tKenIybnhWc2RwZVNjYVZhYTV5?=
 =?utf-8?B?aDhReEQ5VTc4ckJ0R1FHTFB2U0tOeXJiV3VoTXpRVjBibGJFL0VSQU53OG1H?=
 =?utf-8?B?T29RbGJMaFVsRDJhSVVka1JabUc0WjEvSG5CemI4TFVDakdqZFZEdzh6bGYw?=
 =?utf-8?B?QVNNODV5TVFXVG5TdyttVHIrWmRycjlIamI3ZjBIZWduV1VpbnBkRmhkdkZz?=
 =?utf-8?B?VXFPdXJrNlJoalRoWE93dHBSQkhVQmZuMloyc1ZXY3JyTUQxSDBxVzlVa28x?=
 =?utf-8?B?emhwbHgwcWl2YlI0dkJheW5IaUdTUmVzQVdLZ0M4cUxWOTgrdHgzOXVzRm9n?=
 =?utf-8?B?SU44OG03S3lVbUlPQ1A1SUNIMGxQclZhVzhoQWNaOXpxU29UY2VkWjdlU0V4?=
 =?utf-8?B?SVZzdTM0QmZ5cUphNU1XeHVaU2xBelNCTVR0M2s4T3hRb2ROZ1dQM0hQMUNy?=
 =?utf-8?B?TmdLVGgwVGNBNGQ5eFhOVllmUUFzMkZIcEVzdHRibk1oSHBDNGVLT0lMK2FC?=
 =?utf-8?B?ZFhHSFhZSWJKWS9TeXZPVmV2NC9LalJHOWNPYTBNT2V6QXJxa0tnUWRSZVJ6?=
 =?utf-8?B?UHpLNGlya2JlK29kdkNmMDVVL0luVGszcVdsTEJFakN0cStUQkY4ZWFxNExi?=
 =?utf-8?B?WUJabTRkNlNQYnlCd3YrSzZtZnhESzdFRDdaTkxmZGJ3MURFb3ArTmlyYjYw?=
 =?utf-8?B?ZEpqOXZzYS9KTk9FbVROYjdHbXdHTjczY0VEdFQxdEc4bDM0bHpkbWRKTThw?=
 =?utf-8?B?ZWNWR25jS0RhWGFDaXNaaXB3bk9kOVZUSjlVeG1Ya1k1dkIyanU0ZCtjZXk2?=
 =?utf-8?B?SHQ4ZjBxTmF4S0FUd3U5bCtKY0xCL1N5ODY5V2R1Q00vdVFwT3dCRGc4a3lS?=
 =?utf-8?B?YjBJbzRpTUVrSnlVMDhVUU44YUpFSzR2U2ZKcjNNSHJwZzZpNHlhdmN0Qnpu?=
 =?utf-8?B?dTZFc1hLeU8vdGNjSGNCUndwdk81Q1lEWHhSRFNvWTJuQi94bDlyaGxEU2hX?=
 =?utf-8?B?MmhmWVU1UlF6cHRhOUdXTmYzVmR1aDJobUdGM1RheEJ4R2RrUW5IODNnRzRP?=
 =?utf-8?B?b3Irak95a0dNcUFDVFJmL0Z6TVNQeHVFYzg4dXRzaVpYeVRjTEl5SGZFSHZs?=
 =?utf-8?B?Q0p2SGtnRzVvU3AyZ1JEWFFCaFVMMGJiTlgvbldnQmVXUm5RSHZvYmxoc2RL?=
 =?utf-8?B?aUQ1Z3pJaytBYlFETmhjZjRxdTZ2M3hLejBMWUdxRzZPM09BWEZzQVYzN2hq?=
 =?utf-8?B?M0VuRVFIMjNKWmU2OHQ0SWNwa3llRTY1d2dMZXM3SklhazA0RG12VGVQajV2?=
 =?utf-8?B?SnZzRjA3ZzRtaEMzbjhJakxhYTg5cWRJWmZqclZUNkhic3Y3Z2E4ZE1hWElt?=
 =?utf-8?B?YlpzdG5jaVJ1UlJJSDZ0TXNRNC9YYXh4aVEwUHdtdmcrVkNzNHhKcEU5Mkxu?=
 =?utf-8?B?cDYyZXJSWDloYmRtNUNLTzc3UVYxaDd0d2RGR0oyMXl1RXhsT2c4WFg3OHI2?=
 =?utf-8?B?NDJIaysvbjUyQVdUMmd3ZzlWalJackdOdHdyL2R0MURWQWdPK2phbnUzaGZI?=
 =?utf-8?B?TjhpNnZiK3BhNkRkejA3a0xScVpWT3pLdFVoNlM5aXphNlB3S1BiY3EzVkRq?=
 =?utf-8?B?UHNneWhlMlhCYjh3ajdTUmE5eEdCZThmSHpnMWRDUEVibjJPcnUwVTlWQnRL?=
 =?utf-8?B?RHhqNER3M3lPUEtOd3pLN2RrVVd6eVQxRUJpS0YzRi9nUVgvYWJQOGZnOCtr?=
 =?utf-8?B?TUdZSE9MQ3BWaWZObERzdzdOWmNlU3R0MkZFQjJ6clA4YklKVTZTMlR0Q0tn?=
 =?utf-8?B?ZDNobDNzTUU5djNNN2ZKRWV1MW9zdmlGQ3Z5a3F5MUFRb2psd3JBZVhrTURM?=
 =?utf-8?B?UUlPRmVqdDlXSHVrM3U1TjlvVFpPNHJFMEhReWR6cnpOZlZnLzc0VlRhekRN?=
 =?utf-8?B?T0M4NGlabU41U2U2NFAyTVpJbW1MUlFEaWZ6RHQ4Z21NUXgzeHJCSUdkQXFS?=
 =?utf-8?B?aFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a014c085-77cb-4cc4-3eae-08db25b1be3b
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 00:02:33.5924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xs7Poq9EGarAV8TJEE4gVXOVXbNYCvezXroJZ3BwHzNoWLow9PhdRIgoNuFVzbUwp/MF1G/gxF6Lu8kqPqeWz6ReXUdsEJHF7lq8gpUcZN8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7083
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 2/15/2023 5:06 AM, Ilpo Järvinen wrote:
> MBA test case writes schemata but it does not check if the write is
> successful or not.
> 
> Add the error check and return error properly.
> 
> Fixes: 01fee6b4d1f9 ("selftests/resctrl: Add MBA test")
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette