Message-ID: <d95bdf27-1584-39f1-e227-0d5fad707279@intel.com>
Date:   Wed, 15 Mar 2023 17:03:19 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH v2 6/9] selftests/resctrl: Change initialize_llc_perf()
 return type to void
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
References: <20230215130605.31583-1-ilpo.jarvinen@linux.intel.com>
 <20230215130605.31583-7-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230215130605.31583-7-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3ZDTW5LOWRNQWlCK1ljR3hVRzVMT2NvS1RxS21RaG5oSkxaYUJ4VlkzdG44?=
 =?utf-8?B?c3MrblZUVmZScjJqUUxTRncxbnc5OWtudTZ3N2tLejBBVjJkZHFXQmErazVl?=
 =?utf-8?B?dHVJd2lqVnlkSXFHb2JoM2kycjRzZnZ6aTBqL2pRaVRBVHhvZzRkcmVnWjFy?=
 =?utf-8?B?RHg4Tjd5clR4YTlqcjFpbkd3Z1RlaFVWTURiZnBwYWNpeXRVZWNUcFFYK1JB?=
 =?utf-8?B?L1h0SVpmKzltUzA2UEl5UmVsVzhrbmFxWDgraUs1OEtIczQzOUpsTkJGQU9M?=
 =?utf-8?B?OFpEcHp6Z1Y1THMvOENiSW41aUo2bExyeWJwNGJBekVtSzY0Q2ZSNWdtRGt3?=
 =?utf-8?B?RVNJM2NuNkZ5d0hGemQ4dmdWK1dZUW0zcnJHN3M3M0RBRlVrRkJuVnpZWUxB?=
 =?utf-8?B?Ui95QTIxQWdCYXVtMHBKQTVlRzJISys4OS9WQTFaenhIVHAxVElsMXRBQmxL?=
 =?utf-8?B?MldBcnNhYVpvME15RXE5c2FENGdDRmZESXBwUHljSGVsTUZ3cXVKOWczRnNI?=
 =?utf-8?B?Y2VUTzQ2cktCa3NlT0o1dHorMVoraFZaYktYSXljK20xQWRRRkNPaTEyTGJU?=
 =?utf-8?B?ZnBhbGExL1Frb0NPUDY2a1UwSTNIaDNtUGVOaDhLY3hQa2lWYklJQXZWd2Yw?=
 =?utf-8?B?enRnZzNDTzNzVDRFZWM0QnFhM002Um9ZR2lWRVpoUW5ldTlML2ZOczE0MHdF?=
 =?utf-8?B?VDZCaUxiTmZJbnptdTlLZVhxeDBrdWVSaFdVMmdLRHhvUFNFZ2EwSVlqUUoz?=
 =?utf-8?B?QU05QUpjclhOZC9Uc0tpOXZBMlI5SjdPUTVLZ0trcnBwbjBSMVkrUE1aOGQ0?=
 =?utf-8?B?RDZNdjZvMXJJcGkrM1JncDE2UU1SekxMeU9QYk9YYnZLZmZxZ3pHeFlhRVpI?=
 =?utf-8?B?cDB0Vlhsa2tIczcyajlUYzVTbGRkUitrOFJWSi9ucFNOZkl2czZyeTVmcVVs?=
 =?utf-8?B?WGdoOFlCUWNjOGsvTUU3WlJFc2taemFTVGtnZDJ6R3Y4SXJPZDZOZ0U4Mk4x?=
 =?utf-8?B?d2l5Zmp3YXhrcms4Z3RkUVRKVzhNSHRvdnVnVzZCTk9UUEIrYnNielFzQ09B?=
 =?utf-8?B?TVlLL0RhYzcreGlVMjViakJjbFVkVXJmYk1odDlKUGxYY3paYk0zOUpDRkJi?=
 =?utf-8?B?ZXVsSXd1NXBZTDNwWXpRcEtFVis4WE9ZNWZUUWx5SU5tb2NhdHN6c3g3cWpq?=
 =?utf-8?B?UHczemRYWGkyRUhET1NUVk1lYmlONzc2bTdJc0U5bnE5N3Eyd05ZS0o1bkJa?=
 =?utf-8?B?WElrOUcveDAxZzdRaTRaMS9xUDlMeGZNSjVYbGxUM0NsRVp0K21mbkc5Sk9W?=
 =?utf-8?B?aDRiVC9JQ0kzek1iUUFCRDAvem8zZVE2WGlnczhKWlkxemR2Wkp3NWE5OHZF?=
 =?utf-8?B?MnhIbFFBTitySTJMWG1jWFQxWHYrSHJVVUZjMXYrY1Q5YjhtUXc3d2k0TE9P?=
 =?utf-8?B?QmhpbFU5Y09kY1dQaFAxTDJnU1JoNmpVemF3TU9EdXdNalNGK010YmM4TjVC?=
 =?utf-8?B?RzR5MWFEanlRYUJMbEN3NXczSVFCY01makx3aEFqTHJXTW05NUVidmxaMTBT?=
 =?utf-8?B?RnBxNE4xeWNtamM2SytXSTdieUZJZTlnQ1JEdXVTWlBHZVRvc1dFdVBXbEdU?=
 =?utf-8?B?NDRVT3BtQzFZaGtlN1BNQytyd055M1NpdlcrM2RyQnFPUnpRemYvS1JmY0JL?=
 =?utf-8?B?M2tuckRjQTIvd2t5YUlRb2M1ODRGbmhmNGEydEprVm9HMkhOeDhmaUxSNDVP?=
 =?utf-8?B?U090QXZIVnFIeUpNUllwbUhnZ0c1SG80MmhXVmJNNFd5Qk9yRFlBOWczZVNy?=
 =?utf-8?B?dGtCVXhWMGpsNjZqeE5JdHFTVjBiUkxhTFA1dDF1cWVxVXAxZWpDdmVMYW5k?=
 =?utf-8?B?VnNkZElkMlIwaUNWYjJTb05KV1pHZERaazBwRzVIdEpLdVpSWDA2Y1V1TlNr?=
 =?utf-8?B?NnhFdHRjQUQvN3VxclZTL0s5TkZWOU03WDlwdjhRZHZ3aEhqVUZLZDFlRHU4?=
 =?utf-8?B?cVNRN2xNUzZSL1d3RzdFVzZ6cGNyNk8zWjJTUnBYL3pmSVU0SThCWFVIL3VE?=
 =?utf-8?B?RWhRcGMwRnJwa0d3WUlKd09pZEpPYk5peG9jczJ3MXYzVlFrQzI5enNiRkNC?=
 =?utf-8?B?TlpwclB2MkZXV2JDdVczUFNXY3RHUHBkUHptTUszd3FybXF3NS93Z0llQ0wv?=
 =?utf-8?B?ZEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 58b8de12-f858-4d99-8251-08db25b1db06
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 00:03:21.9007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MbUELGJTc6z7Vt/soRCeKA4MGSQG8f1gtR+vH5zVgaIQKWjJZttzXyL2V2rqlInyxiFKdiEfZmRkZ0YLzmQA8oe/PIWdmtvLP4pVoTd0dW0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5340
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 2/15/2023 5:06 AM, Ilpo Järvinen wrote:
> initialize_llc_perf() unconditionally returns 0.
> 
> initialize_llc_perf() performs only memory initialization, none of
> which can fail.
> 
> Change the return type from int to void to accurately reflect that its
> return value doesn't need to be checked. Remove the error checking from
> the only callsite.
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette